----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119958/ -----------------------------------------------------------
(Updated Sept. 4, 2014, 3:43 p.m.) Review request for KDE Frameworks and David Faure. Changes ------- Ping? Repository: kio Description ------- Fix a regression in PreviewJob. This one was hard to find :) KService::mimeTypes cannot handle mimetype groups. ex: text/* Use KService::serviceTypes instead and ignore the first item which is always type 'ThumbCreator' This is the quick and easy solution. I could also add support for mimetype groups to KService::mimeTypes. (so that it return all mimetypes in a group) Not sure what the best solution is. Are groups only used in thumbnailer files? Diffs ----- src/widgets/previewjob.cpp 55a3fb7 Diff: https://git.reviewboard.kde.org/r/119958/diff/ Testing ------- I'm porting a thumbnailer to frameworks 5. Before nothing happend, now I see thumbnails. Thanks, Maarten De Meyer
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
