D5788: Add syntax highlighting for YANG data modeling language

jkt added a comment. Re "extracting bits from the RFC", RFC 6020 says (among other things) that //"Code Components extracted from this document must include Simplified BSD License text as described in Section 4.e of the Trust Legal Provisions and are provided without warranty as described in

D5788: Add syntax highlighting for YANG data modeling language

jkt accepted this revision. jkt added a comment. Oops, sorry, I forgot to comment here. I appreciate your conversion, it works really nicely! Compared to the vim version, my QtCreator theme is not highlighting the `true` and `false` keywords in statements such as `mandatory true;`. That'

Re: Differential e-mail subject re-arrangement

On čtvrtek 2. března 2017 9:08:25 CET, Ben Cooksley wrote: In regards to the way email subjects are treated, I've now customised the metamta.differential.subject-prefix preference on our installation to be blank, to the "[Differential]" part should no longer be present. Roughly at the time you

Re: Review Request 129426: refactor gpg finding

> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Haral

Re: kdewebkit?

On Thursday, 21 April 2016 18:33:51 CEST, David Edmundson wrote: -postCheckoutCommand=./init-repository -f +postCheckoutCommand=./init-repository -f --module-subest=default,qtwebkit That parameter is called --module-subset, not --module-subest (on both places). -- Trojitá, a fast Qt IMAP e-m

Re: QString -> QStringLiteral conversions might make applications crash on exit

On Monday, 29 February 2016 23:16:22 CET, Frank Reininghaus wrote: If something like "do not use QStringLiteral in plugins" will be the conclusion from this issue, then I'm all for continuing to use QStringLiteral everywhere else in order to avoid heap allocations. The conclusion is "do not unl

Re: QString -> QStringLiteral conversions might make applications crash on exit

On Friday, 26 February 2016 01:37:57 CET, Frank Reininghaus wrote: This becomes a problem if the read-only data that the QString refers to are not there any more, which can happen if the QString was stored in a global static object from one library, and the QStringLiteral is from another library,

Re: test failures on http://ci-logs.kde.flaska.net

And indeed the value of XDG_DATA_DIRS in http://ci-logs.kde.flaska.net/7f/7f50569d59eabc20897f54fb97483bd7f8b89d63/rebuilddep/rebuilddep-kf5-qt55-clang-el7/3cef5be/shell_output.log is long and messy and has /usr/share in front (so it's viewed as being "on top of" the kde mimetype file, while it's

Re: Scope of framework integration plugin?

On Monday, 30 November 2015 14:45:41 CET, René J. V. Bertin wrote: Would you really expect Qt to accept a patch that allows generic applications to use font role specifications from KF5? Yes, I think that such a goal is fully in line with Qt's attempt at being reasonably cross-platform. The

Re: Build and test failures with Qt 5.6 and Qt 5.3

On Tuesday, 10 November 2015 08:34:02 CET, Martin Graesslin wrote: Yes, most tests don't require a WM. Especially the Net* tests simulate being a window manager. Only the KWindow* tests need a window manager. Interesting; it was a Heisenbug, apparently. I cannot reproduce it anymore, but I've

Re: Build and test failures with Qt 5.6 and Qt 5.3

On Monday, 9 November 2015 08:21:21 CET, Martin Graesslin wrote: I'm sorry, but I'm not able to reproduce the failure on my local Qt 5.6 setup. The failures look like there is no WM running on the CI system, maybe openbox crashed? (We had that before that our tests were able to trigger crashes

Re: Build and test failures with Qt 5.6 and Qt 5.3

On Saturday, 7 November 2015 11:59:48 CET, David Faure wrote: Having this for all of KF5 would definitely be useful. And it's done now: http://ci-logs.kde.flaska.net/matrix.html - [5.3] ballo, missing QList::join - [5.3] knewstuff, QTimer::singleShot and new slots - [5.3] modemmanager-qt, ch

Re: Build and test failures with Qt 5.6 and Qt 5.3

On Sunday, 8 November 2015 12:17:19 CET, David Faure wrote: Any chance you could do some debugging around there? I'm afraid I don't have time and motivation to fix this, sorry. I'll be happy to spin a VM with an identical setup for you, though, if you're OK with IPv6-only access. If so, pleas

Re: Build and test failures with Qt 5.6 and Qt 5.3

On Saturday, 7 November 2015 22:38:16 CET, Ivan Čukić wrote: - [5.3] kactivities: won't build due to QQuickWidget::setClearColor which is 5.4+ only. It should be ok now. I've added a work-around (essentially how the method is implemented in 5.4 and 5.5). kactivities/src/workspace/settings/im

Re: Build and test failures with Qt 5.6 and Qt 5.3

Hi David, thanks for looking into this. I'm happy that you find the additional coverage useful. At this time, the infrastructure cannot easily send out automated e-mails only upon a change in the state of a build job -- if someone has some time and is willing to improve this, I'll be happy to w

Build and test failures with Qt 5.6 and Qt 5.3

Hi folks, please take a look at the CI status matrix at [1]. TL;DR: There are build failures with Qt 5.3, plenty of test failures, and some test failures specific to the still unreleased Qt 5.6. Oh, and a cmake 3.4-git regression that I'm not going to bother you with. Reported, known, downgra

Re: marble builds when it shouldn't

On Tuesday, 22 September 2015 13:00:38 CEST, Harald Sitter wrote: Also on a more general note: I think it would be handy if all builds used CMAKE_VERBOSE_MAKEFILE=TRUE to get verbose make output which would make it easier to notice when things such as -DNDEBUG are passed to gcc. Absolutely -- t

Re: Review Request 124384: Fix build with Qt < 5.4

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit bc0848882cea3943c69a1dfb6ca427fa11d07ef9 by Jan Kundrát to branch master. Repository: kwindowsystem Description --- The QJsonArray::operator->() got added in qtbase's commit 7dce9622

Re: Review Request 124386: Fix build with Qt < 5.4

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b54a1b2dab13569d73ec5ba55358689e8849cc01 by Jan Kundrát to branch master. Repository: kidletime Description --- The QJsonArray::operator->() got added in qtbase's commit 7dce9622

Re: Review Request 124385: Fix build failure with clang 3.4.2

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 4316ecb1b96a758afda79a0108d008f001171734 by Jan Kundrát to branch master. Repository: kitemmodels Description --- autotests/kextracolumnsproxymodeltest.cpp:68:9: error: control may reach end

Review Request 124386: Fix build with Qt < 5.4

--- The QJsonArray::operator->() got added in qtbase's commit 7dce9622 which is only present in Qt 5.4. Diffs - src/kidletime.cpp 675cd2bc1642906c0fe21fa2f674549f85cf0aac Diff: https://git.reviewboard.kde.org/r/124386/diff/ Testing --- Thanks, Jan

Review Request 124385: Fix build failure with clang 3.4.2

--- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 124384: Fix build with Qt < 5.4

Description --- The QJsonArray::operator->() got added in qtbase's commit 7dce9622 which is only present in Qt 5.4. Diffs - src/pluginwrapper.cpp c3eed03d559308ad4d158a5de112febb50e6c93e Diff: https://git.reviewboard.kde.org/r/124384/diff/ Testing --- Thanks, Jan

Re: A CI dashboard with multiple versions of Qt5 on Linux

On Friday, 12 June 2015 01:29:59 CEST, Scarlett Clark wrote: Question, is your Qt5.2 patched? I'm pretty sure that it was a vanilla build straight from git on CentOS 7 back in December 2014. I have no idea what failure you saw and I agree that "no patches" is a good general approach, but I

A CI dashboard with multiple versions of Qt5 on Linux

Hi, if you would like to check how well the KF5 builds cope with multiple Qt5 versions, take a look at this page generated from the Zuul/Gerrit CI system: http://ci-logs.kde.flaska.net/matrix.html I am open for suggestions for service improvements, so if you have an idea on how to make this

Re: Review Request 123743: Fix missing category to silence `desktop-file-validate`

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit aa3c4e7797940e53433dfbd38a1bdc4b0a5727a6 by Jan Kundrát to branch master. Repository: ksshaskpass Description --- src/org.kde.ksshaskpass.desktop: error: (will be fatal in the future): value

Review Request 123743: Fix missing category to silence `desktop-file-validate`

nds closer to the actual purpose of this application. Either this one, or let's remove the Security bit altogether. Diffs - src/org.kde.ksshaskpass.desktop a5fa682b7e6195be2474f2547714d71d68dd7284 Diff: https://git.reviewboard.kde.org/r/123743/d

Re: Review Request 123731: Cleanup handling of notifications closing

nullptr already? If not, can you fix the cause of that? src/notifybypopup.cpp (line 491) <https://git.reviewboard.kde.org/r/123731/#comment55062> Is there an enum for this? Using that instead of a comment which explains what a magic value is about sounds much better. - Jan Kundrát On

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

> On May 12, 2015, 3:49 p.m., Jan Kundrát wrote: > > Was the old code a part of some release? If yes, this should get a CVE > > security announcement because it allows a local attacker to e.g. force you > > to overwirte some of your user's files. > > Michae

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

get a CVE security announcement because it allows a local attacker to e.g. force you to overwirte some of your user's files. - Jan Kundrát On May 12, 2015, 12:49 p.m., Michael Palimaka wrote: > > --- > This is an automatical

Re: Review Request 123700: Fix build with cmake 2.8.12.2

marked as submitted. Review request for KDE Frameworks, KDEPIM and Albert Astals Cid. Changes --- Submitted with commit 1d00de33fb56137b94d19e0fb70aa7e03703751f by Jan Kundrát to branch master. Bugs: 347399 http://bugs.kde.org/show_bug.cgi?id=347399 Repository: kpeople Description

Re: Versioning of Frameworks

On Sunday, 10 May 2015 15:39:02 CEST, David Faure wrote: Qt *is* splitted. It's just that the splitted libs are released together. The splitting of Qt is not "full and complete", however. Modules tend to use each other's internal APIs, and that's the biggest reason for not supporting random m

Review Request 123700: Fix build with cmake 2.8.12.2

mmary of the situation. [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2014-December/020713.html BUG: 347399 REVIEW: 123700 Diffs - src/match.cpp f84a824 Diff: https://git.reviewboard.kde.org/r/123700/diff/ Testing --- Thanks, Jan Ku

Re: Review Request 123679: Fix build with Qt 5.5

marked as submitted. Review request for KDE Frameworks and Stephen Kelly. Changes --- Submitted with commit d598382536d8c9982bba3ee210869e50d1313dff by Jan Kundrát to branch master. Repository: kitemmodels Description --- Turns out that there's apparently no overload accept

Re: Review Request 123679: Fix build with Qt 5.5

https://git.reviewboard.kde.org/r/123679/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123679: Fix build with Qt 5.5

Diff: https://git.reviewboard.kde.org/r/123679/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Versioning of Frameworks

Hi Christian, I think that the stuff you're looking for (reducing version churn) can also be provided by having stable branches for selected parts of KF5. IMHO this can be quite an elegant solution given the usual cat-herding problem of FLOSS where people just do what they want to do. Those wh

Re: stable-KF5-QT5 QT version...

On Saturday, 18 April 2015 17:17:16 CEST, Scarlett Clark wrote: "qt5": { "kf5-qt5": "5.4.1", "stable-kf5-qt5": "5.3.2" }, The impression which I got in my earlier inquiries about this topic was that there's no KDE-wide consensus on which Qt5 version is t

Re: Review Request 122978: Add unit test for crash of bug 343976

x27;t know the code and API asumptions to know whether it's better to just Q_ASSERT in the other methods (`setText` etc.), but even if it was better to assert crash, this patch does provide a big improvement :). - Jan Kundrát On March 16, 2015, 12:04 p.m., Martin Grä

Re: Review Request 122908: Fix segfaults due to missing screens

missing. Diffs - src/kwindoweffects_x11.cpp 661a0af95a7a1757c5ae863270434b0c2d5c0a26 Diff: https://git.reviewboard.kde.org/r/122908/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 122978: Add unit test for crash of bug 343976

6 #49 0x555b9c08 in main (argc=3, argv=) at /home/jkt/work/prog/trojita/src/Gui/main.cpp:217 ``` src/platformtheme/kdeplatformsystemtrayicon.cpp <https://git.reviewboard.kde.org/r/122978/#comment53282> What about just: if (m_menu) - Jan Kundrát On March 16, 2015, 10:58 a

KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter

Hi, kdeclarative doesn't build on Qt 5.2 since commit 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged almost two months ago. Seems that I should configure some breakage notifications from the Z

Review Request 122908: Fix segfaults due to missing screens

Diff: https://git.reviewboard.kde.org/r/122908/diff/ Testing --- Thanks, Jan Kundrát ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122843: Mark QuickAddons as its own project.

this! - Jan Kundrát On March 6, 2015, 4:07 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Required and supported Qt versions

On Tuesday, 30 December 2014 09:32:08 CEST, David Faure wrote: Ideally every released minor version since 5.2 :-) i.e. 5.2, 5.3, 5.4. Possibly even dev. Hi, the CI which is plugged into Gerrit now checks the following combinations: - Qt 5.2.1, GCC 4.8.2 (RHEL7), release mode - Qt 5.3.2, clang

Re: Qt 5 buildability

On Thursday, 8 January 2015 22:59:53 CEST, Ben Cooksley wrote: QtWebEngine won't build unless you have nss-devel installed (which it complains about) but it also won't build unless libcap-devel is installed (which it doesn't complain about - you only find out when the compiler bails out on you).

Required and supported Qt versions

Hi, is there a minimal required Qt version which applies to all of KF5? I see that most of the modules I currently have checked out say that they need 5.2.0 while polkit-qt-1 declares itself compatible with 5.1.0. - Is that information correct? Is 5.2.0 universally supported? - Is there any va

Re: Review Request 121575: FindEpoxy.cmake

> On Dec. 18, 2014, 8:47 a.m., Martin Gräßlin wrote: > > find-modules/Findepoxy.cmake, line 14 > > > > > > I just need to point out that I consider epoxy as a bad dependency for > > usage in a cross platform libr

Re: OSX/CI: kio fails to build on branch master

On Saturday, 13 December 2014 13:55:25 CEST, Marko Käning wrote: Any idea what’g going on with this XML file? One option is to run make with VERBOSE=1 (either asn an env var, or as an argument to make). That way, the output will contain information on what commands are executed, and you shoul

Re: plasma-framework now getting early CI feedback on changes within Gerrit

On Tuesday, 9 December 2014 19:44:19 CEST, Jan Kundrát wrote: I've activated CI checking for changes proposed to plasma-framework (kio is waiting for a review of two patches which improve test stability). KIO is now getting this, too. Sorry for the mail noise associated with re-c

plasma-framework now getting early CI feedback on changes within Gerrit

Hi, I've activated CI checking for changes proposed to plasma-framework (kio is waiting for a review of two patches which improve test stability). The build environment is different from the one at build.k.o, but the scripts are more or less the same. Both the default build/test variant and t

Re: KIO's KDirListerTest::testRefreshRootItem on RHEL7 and XFS

After applying [1] and [2], I don't see any more test failures -- reviews are appreciated. With kind regards, Jan [1] https://gerrit.vesnicky.cesnet.cz/r/#/c/204/3 [2] https://gerrit.vesnicky.cesnet.cz/r/#/c/208/6 -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ _

Re: KIO's KDirListerTest::testRefreshRootItem on RHEL7 and XFS

It looks like there are more failing tests, and in a non-deterministic manner. An example of a failing one is [1] while I've also seen all of them succeeding, [2]. Are you guys sure that these tests are really doing the right thing and that there are no failures when you run them a thousand ti

KIO's KDirListerTest::testRefreshRootItem on RHEL7 and XFS

Hi, there's one test in KIO which keeps failing when I run it inside my CI environment (a RHEL7 VM with XFS). Take a look at [1], the /tmp/kdirlistertest-dIp2zR/subdir's mtime and atime are getting bumped by one second. The patch which introduces this debug output is at [2]. I will admit th

Re: Debugging failures in KIO when using custom CI environment

It seems that the problem is related to how a kioslave is launched along with using different installation dirs. Here's what got me to the right path: 13032 execve("/home/turbo-hipster/target/el7-x86_64-gcc/kf5-qt5/frameworks/kio/inst/lib64/libexec/kf5/kioslave", ["/home/turbo-hipster/target/

Debugging failures in KIO when using custom CI environment

Hi, I'm working on a testing setup which plugs into Gerrit to add info whether a proposed change still builds and tests continue to pass. This is using a modified version of KDE's own Jenkins' CI scripts, but the environment is very likely much different. It runs within a sanitized environment

Re: Gerrit available for trial

On Saturday, 11 October 2014 11:57:20 CEST, Kevin Krammer wrote: I am not opposed but I think just the new ones would be sufficient. If one is interested in the proceedings of a specific request it is easy enough to add oneselves as a reviewer. It also makes the "new" notification stand out si

Re: Gerrit available for trial

On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote: However I can't add the KDE contributors that I want, to the request. They all have a KDE identity account, but obviously didn't create a gerrit account yet. Hi David, all KDE developers are now available in Gerrit, so you can start

Re: Gerrit available for trial

On Friday, 10 October 2014 23:38:37 CEST, David Faure wrote: Another issue: could all incoming review requests for kio (and all other frameworks in the future, except plasma-framework which has a dedicated list) be sent to kde-frameworks-devel? I don't see a mail with my request there. Sure,

Re: Gerrit available for trial

On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote: Is there any chance we could import all of KDE identity into gerrit? Otherwise that doesn't really make it usable, until everyone has created an account there - which won't happen. I think with reviewboard we can add anyone with a KDE i

Re: What's "qt5-stable" on build.kde.org

On Thursday, 18 September 2014 10:10:41 CEST, Ben Cooksley wrote: This would still apply even after the implementation of new scheme for dependencies and other build metadata. Where do I learn about these new features? Cheers, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.fla

Re: Gerrit available for trial

Hi folks, we're trying to document how to work with Gerrit within KDE at [1]. If you can make that page better, please go ahead. With kind regards, Jan [1] https://techbase.kde.org/Development/Gerrit -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ __

Re: Review Request 109551: port KPtyProcess to QProcess

org/r/109551/#comment21974> Why are these commented out instead of being removed? - Jan Kundrát On March 17, 2013, 4:44 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > --- > This is an automatically generated e-mail.