----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122978/#review77574 -----------------------------------------------------------
Ship it! +2 from me -- it fixes a crash for me. +I don't know the code and API asumptions to know whether it's better to just Q_ASSERT in the other methods (`setText` etc.), but even if it was better to assert crash, this patch does provide a big improvement :). - Jan Kundrát On March 16, 2015, 12:04 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122978/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 12:04 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 343976 > https://bugs.kde.org/show_bug.cgi?id=343976 > > > Repository: frameworkintegration > > > Description > ------- > > Use a QPointer for QMenu of SystemTrayMenu > > We need better memory management as the QMenu the SystemTrayMenu creates > might be deleted externally causing a double delete if the so-far > QScopedPoiter cleans up. > > Switch to QPointer and call deleteLater if the pointer is still valid > during destroying the SystemTrayMenu. > > BUG: 343976 > CHANGELOG: Fix possible crash when destroying a QSystemTrayIcon (triggered by > Trojita) > > > Diffs > ----- > > autotests/CMakeLists.txt e8ed6a99bb45969231ba21b8c5588e093bbbe3ee > autotests/ksni_unittest.cpp PRE-CREATION > src/platformtheme/kdeplatformsystemtrayicon.h > 8f13a36ae7cebed7499ce8a160f3533665b909ac > src/platformtheme/kdeplatformsystemtrayicon.cpp > ce3d3de9f9cf479a5fe3af65ef7fb8ec2b9e0d29 > > Diff: https://git.reviewboard.kde.org/r/122978/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
