Re: Review Request 122642: an include is not correct

atal error: 'kcoreaddons_export.h' file not found#include "kcoreaddons_export.h" I propose to change it to #include Diffs - src/lib/plugin/kpluginfactory.h d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5 Diff: https://git.reviewboard.kde.org/r/122642/diff/ Testing --- Thanks, Guy Maurel

Re: Review Request 123831: Coding Style for main.cpp

marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit df5ffbdf5a9d940a61e4552603e6a19832285781 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http

Re: Review Request 123830: Coding Style for main.cpp

marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit df5ffbdf5a9d940a61e4552603e6a19832285781 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for kdepim: http

Review Request 123830: Coding Style for main.cpp

/r/123830/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123831: Coding Style for main.cpp

://git.reviewboard.kde.org/r/123831/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit c10e72b8b641a4777672bd35c0ba080b1b075fd2 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for kdepim

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

complicate. I am working on uncrustify to provide an uncrustiy script to follow the kdelibs. - Guy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/#review80430 ----------

Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp kxz

--- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h kcompressiondevice.h kfilterbase.h kfilterdev.h klimitediodevice_p.h kxzfilter.h kzip.h

marked as submitted. Review request for Akonadi, KDE Frameworks, Mario Bensi, and David Faure. Changes --- Submitted with commit 5b895eba62517c69020736276dd35c4ac96bb957 by Guy Maurel to branch master. Repository: karchive Description --- We use for karchive the same rules as for

Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h kcompressiondevice.h kfilterbase.h kfilterdev.h klimitediodevice_p.h kxzfilter.h kzip.h

://git.reviewboard.kde.org/r/123439/diff/ Testing --- Could anybody take care of this review after 30 days? Thanks. Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 123419: CodingStyle for autotests

the informations? - Guy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/#review79179 --- On April 19, 2015, 4:

Re: Review Request 123419: CodingStyle for autotests

marked as submitted. Review request for KDE Frameworks, Mario Bensi and David Faure. Changes --- Submitted with commit b8f25b58e7dbf641fbe5e16c2982566c6729e9de by Guy Maurel to branch master. Repository: karchive Description --- Details can be seen at: http://techbase.kde.org

Review Request 123419: CodingStyle for autotests

://git.reviewboard.kde.org/r/123419/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122642: an include is not correct

s_export.h" I propose to change it to #include Diffs - src/lib/plugin/kpluginfactory.h d2ffbdd22c8cbd553f74e11d0499dbf97adc28b5 Diff: https://git.reviewboard.kde.org/r/122642/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-dev

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

92e2d8d4cf1f9e342f1c509 Diff: https://git.reviewboard.kde.org/r/122445/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

4cf1f9e342f1c509 Diff: https://git.reviewboard.kde.org/r/122445/diff/ Testing --- Thanks, Guy Maurel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

view75949 --- On Feb. 5, 2015, 7:36 p.m., Guy Maurel wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

;/"); QString dirPlus; ... Q_FOREACH (...) { dirPlus = dir; dirPlus.append(plus); if (path.startsWith(dirPlus)) { Diffs - src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509 Diff: https://git.reviewboard.kde.org/r/122445/diff/ Testing

a problem with kdesktopfile.cpp

1); relativePath is sometimes mysterious: (gdb) printqs5static path (Qt5 QString)0xbcb8 length=17: "kdevninja.desktop" (gdb) printqs5static dir (Qt5 QString)0x26be3f8 length=21: "/home/guy-kde/.config" (gdb) printqs5static relativePath (Qt5 Q