-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122445/
-----------------------------------------------------------
(Updated Feb. 16, 2015, 3:50 p.m.)
Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez, and
Thiago Macieira.
Changes
-------
done
Repository: kconfig
Description
-------
The if statements at lines 84, 91
if (path.startsWith(dir) + '/') {
cannot be correct. The value of (path.startsWith(dir) + '/') is always 47.
I propose to use:
QString plus = QLatin1String("/");
QString dirPlus;
...
Q_FOREACH (...) {
dirPlus = dir;
dirPlus.append(plus);
if (path.startsWith(dirPlus)) {
Diffs (updated)
-----
src/core/kdesktopfile.cpp 6381cb30ba9382de492e2d8d4cf1f9e342f1c509
Diff: https://git.reviewboard.kde.org/r/122445/diff/
Testing
-------
Thanks,
Guy Maurel
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
