This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b8bd61c3650c: User can now hide an entire places group
from KFilePlacesView (authored by franckarrecot).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=23630&id
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cd9856d14552: Hidding place groups implementation in
KFilePlacesModel (authored by franckarrecot).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=23629&id=23632
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2cd35636bbf9: Refactoring the hidding/showing animation
use within KFilePlacesView (authored by franckarrecot).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9015?vs=2
franckarrecot updated this revision to Diff 23631.
franckarrecot added a comment.
rebased
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9015?vs=23411&id=23631
REVISION DETAIL
https://phabricator.kde.org/D9015
AFFECTED FILES
src/filewidgets/kfileplacesvie
franckarrecot updated this revision to Diff 23630.
franckarrecot added a comment.
corrected and rebased
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=23410&id=23630
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
autotests/kfilep
franckarrecot updated this revision to Diff 23629.
franckarrecot added a comment.
rebase
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=23409&id=23629
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplacesmodeltest.
franckarrecot updated this revision to Diff 23409.
franckarrecot added a comment.
rebase to master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=23024&id=23409
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplaces
franckarrecot updated this revision to Diff 23411.
franckarrecot added a comment.
rebase to master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9015?vs=23072&id=23411
REVISION DETAIL
https://phabricator.kde.org/D9015
AFFECTED FILES
src/filewidgets/kfile
franckarrecot updated this revision to Diff 23410.
franckarrecot added a comment.
rebase to master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=23025&id=23410
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
autotests/kfileplaces
franckarrecot updated this revision to Diff 23072.
franckarrecot marked an inline comment as done.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9015?vs=23026&id=23072
REVISION DETAIL
https://phabricator.kde.org/D9015
franckarrecot marked 2 inline comments as done.
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:811-813
> This whole change on the if structure there is unrelated to the rest of the
> patch so please remove it. Beside this seems to change the semantic, w
franckarrecot marked 15 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
franckarrecot marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
franckarrecot updated this revision to Diff 23026.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9015?vs=23000&id=23026
REVISION DETAIL
https://phabricator.kde.org/D9015
AFFECTED FILES
src/filewidgets/kfileplacesview
franckarrecot updated this revision to Diff 23024.
franckarrecot added a comment.
update - should be landable now
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=22998&id=23024
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autote
franckarrecot updated this revision to Diff 23025.
franckarrecot marked an inline comment as done.
franckarrecot added a comment.
update, have to wait to be pushed, since it contains i18n translation, next
week:
in the first two weeks after the first saturday of the month
REPOSITORY
R241
franckarrecot updated this revision to Diff 23023.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=22900&id=23023
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
autotests/kfileplacesmodeltest.
franckarrecot added a comment.
this one is landable now that its dependencies are pushed.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervin, ngraham, mlaurent, #frameworks
franckarrecot marked an inline comment as done.
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:863-866
> Cool, I'll wait for that extra review to appear before accepting that one. So
> that we don't forget it. :-)
Was that the thing you had in mind ?
franckarrecot added a dependent revision: D9015: Refactoring the
hidding/showing animation use within KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #framework
franckarrecot created this revision.
franckarrecot added reviewers: ervin, renatoo, mlaurent, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Depends on https://phabricator.kde.org/D8367
Depends on https://pha
franckarrecot added a dependent revision: D9015: Refactoring the
hidding/showing animation use within KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
franckarrecot updated this revision to Diff 22999.
franckarrecot added a comment.
now related to the refactoring commit coming after
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=22902&id=22999
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFE
franckarrecot updated this revision to Diff 22998.
franckarrecot added a comment.
fix variable name
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=22901&id=22998
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotests/kfileplace
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8945
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: ngraham, kossebau, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8946
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8450: User can now hide an entire
places group from KFilePlacesView.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot edited the summary of this revision.
franckarrecot added dependencies: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace', D8947: Expose KFilePlacesModel 'iconName' role,
D8946: Avoid unnecessary 'dataChanged' signal, D8945: Return a valid bookmark
object for any e
franckarrecot added a comment.
I'll ship it as soon as the commits it's built on will be shipped. Sorry I
rebased this one to renato new commit split so we would avoid conflict if
interlaced commit pushed happend.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8947
To: renatoo, dfaure
Cc: ngraham, kossebau, #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8943
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8944
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8946
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot edited the summary of this revision.
franckarrecot added dependencies: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace', D8947: Expose KFilePlacesModel 'iconName' role,
D8946: Avoid unnecessary 'dataChanged' signal, D8945: Return a valid bookmark
object for any e
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8945
To: renatoo, dfaure
Cc: ngraham, #frameworks
franckarrecot added a dependent revision: D8366: Factoring out lists of url
data within KFilePlacesModelTest.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
franckarrecot edited the summary of this revision.
franckarrecot added a dependency: D8948: Created an auxiliary function
'KFilePlacesModel::movePlace'.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: anthonyfieroni, ervi
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesview.cpp:863-866
> I still stand by that comment, I'd welcome a patch on top of that one to
> reduce that duplication please.
Oki I add that to my list :-)
> ervin wrote in kfileplacesview.cpp:298
> That smells st
franckarrecot updated this revision to Diff 22900.
franckarrecot added a comment.
rebased over in review renato 's patches
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=21750&id=22900
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
franckarrecot marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
franckarrecot updated this revision to Diff 22902.
franckarrecot marked an inline comment as done.
franckarrecot added a comment.
rebased over in review renato 's patches
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=22734&id=22902
REVISION DETAIL
h
franckarrecot updated this revision to Diff 22901.
franckarrecot added a comment.
rebased over in review renato 's patches
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=22726&id=22901
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
REVISION DETAIL
https://phabricator.kde.org/D8366
To: franckarrecot, renatoo, ervin, mlaurent
Cc: ervin, ngraham, mlaurent, #frameworks
franckarrecot marked 5 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8367
To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent
Cc: mwolff, ngraham, mlaurent, #frameworks
franckarrecot added inline comments.
INLINE COMMENTS
> ervin wrote in kfileplacesmodel.cpp:870
> Why not naming the variable isGroupHidden and use the :: prefix on the
> function call like milian proposed?
Because it wouldn't compile without the whole KFIlePlacesModel:: prefix, so I
end up goi
franckarrecot updated this revision to Diff 22734.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21644&id=22734
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
autotests/kfileplacesmodeltest.
franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
franckarrecot added inline comments.
INLINE COMMENTS
> mwolff wrote in kfileplacesview.cpp:298
> the reserve + loop should be the same as doing
>
> m_disappearingItems += indexesGroup;
I'm filling a list of persistant indexes with regular indexes that is why I use
the loop, if you have any o
franckarrecot added a comment.
precision on useless comment
INLINE COMMENTS
> franckarrecot wrote in kfileplacesmodel.cpp:257
> it is currently not needed here since each change an object metadata ( eg :
> item isHidden metadata ) would trigger a loadBookmarkList().
> And in this code we ma
franckarrecot updated this revision to Diff 22726.
franckarrecot edited the test plan for this revision.
franckarrecot added a comment.
update
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21755&id=22726
REVISION DETAIL
https://phabricator.kde.org/D
franckarrecot commandeered this revision.
franckarrecot edited reviewers, added: mlaurent; removed: franckarrecot.
franckarrecot added a comment.
taking ownership back to fix comments, thanks Laurent for taking care of it
:-)
INLINE COMMENTS
> renatoo wrote in kfileplacesmodel.cpp:257
> shou
franckarrecot added a comment.
I will add pics soonish
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
franckarrecot updated this revision to Diff 21291.
franckarrecot added a comment.
updated according to comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21244&id=21291
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
src/file
franckarrecot updated this revision to Diff 21290.
franckarrecot added a comment.
updated according to comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21243&id=21290
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECTED FILES
autotest
franckarrecot updated this revision to Diff 21289.
franckarrecot added a comment.
switch removable after regular devices
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8366?vs=20973&id=21289
REVISION DETAIL
https://phabricator.kde.org/D8366
AFFECTED FILES
franckarrecot retitled this revision from "WIP: User can now hide an entire
places group" to "User can now hide an entire places group".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
franckarrecot retitled this revision from "User can now hide an entire places
group" to "User can now hide an entire places group from KFilePlacesView".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks
franckarrecot updated this revision to Diff 21244.
franckarrecot added a comment.
-
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8450?vs=21242&id=21244
REVISION DETAIL
https://phabricator.kde.org/D8450
AFFECTED FILES
src/filewidgets/kfileplacesmodel.cpp
franckarrecot updated this revision to Diff 21243.
franckarrecot added a comment.
adding more services from model usefull to views
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21177&id=21243
REVISION DETAIL
https://phabricator.kde.org/D8367
AFFECT
franckarrecot created this revision.
franckarrecot added reviewers: ngraham, renatoo, mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Through the ui the user can now right click on a place group
and request t
franckarrecot updated this revision to Diff 21177.
franckarrecot added a comment.
Moving enum from item to model to avoid exposing private api
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21167&id=21177
REVISION DETAIL
https://phabricator.kde.org/D
franckarrecot updated this revision to Diff 21167.
franckarrecot edited the summary of this revision.
franckarrecot added a comment.
sync summary
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21166&id=21167
REVISION DETAIL
https://phabricator.kde.or
franckarrecot added a dependent revision: D8367: Hidding place groups
implementation in KFilePlacesModel.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #framewor
franckarrecot retitled this revision from "WIP: Hidding Group from
KFilePlacesModel" to "Hidding place groups implementation in KFilePlacesModel".
franckarrecot edited the summary of this revision.
franckarrecot edited the test plan for this revision.
franckarrecot added a reviewer: ngraham.
franc
franckarrecot updated this revision to Diff 21166.
franckarrecot added a comment.
trying to make the summary changes update in phabricator
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=21165&id=21166
REVISION DETAIL
https://phabricator.kde.org/D8367
franckarrecot updated this revision to Diff 21165.
franckarrecot added a comment.
Changing the way to store group states from bookmark to root
propreties
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8367?vs=20974&id=21165
REVISION DETAIL
https://phabric
franckarrecot created this revision.
franckarrecot added a reviewer: renatoo.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This give an implemenation to the places model to hidde an entire group
of places. The model
franckarrecot created this revision.
franckarrecot added a reviewer: renatoo.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Instead of reusing the same string lists all over the place
we factor them out, easier to re
72 matches
Mail list logo
