franckarrecot added inline comments.

INLINE COMMENTS

> ervin wrote in kfileplacesview.cpp:863-866
> I still stand by that comment, I'd welcome a patch on top of that one to 
> reduce that duplication please.

Oki I add that to my list :-)

> ervin wrote in kfileplacesview.cpp:298
> That smells std::transform instead of the hand crafted loop at least.

good idea

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks

Reply via email to