D18895: AsciiDoc: Add folding for sections

2019-02-11 Thread Andreas Gratzer
andreasgr added a comment. In D18895#409743 , @dhaumann wrote: > ... Although, adding many RegExprs is slow compared to other rules. I understand that. I just don't see how to achieve the needed matches using other rules. E.g. a simple

D18895: AsciiDoc: Add folding for sections

2019-02-10 Thread Andreas Gratzer
andreasgr created this revision. andreasgr added reviewers: Framework: Syntax Highlighting, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. andreasgr requested review of this revision. REVISION SUMMARY As D18516

D18617: AsciiDoc: Fix highlighting of include directive

2019-01-30 Thread Andreas Gratzer
andreasgr added a comment. In D18617#402600 , @dhaumann wrote: > Looks good to me. Please increase the "version" number whenever you change an highlighting file. Ooops, sorry. Many thanks for the quick review. REPOSITORY R216 Syntax

D18617: AsciiDoc: Fix highlighting of include directive

2019-01-30 Thread Andreas Gratzer
andreasgr created this revision. andreasgr added reviewers: Framework: Syntax Highlighting, dhaumann. andreasgr added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. andreasgr requested review of this

D18475: Add AsciiDoc support

2019-01-29 Thread Andreas Gratzer
andreasgr added a comment. In D18475#401517 , @dhaumann wrote: > 1. I apply your patch: arc patch D18475 Thanks for the information. And many thanks for your time spent on reviewing. Cheers REPO

D18475: Add AsciiDoc support

2019-01-28 Thread Andreas Gratzer
andreasgr added a comment. In D18475#400238 , @nibags wrote: > Hi!! > Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`.

D18475: Add AsciiDoc support

2019-01-28 Thread Andreas Gratzer
andreasgr added a comment. In D18475#400989 , @nibags wrote: > If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal).

D18475: Add AsciiDoc support

2019-01-27 Thread Andreas Gratzer
andreasgr updated this revision to Diff 50391. andreasgr added a comment. Fix diff. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50390&id=50391 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED FILES autotests/input/as

D18475: Add AsciiDoc support

2019-01-27 Thread Andreas Gratzer
andreasgr updated this revision to Diff 50390. andreasgr added a comment. - Added test AsciiDoc. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50388&id=50390 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED FILES autot

D18475: Add AsciiDoc support

2019-01-27 Thread Andreas Gratzer
andreasgr updated this revision to Diff 50388. andreasgr added a comment. - Drop unused 'admonition' keyword list. - Rename itemData elements to start with capital letters. - Enable escaping in block and section titles. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE htt

D18475: Add AsciiDoc support

2019-01-27 Thread Andreas Gratzer
andreasgr added a comment. In D18475#400893 , @dhaumann wrote: > Running the katesyntaxhighlighting indexer tells me: > > katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists:

D18475: Add AsciiDoc support

2019-01-27 Thread Andreas Gratzer
andreasgr updated this revision to Diff 50382. andreasgr added a comment. Drop custom colors and backgrounds. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50263&id=50382 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED

D18475: Add AsciiDoc support

2019-01-25 Thread Andreas Gratzer
andreasgr added a comment. In D18475#400238 , @nibags wrote: > Hi!! > Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`.

D18475: Add AsciiDoc support

2019-01-25 Thread Andreas Gratzer
andreasgr updated this revision to Diff 50263. andreasgr removed projects: Frameworks, Kate. andreasgr added a comment. Herald added projects: Kate, Frameworks. - Add missing allowed leading characters for links. - Add escaping of attribute usage. - Avoid highlighting of spaces inside table

D18475: Add AsciiDoc support

2019-01-23 Thread Andreas Gratzer
andreasgr created this revision. andreasgr added a reviewer: Framework: Syntax Highlighting. andreasgr added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. andreasgr requested review of this revision.