andreasgr added a comment.
In D18475#400893 <https://phabricator.kde.org/D18475#400893>, @dhaumann wrote: > Running the katesyntaxhighlighting indexer tells me: > > katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists: "admonition" > > > Could you fix this? Usually, keyword completion should be context dependent anyways (currently a bug), so soon your unused list will indeed not have any effect. OK, I will remove it. I just added it as this supports word completion. > Besides: If you want to support specials like TODO, NOTE, ..., then please use IncludeRules and ##Alert (look into other files how it's done). These 'admonitions' are a different thing. They are a feature of AsciiDoc, have to align to specific formats and are rendered in the output (see https://asciidoctor.org/docs/user-manual/#admonition). Using alerts in comments is already supported the way you described. > Also, could you please change all itemData names to upper case naming? Eg. "replacement" -> "Replacement", or "section title" -> Section Title", etc? All other highlighting files use this naming scheme, and it will be visible in the UI later when configuring the colors in Kate. Sure, no problem. > And what's still missing is a test file, also best licensed under MIT, that we can use for regression testing. Working on it. I understand a single AsciiDoc is expected? I have a set of 22 AsciiDocs I used for testing while creating the highlighting support and another one describing the things I know are currrently not working. At the moment I am merging them into a single one. Thanks for your feedback :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18475 To: andreasgr, #framework_syntax_highlighting Cc: dhaumann, nibags, kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars
