D29354: Bash: fix comments after escapes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bru

D29354: Bash: fix comments after escapes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bru

D29354: Bash: fix comments after escapes

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY BUG: 418876 Comments we

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 02 May 2020 03:59:00 + Build duration: 7 min 24 sec and counting JUnit Tests Name:

Re: Information regarding upcoming Gitlab Migration

On 5/1/20 2:09 PM, Ben Cooksley wrote: Unfortunately sharing of projects/repositories across groups does not impact on tasks and reviews. This means that merge requests for Planet (which is currently shared with "KDE") do not show up in the list of merge requests for "KDE". Sharing repositories

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

filipf edited the test plan for this revision. filipf added reviewers: VDG, Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29352 To: filipf, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

filipf created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. filipf requested review of this revision. REVISION SUMMARY We're the only theme with the appropriate heading svgs that make the headers and footers look as they should. All th

Re: Information regarding upcoming Gitlab Migration

On Sat, May 2, 2020 at 9:04 AM Nate Graham wrote: > > On 5/1/20 2:09 PM, Ben Cooksley wrote: > > Unfortunately sharing of projects/repositories across groups does not > > impact on tasks and reviews. > > This means that merge requests for Planet (which is currently shared > > with "KDE") do not sh

Re: Information regarding upcoming Gitlab Migration

On Sat, May 2, 2020 at 6:17 AM Alexander Potashev wrote: > > On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah wrote: > > Use case 4 : Tom is a student in Germany and is interested in > > contributing to wikitolearn, and he asks where can I find code of the > > wikitolearn? > > Hi, Hi Alexander, > >

Re: Information regarding upcoming Gitlab Migration

On Sat, May 2, 2020 at 2:33 AM Adriaan de Groot wrote: > > On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote: > > On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > > If I'm understanding things, we have solutions to most or all of the > > > objections raised so far: > > > > > > - Project

D29339: Implement updating of notifications on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29342: Implement support for notification urgency on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29342 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

nicolasfella added inline comments. INLINE COMMENTS > vkrause wrote in NotifyByAndroid.java:171 > That seems counter-productive to me, as the Android API documentation always > speaks about API level numbers, so you'd need to do an additional translation > to/from the letters in your head. So f

Re: Information regarding upcoming Gitlab Migration

> On 1 May 2020, at 15:17, Alexander Potashev wrote: > > On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah wrote: >> Use case 4 : Tom is a student in Germany and is interested in >> contributing to wikitolearn, and he asks where can I find code of the >> wikitolearn? > > Hi, > > I have a similar

D29347: KAuthorized: export method to reload restrictions

dfaure created this revision. dfaure added reviewers: aacid, apol, mdawson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This is useful for unittests. Example: KCONFIGCORE_EXPORT void reloadUr

Re: Information regarding upcoming Gitlab Migration

On Tue, Apr 28, 2020 at 6:47 AM Bhushan Shah wrote: > Use case 4 : Tom is a student in Germany and is interested in > contributing to wikitolearn, and he asks where can I find code of the > wikitolearn? Hi, I have a similar use case. Sometimes I need to share a URL to a project. For this purpose

Re: Information regarding upcoming Gitlab Migration: clarifications

On 5/1/20 9:02 AM, Johan Ouwerkerk wrote: No, that is not the default. Actually, it is: https://invent.kde.org/kde/kdesrc-build/-/blob/master/kdesrc-build-setup#L389 and download all repos into ~/kde/src without any of the levels of hierarchy. But it is sufficiently common that there is

Re: Information regarding upcoming Gitlab Migration: clarifications

Ben Cooksley ha scritto: > On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: >> >> >> >> On 4/30/20 5:59 PM, Aleix Pol wrote: >>> El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid Am I the only person that just has all the repos on the same folder? I thought it was the common

D29254: [RenameDialog] Add an arrow indicating direction from src to dest

meven accepted this revision. REPOSITORY R241 KIO BRANCH l-srt-to-dest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29254 To: ahmadsamir, #frameworks, dfaure, meven, ngraham, #dolphin Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29175: DBus Runner: Add service property to request actions once

meven added inline comments. INLINE COMMENTS > dbusrunnertest.cpp:204 > +// We haven't called the prepare slot, if the implementation works > +// the actions should alredy be available > +auto actions = m.actionsForMatch(fakeMatch); typo: already > dbusrunnertest.cpp:206 > +auto

D29342: Implement support for notification urgency on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY While the notification levels map nicely, the behavior on Android with API level 26 or higher is slightly different fr

D28498: [xdgoutput] Explicitly set version of server interface

davidedmundson abandoned this revision. davidedmundson added a comment. All these problems go away with KWaylandServer \o/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28498 To: davidedmundson, #kwin Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel, LeGast00n

D29175: DBus Runner: Add service property to request actions once

This revision was automatically updated to reflect the committed changes. Closed by commit R308:7b6222d8a10b: DBus Runner: Add service property to request actions once (authored by alex). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29175?vs=81623&id=81687

D29175: DBus Runner: Add service property to request actions once

ngraham accepted this revision. REPOSITORY R308 KRunner BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29339: Implement updating of notifications on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 AFFECTED FILES src/notifybyandro

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 6:38 AM Nate Graham wrote: > > On 4/30/20 5:59 PM, Aleix Pol wrote: > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > >> Am I the only person that just has all the repos on the same folder? I > >> thought it was the common thing to do :? > > > > I do too >

D29335: Implement notification grouping on Android

vkrause added inline comments. INLINE COMMENTS > nicolasfella wrote in NotifyByAndroid.java:171 > Please use > https://developer.android.com/reference/android/os/Build.VERSION_CODES > instead of hardcoding numbers That seems counter-productive to me, as the Android API documentation always sp

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 7:18 AM Ben Cooksley wrote: > > On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: > > > > > > > > On 4/30/20 5:59 PM, Aleix Pol wrote: > > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > > >> Am I the only person that just has all the repos on the same fold

Re: Information regarding upcoming Gitlab Migration

On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote: > On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > If I'm understanding things, we have solutions to most or all of the > > objections raised so far: > > > > - Projects will be allowed to live in--or at least appear in--multiple > > top

D29335: Implement notification grouping on Android

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Haven't tested it, but the code looks sensible INLINE COMMENTS > NotifyByAndroid.java:171 > +Notification.Builder builder; > +if (Build.VERSION.SDK_INT >= 26) {

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella added a dependent revision: D29336: Remove galago from method/variable naming. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, mi

D29336: Remove galago from method/variable naming

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY With D29021 the fallba

D29335: Implement notification grouping on Android

vkrause added a comment. Collapsed: F8276057: Screenshot_20200501_161952.PNG Expanded: F8276059: Screenshot_20200501_162043.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D293

D29335: Implement notification grouping on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is available starting at API level 20, which is below our minimal requirement. Grouping can be disabled by the al

Re: Information regarding upcoming Gitlab Migration: clarifications

On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different projects > > > > that do

Re: Information regarding upcoming Gitlab Migration

Thanks for the clarifications, Ben. Then I think the original proposal is perfectly reasonable and I fully support it. Nate

Re: Information regarding upcoming Gitlab Migration: clarifications

On 4/30/20 11:17 PM, Ben Cooksley wrote: Not necessarily. Git allows you to override the name that the local folder is called when cloning, so there is no reason why we can't specify something in the metadata to override the local name that the folder gets called in your local checkout folder.

D29198: filenamesearch:/ define a title for the query

iasensio accepted this revision. iasensio added a comment. Sorry I missed the ping. Along with D29197 , it looks nice to me. INLINE COMMENTS > dolphinsearchbox.cpp:479 > +return i18nc("@title UDS_DISPLAY_NAME for a KIO directory listing. %1 is > the

D29323: Handle multi-line and rich-text notifications on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

vkrause added a comment. F8275264: Screenshot_20200501_124105.PNG REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29323: Handle multi-line and rich-text notifications on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY By default only a single line of the notification message is shown, for making longer messages readable we need to use

D29136: Use non-deprecated KDEInstallDir

heikobecker reclaimed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Information regarding upcoming Gitlab Migration: clarifications

On 4/30/20 5:59 PM, Aleix Pol wrote: El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid Am I the only person that just has all the repos on the same folder? I thought it was the common thing to do :? I do too Same here. kdesrc-build's default settings do this, and download all

D29175: DBus Runner: Add service property to request actions once

alex added a dependent revision: D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service. REPOSITORY R308 KRunner BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-f