iasensio accepted this revision. iasensio added a comment.
Sorry I missed the ping. Along with D29197 <https://phabricator.kde.org/D29197>, it looks nice to me. INLINE COMMENTS > dolphinsearchbox.cpp:479 > + return i18nc("@title UDS_DISPLAY_NAME for a KIO directory listing. %1 is > the query the user entered.", > + "Query Results from '%1'", text); > +} Please, align the two strings > elvisangelaccio wrote in dolphinsearchbox.h:164 > Please drop the `get` prefix. I'd move this line up to separate private methods from private member variables REPOSITORY R318 Dolphin BRANCH arcpatch-D29198_1 REVISION DETAIL https://phabricator.kde.org/D29198 To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio Cc: iasensio, kfm-devel, azyx, nikolaik, pberestov, aprcela, fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov
