D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

junghans created this revision. junghans added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. junghans requested review of this revision. REVISION SUMMARY QT_NO_KEYWORDS will be default in Qt 6 so all occurrences of `emit` should be re

D28995: Add imperial gallon and US pint

riiga added a comment. The units added in 5.53 were pint (imperial) and gallon (US). The units in the bug report and added by me now are pint (US) and gallon (imperial). REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28995 To: riiga, #frameworks, ngraham Cc

D27220: add pix icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH pix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27220 To: mbruchert, camiloh, #vdg, ndavis Cc: ngraham, IlyaBizyaev, kde-frameworks-devel, LeGast00n,

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80607. xuetianweng added a comment. Fix the blank text issue by alway setLineWidth. For QTextLine, the layout information is not filled until certain function is called. If dynamic wrap is not enabled, the line width is -1 so at the point we do

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 20 Apr 2020 00:50:05 + Build duration: 42 sec and counting JUnit Tests Name: projectroot Fail

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80606. xuetianweng added a comment. Clean up the code a little bit and adding comments. Also fix a small bug if m_fontHeight has big difference with m_fontMetrics's height. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricat

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 62 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/62/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 20 Apr 2020 00:38:15 + Build duration: 5 min 26 sec and counting BUILD ARTIFACTS acc/KF5KIO-5.70.0.

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80605. apol added a comment. oops REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80604&id=80605 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28882 AFFECTED FILES autotests/server/CMakeLists

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80604. apol added a comment. Include server side, a test (that doesn't pass) and some renaming REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80411&id=80604 BRANCH master REVISION DETAIL https://phabricator

D28980: Revert "add Baloo DBus signals for moved or removed files"

bruns added a comment. In D28980#652102 , @mgallien wrote: > To be clear, I am fine with this change going in. > > I would still like to work on a proper solution to allow an application to monitor moved files or similar stuff without having

D28980: Revert "add Baloo DBus signals for moved or removed files"

bruns added a comment. In D28980#652087 , @mgallien wrote: > The unusual method to get notified is about avoiding signaling moved files if nobody is watching. Baloo will only callback if applications have registered themselves. Registeri

D28995: Add imperial gallon and US pint

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks very much for the patch, but that bug report is very old and these units of measurement were already added in 5.53 as `GallonUS` and `PintImperial`. I'm sorry the the bug

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley: > Hi all, > > Another breakage in Qt? Should be fixed now (restarted build now completed), with similar traps also removed for the future, thanks to David Faure for the work done and Ade for the root detecting investigations. Seem

D28980: Revert "add Baloo DBus signals for moved or removed files"

ngraham accepted this revision. REPOSITORY R293 Baloo BRANCH config_rework REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich,

D28995: Add imperial gallon and US pint

riiga created this revision. riiga added a reviewer: Frameworks. riiga added a project: Frameworks. riiga requested review of this revision. REVISION SUMMARY Adds imperial gallon and US pint as requested in a bug report. BUG: 341072 TEST PLAN I haven't figured out how to test the changes

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. To be clear, I am fine with this change going in. I would still like to work on a proper solution to allow an application to monitor moved files or similar stuff without having to a

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. The unusual method to get notified is about avoiding signaling moved files if nobody is watching. Baloo will only callback if applications have registered themselves. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo, m

D28980: Revert "add Baloo DBus signals for moved or removed files"

mgallien added a comment. Sorry for the lack of time to do a proper review. I will need to have a thorough look at what Elisa is currently doing and what is working (or not). Is there another working way to get information about files that have moved without having an application mo

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

Hi all, Another breakage in Qt? Cheers, Ben -- Forwarded message - From: CI System Date: Sun, Apr 19, 2020 at 11:44 PM Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing! To: *BUILD FAILURE* Build URL https://bui

D27597: KRunner: Refactor deprecated toSet() method

alex abandoned this revision. alex added a comment. This gets already handled/discussed in D28135 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D27597 To: alex, mlaurent, apol, #plasma Cc: ahmadsamir, kde-frameworks-devel, LeGas

D28980: Revert "add Baloo DBus signals for moved or removed files"

astippich removed a reviewer: astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28980 To: bruns, #baloo, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngrah

T11627: Improve KIO asynchronicity

meven added a comment. While copying from local to a nfs mount with the destination opened, you get a dolphin freeze because KCoreDirlister is run in main thread and because of #0 statx (fd=-100, path=0x5564ae9e5148 "/media/NFS/Myfile", flags=0, mask=4095, buf=0x7ffc8ba20420)

D25515: Only extract lyrics when the plain text flag is set

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s

D25518: Extract front cover in the taglib extractor

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25518 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s

D25679: Implement writing of front cover in taglibwriter

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25679 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, s

D25517: Add an option to extract image data and add front cover property

astippich abandoned this revision. astippich added a comment. Okay, since there seems to be no interest at all as even a short reply is not given, I am done here REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngra

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 19 Apr 2020 18:33:34 + Build duration: 6 min 29 sec and counting JUnit Tests Name: pro

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/7/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 19 Apr 2020 18:33:34 + Build duration: 5 min 49 sec and counting BUILD ARTIFACTS abi-compati

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#651701 , @cullmann wrote: > Hmm, after applying this patch, for me, no text is visible at all. > By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). >

D28955: [FileContentIndexer] Fix state update and signal order

This revision was automatically updated to reflect the committed changes. Closed by commit R293:af260fbdd2e5: [FileContentIndexer] Fix state update and signal order (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28955?vs=80488&id=80574 REVI

D28954: [Monitor] Fix monitor state and signal ordering

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3157e9375cc4: [Monitor] Fix monitor state and signal ordering (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28954?vs=80487&id=80573 REVISION DE

D28953: [Extractor] Fix progress reporting

This revision was automatically updated to reflect the committed changes. Closed by commit R293:273b7a1d7a63: [Extractor] Fix progress reporting (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28953?vs=80486&id=80572 REVISION DETAIL https:

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#651701 , @cullmann wrote: > Hmm, after applying this patch, for me, no text is visible at all. > By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). >

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 19 Apr 2020 17:38:38 + Build duration: 1 min 36 sec and counting JUnit Tests Name: pr

D28986: API dox: document Q_DECLARE_FLAGS-based flags

This revision was automatically updated to reflect the committed changes. Closed by commit R244:3d30318e4d37: API dox: document Q_DECLARE_FLAGS-based flags (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28986?vs=80569&id=80571 REVI

D28986: API dox: document Q_DECLARE_FLAGS-based flags

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH documentFlags REVISION DETAIL https://phabricator.kde.org/D28986 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

dfaure added a comment. Sure. REPOSITORY R244 KCoreAddons BRANCH documentFlags REVISION DETAIL https://phabricator.kde.org/D28986 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28986: API dox: document Q_DECLARE_FLAGS-based flags

kossebau added a comment. If okay, I would walk over the other KF modules and apply the same pattern there as well, once this here is accepted. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D28986 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGa

D28986: API dox: document Q_DECLARE_FLAGS-based flags

kossebau updated this revision to Diff 80569. kossebau added a comment. drop the "OR" from "OR combination" REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28986?vs=80562&id=80569 BRANCH documentFlags REVISION DETAIL https://phabricator.kde.org/D28

D28986: API dox: document Q_DECLARE_FLAGS-based flags

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kjob.h:99 > Inexperienced developers might be confused by the OR in there. > In English it sounds like exclusive or, while the whole point of > Q_DECLARE_FLAGS is that multiple flags can be set at the same time. > > Why not just

D28986: API dox: document Q_DECLARE_FLAGS-based flags

dfaure added inline comments. INLINE COMMENTS > kjob.h:99 > +/** > + * Stores an OR combination of #Capability values. > + */ Inexperienced developers might be confused by the OR in there. In English it sounds like exclusive or, while the whole point of Q_DECLARE_FLAGS is that multi

D28986: API dox: document Q_DECLARE_FLAGS-based flags

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY KApiDox & ECMAddQch have been just teached about Q_DECLARE_FLAGS, so the

D6794: assert the testpackage appstream data validates

sitter added a comment. @bcooksley I would think the CI image needs to ship some general purpose schemas. install https://software.opensuse.org/package/gsettings-desktop-schemas I guess. If it's still not working right with that installed I can take a look at what's missing. The warning

D28956: [QML Monitor] Show remaining time as soon as possible

bruns added a comment. In D28956#651795 , @apol wrote: > You're using QDeadlineTimer weird. Why don't you use QDeadlineTimer::remainingTime() and ::setDeadline? Because both functions do a syscall. REPOSITORY R293 Baloo REVISION DETAI

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

ahmadsamir added a reviewer: broulik. ahmadsamir added a comment. I had trouble finding what urlPatterns would look like, and only found trash:/ and run:/, also couldn't find any documentation about X-Plasma-DropUrlPatterns. Porting regex, especially with the pesky QRegExp::Wildcard, see

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

apol added a comment. I wonder, while this will work with all our uses of DropUrlPatterns, this would have been able to work with something like `scheme:/*potato*` which after this patch won't work. In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate feedback from s

D28956: [QML Monitor] Show remaining time as soon as possible

apol added a comment. You're using QDeadlineTimer weird. Why don't you use QDeadlineTimer::remainingTime() and ::setDeadline? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28956 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast

D28955: [FileContentIndexer] Fix state update and signal order

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28955 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28953: [Extractor] Fix progress reporting

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28953 To: bruns, #baloo, ngraham, mlaurent, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas

D28954: [Monitor] Fix monitor state and signal ordering

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28954 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28769: Add Icelandic Krona

This revision was automatically updated to reflect the committed changes. Closed by commit R292:1a7d46d3f753: Add Icelandic Krona to currencies (authored by sandsmark). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28769?vs=7&id=80541 REVISION DE

D28980: Revert "add Baloo DBus signals for moved or removed files"

bruns created this revision. bruns added reviewers: Baloo, mgallien, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Revert "add missing license" This reverts commit 96fb589

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.14 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.14/11/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 19 Apr 2020 13:29:14 + Build duration: 2 min 53 sec and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 19 Apr 2020 13:29:14 + Build duration: 1 min 52 sec and counting JUnit Tests Name: pr

D28979: Mark ancient KLibFactory typedef as deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R244:7d3e832c13ef: Mark ancient KLibFactory typedef as deprecated (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28979?vs=80538&id=80539 REV

D28979: Mark ancient KLibFactory typedef as deprecated

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH tagKLibFactorydeprecated REVISION DETAIL https://phabricator.kde.org/D28979 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D28979: Mark ancient KLibFactory typedef as deprecated

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH tagKLibFactorydeprecated REVISION DETAIL https:/

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. Hmm, after applying this patch, for me, no text is visible at all. By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). F8246692: kwrite_no_text.png REPOSITORY R39 KTextEd

D28973: Fix cache directory calculation when adding to trash

dfaure added a comment. Thanks. >0 is already something :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28973 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY AFAICS, from grep'ing for "DropUrlPatterns" in /usr/share/{kservices5,p

D28973: Fix cache directory calculation when adding to trash

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ff831cb609ea: Fix cache directory calculation when adding to trash (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28973?vs=80534&id=80535 REVISION

D28973: Fix cache directory calculation when adding to trash

meven updated this revision to Diff 80534. meven added a comment. Add test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28973?vs=80520&id=80534 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28973 AFFECTED FILES src/ioslaves/trash/tests/t

D28952: [KNewStuff] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R304:6b5ec74ff4ca: [KNewStuff] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28952?vs=80483&id=80532 REV

D28967: [KRichTextEditor] Add support for headings

This revision was automatically updated to reflect the committed changes. Closed by commit R263:2f86040cab5b: [KRichTextEditor] Add support for headings (authored by poboiko). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28967?vs=80524&id=80530 REVISION DET

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

This revision was automatically updated to reflect the committed changes. Closed by commit R236:b52622993b45: [KFontChooser] Make styleIdentifier() more precise by adding font styleName (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

ahmadsamir added a comment. This particular one is the same bug, we've been fixing it for a couple of months now; in KConfig, in the Fonts KCM/KFontChooser*, we even had to bring KFontDialog back from the deprecation pile in KDELibs4Support (for this and for decimal font sizes which QFontDia

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

ahmadsamir added a comment. In D28880#651415 , @dfaure wrote: > In D28880#651209 , @ahmadsamir wrote: > > > There are only two places in KDE code where readEntryList() is used, falkon and kwalletman

D28967: [KRichTextEditor] Add support for headings

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28967 To: poboiko, #frameworks, mlaurent Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack, mich

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

This revision was automatically updated to reflect the committed changes. Closed by commit R310:7d3a1386bee2: [KRichTextEdit] Make sure headings don't mess with undo stack (authored by poboiko). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28968?vs=8050

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Oh I see. Thanks, I didn't know that method. REPOSITORY R310 KTextWidgets BRANCH heading-undo-stack (branched from master) REVISION DETAIL https://phabricator.kde.org/D28968 To: pob

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

poboiko added inline comments. INLINE COMMENTS > dfaure wrote in krichtextedit.cpp:572 > Where is the corresponding beginEditBlock()? `joinPreviousEditBlock` in a way acts as `beginEditBlock` (see https://doc.qt.io/qt-5/qtextcursor.html#joinPreviousEditBlock). The intent here was following: if

D28745: Skip caching thumbnails on encrypted filesystems

marcingu marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGa

D28745: Skip caching thumbnails on encrypted filesystems

marcingu updated this revision to Diff 80526. marcingu added a comment. Review fixes REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28745?vs=80458&id=80526 REVISION DETAIL https://phabricator.kde.org/D28745 AFFECTED FILES thumbnail/thumbnail.cpp

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. You're like a bugfixing machine, very impressive :-) REPOSITORY R236 KWidgetsAddons BRANCH l-tightenStyleId (branched from master) REVISION DETAIL https://phabricator.kde.org/D28974

D28966: [KRichTextEdit] Fix scroll jumping around when horizontal rule is added

This revision was automatically updated to reflect the committed changes. Closed by commit R310:0e14353610fa: [KRichTextEdit] Fix scroll jumping around when horizontal rule is added (authored by poboiko). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D289

D28968: [KRichTextEdit] Make sure headings don't mess with undo stack

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtextedit.cpp:572 > setHeadingLevel(0); > -} > - > -// If a line was merged with previous one, with different heading level, > -// the

D28966: [KRichTextEdit] Fix scroll jumping around when horizontal rule is added

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Nice work. REPOSITORY R310 KTextWidgets BRANCH dont-scroll-rule (branched from master) REVISION DETAIL https://phabricator.kde.org/D28966 To: poboiko, #frameworks, dfaure Cc: kde-fr

D28967: [KRichTextEditor] Add support for headings

poboiko updated this revision to Diff 80524. poboiko added a comment. Update version REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28967?vs=80507&id=80524 BRANCH heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28967 AFFEC

D28967: [KRichTextEditor] Add support for headings

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtexteditorui.rc:2 > > > increase version. => 14 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D28967 To: poboiko,

D28952: [KNewStuff] Port QRegExp to QRegularExpression

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH l-QRE (branched from master) REVISION DETAIL https://phabricator.kde.org/D28952 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28973: Fix cache directory calculation when adding to trash

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Good catch. I wonder if the unittest could be extended so it would have caught this. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28973 To: meven,

D28909: smb: port to Result system to force serialization of error/finish condition

dfaure added inline comments. INLINE COMMENTS > meven wrote in kio_smb.h:96 > KF6 ? > Or once we want to use it in KIO ? Whenever we port a 3rd slave to it ;-) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28909 To: sitter, dfaure Cc: meven, kde-frameworks-devel,

D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY styleIdentifier() tries to get the correct font style based on weight, style, and stretch; this "st

D28973: Fix cache directory calculation when adding to trash

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The directory size was not added to the directory cache size since D24773