ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Thanks very much for the patch, but that bug report is very old and these units of measurement were already added in 5.53 as `GallonUS` and `PintImperial`. I'm sorry the the bug report wasn't correctly closed after those units were added (I have just done so). You did a great job here though. Would you care to work on a different unit conversion bug report? Here are a few: https://bugs.kde.org/buglist.cgi?component=general&list_id=1736763&product=frameworks-kunitconversion&resolution=--- REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28995 To: riiga, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
