D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kshorturifilter.cpp:437 > +// URLs using Qt's QRegularExpression class. This is hard-coded for > now. > // TODO: Make configurable at some point... >

D26071: Avoid unwanted horizontal scrolling

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable, thanks for taking care + happy x-mas ;=) REPOSITORY R39 KTextEditor BRANCH avoid-unwanted-horizontal-scrolling (branched from master) REVISION DETAIL https://ph

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. Kossebau va escriure: > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause: > > On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > > > Hi all, > > > > > > in any case, maybe the discussed points s

D26099: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26099 To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich

D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26236 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir added a task: T12279: Port frameworks away from QRegExp. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/83/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 26 Dec 2019 17:21:47 + Build duration: 2 min 9 sec and counting JUnit Tests Name: pro

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 135 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/135/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 26 Dec 2019 17:21:47 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...truncat

D26226: [KListOpenFilesJob] Use QString::splitRef()

This revision was automatically updated to reflect the committed changes. Closed by commit R244:4bcf55e06c2f: [KListOpenFilesJob] Use QString::splitRef() (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26226?vs=72207&id=72216 REVI

D26226: [KListOpenFilesJob] Use QString::splitRef()

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH l-splitref (branched from master) REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_

D26236: Port QRegExp to QRegularExpression (and some QStringRef optimisation)

ahmadsamir updated this revision to Diff 72213. ahmadsamir retitled this revision from "Port QRegExp to QRegularExpression (and some QStringRef) optimisation" to "Port QRegExp to QRegularExpression (and some QStringRef optimisation)". ahmadsamir added a comment. Fix commit message typo REPOS

D25877: [KColorschemeManager] Add option to reenable following global theme

ngraham added inline comments. INLINE COMMENTS > asemke wrote in kcolorschememanager.cpp:107 > Yes, was also wrong in LabPlot. Just corrected > https://invent.kde.org/kde/labplot/commit/262f37b59193ed88bf680b155dc6ecd37bd11419. > > We should have maybe in this class only one public function KAc

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

ahmadsamir added inline comments. INLINE COMMENTS > kurlcompletion.cpp:503 > // no protocol. (QUrl does this only for absolute paths) > -if (protocol_regex.indexIn(url_copy) == 0) { > +if (protocol_regex.match(url_copy).hasMatch()) { > m_kurl = QUrl(url_copy); hasMatch() i

D26236: Port QRegExp to QRegularExpression (and some QStringRef) optimisation

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY First pass. TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH l-qregularexpression (branched from m

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir updated this revision to Diff 72207. ahmadsamir added a comment. Make it const... :/ REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26226?vs=72206&id=72207 BRANCH l-splitref (branched from master) REVISION DETAIL https://phabricator.kde

D26133: Enable Auto Save

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > apol wrote in test_signal.h.ref:137 > How about having `isSaveNeededChanged(bool)`? It could be in > KCoreConfigSkeleton. Damn, and I was wondering which bette

D26226: [KListOpenFilesJob] Use QString::splitRef()

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > klistopenfilesjob_unix.cpp:69 > const QString out(QString::fromLocal8Bit(lsofProcess.readAll())); > -QStringList pidList = > out.split(QRegul

D26177: Port QRegExp to QRegularExpression

ervin accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26177 To: ahmadsamir, #frameworks, dfaure, ervin, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir added a comment. One more thing, since this is `lsof -t` it's only 52 entries on my system (not +10 of `lsof`), so it's not as big of an optimisation as I first thought (see D26226 for context). REPOSITORY R244 KCoreAddons REVISION DETAI

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir updated this revision to Diff 72206. ahmadsamir added a comment. Remove the call to std::unique: - It doesn't work like that - it's not needed as `lsof -t` already produces a sorted and unique list of pid's REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://p

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir planned changes to this revision. ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfilesjob_unix.cpp:71 > This does not work the way you think it does. > > "A call to std::unique is typically followed by a call t

D26071: Avoid unwanted horizontal scrolling

sars added reviewers: Kate, dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26071 To: sars, #kate, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

This revision was automatically updated to reflect the committed changes. Closed by commit R276:6634451a6279: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But… (authored by mlaurent). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D261

D25877: [KColorschemeManager] Add option to reenable following global theme

asemke added inline comments. INLINE COMMENTS > ngraham wrote in kcolorschememanager.cpp:107 > "Default" is probably fine. > > FWIW the parent menu item is actually mis-named, at least in Kate. It's > called "Color Theme" when it should be "Color Scheme" > > Also this menu should be universal,

D26197: Display fully qualified class/namespace name as page header

ochurlaud added a comment. One minor correction then you can ship it INLINE COMMENTS > generator.py:456 > +else: > +mapping['classname'] = mapping['fullname'] = None > Prefer the use of 2 settings to None instead of this double one. It's more explicit for peopl

D26044: Set breeze as default theme when reading from configuration file

This revision was automatically updated to reflect the committed changes. Closed by commit R302:ed86f4f37c6b: Set breeze as default theme when reading from configuration file (authored by bport). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26044?vs=7195

D26227: Port to QRandomGenerator

mlaurent added a reviewer: dfaure. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26227 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26227: Port to QRandomGenerator

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator TEST PLAN autotest ok REPOSITORY R283 KAuth BRANCH port_to_QRandomGenerator (branche

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R276 KItemViews BRANCH port_qhash_deprecated (branched from master) REVISION DETAIL https://phabricator.kde.org/D26184 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngrah

D26226: [KListOpenFilesJob] Use QString::splitRef()

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > klistopenfilesjob_unix.cpp:71 > +// remove duplicates > +std::unique(pidList.begin(), pidList.end()); > for (const auto& pidStr : qAsC

D26184: QHash::unite is deprecated in qt5.15. We need to port to QMultiHash.But QMultiHash::unite was added in qt5.13

mlaurent added a comment. ping ?:) REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D26184 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

ahmadsamir requested review of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns