D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:236 > +auto device = it.key(); > +QString deviceName = device; > +if (deviceName.endsWith(QLatin1Char('/'))) { You sho

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

elvisangelaccio accepted this revision. elvisangelaccio added a comment. Everything looks good and the new test passes for me. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23898 To: dfaure, elvisangelaccio Cc: kde-frameworks-devel, LeGast00n, GB_2, mi

D23919: Make KSslError hold a QSslError internally

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23919 To: vkrause, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 80 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/80/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 22:15:17 + Build duration: 17 min and counting BUILD ARTIFACTS acc/KF5KIO-5.62.0.xmllogs

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/18/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 22:15:15 + Build duration: 8 min 56 sec and counting BUILD ARTIFACTS acc/KF5Parts-5.6

D23919: Make KSslError hold a QSslError internally

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23919 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23919: Make KSslError hold a QSslError internally

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This implies a bit back and forth conversion for now, but it enables migrating the c

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.13 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.13/17/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 22:15:15 + Build duration: 5 min 11 sec and counting BUILD ARTIFACTS abi-compatibili

D23904: Add QIcon setters for the password dialogs

vkrause updated this revision to Diff 65948. vkrause added a comment. Add icon() getter, deprecated pixmap methods, remove on demand pixmap label creation as we set an icon unconditionally. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23904?vs=659

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Let's get this in soon. We have plenty of time before Frameworks 5.63. REPOSITORY R245 Solid BRANCH arcpatch-D21204 REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, b

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

ngraham edited the summary of this revision. REPOSITORY R245 Solid BRANCH arcpatch-D21204 REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks, ngraham Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23917: Use const_iterator

zzag added a comment. In D23917#530297 , @broulik wrote: > If the container is `const` already there's no real reason to explicitly use `constBegin` which is effectively the same Yes, however it's still a good idea to be explicit about it

D23917: Use const_iterator

broulik added a comment. If the container is `const` already there's no real reason to explicitly use `constBegin` which is effectively the same REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23917 To: gladhorn, #kwin Cc: broulik, zzag, kde-frameworks-devel, LeGas

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Sep 2019 20:06:22 + Build duration: 7 min 38 sec and counting JUnit Tests Name: proje

D23917: Use const_iterator

zzag added inline comments. INLINE COMMENTS > registry.cpp:879 > }); > if (it == m_interfaces.end()) { > qCDebug(KWAYLAND_CLIENT) << "Don't have interface " << > int(interface) << "with name " << name << "and minimum version" << version; constEnd REPOSITORY R127 KWayland

D23917: Use const_iterator

zzag added inline comments. INLINE COMMENTS > output_interface.cpp:119 > +auto rit = std::find_if(resources.constBegin(), > resources.constEnd(), [native] (const ResourceData &data) { return > data.resource == native; }); > if (rit != resources.end()) { > return (*

D23917: Use const_iterator

gladhorn updated this revision to Diff 65946. gladhorn added a comment. fixup REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23917?vs=65945&id=65946 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23917 AFFECTED FILES src/client/plasmaw

D23917: Use const_iterator

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When trivial, replace iterators with the const versrion. REPOSITORY R127 KWayland

D23916: Remove capture of this in lambda

This revision was automatically updated to reflect the committed changes. Closed by commit R127:858d9255f722: Remove capture of this in lambda (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65943&id=65944 REVISION DETAIL ht

D23916: Remove capture of this in lambda

gladhorn updated this revision to Diff 65943. gladhorn added a comment. Remove more lambda this captures REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23916?vs=65942&id=65943 BRANCH arcpatch-D23916 REVISION DETAIL https://phabricator.kde.org/D23916

D23916: Remove capture of this in lambda

broulik accepted this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23916 To: gladhorn, #kwin, zzag, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23916 To: gladhorn, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When this is not used, there is no point in capturing it. REPOSITORY R127 KWayland

D23915: Add some docstrings

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY When first reading the KWayland code, some explanations help getting around. REPOS

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > Still unsure what you mean with the constness, as the QHash `shortcuts` has > been const all the time, and thus the access methods and its returned > references. If you meant the initially propos

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

hallas marked 2 inline comments as done. hallas added inline comments. INLINE COMMENTS > dfaure wrote in klistopenfilesjobtest_unix.cpp:67 > Please use QSKIP instead, otherwise the test output looks like the test > passed, rather than was skipped. Good point, I didn't know that :) REPOSITORY

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

hallas updated this revision to Diff 65937. hallas added a comment. Use QSKIP to skip tests REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23884?vs=65870&id=65937 BRANCH fix_unittest_if_lsof_is_not_installed REVISION DETAIL https://phabricator.kde

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in kkeysequencewidget.cpp:127 > I admit "making them const as needed" is badly phrased; I meant whether the > container iterated-over is const to begin with, or can be made const in the > range-for to avoid a detach/deep-copy ..

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > Is it? > This patch as is now has 3 changes: > > - change a foreach loop over extracted key list of a QHash to then also > access values (2 discouraged things) to iterator-based for loop over the

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65931. meven marked 2 inline comments as done. meven added a comment. Clean up and update @since REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65374&id=65931 BRANCH arcpatch-D23523 REVISION DETAIL https://phab

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/81/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Sep 2019 14:24:55 + Build duration: 14 min and counting JUnit Tests Name: projectr

D23904: Add QIcon setters for the password dialogs

cfeck added a comment. A getter would be nice. I am also fine with deprecating the pixmap calls. You can create an icon from a pixmap using QIcon. (Why is there no setIcon() in QLabel?) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23904 To: vkrause, d

D23903: Remove dead icon loading code

This revision was automatically updated to reflect the committed changes. Closed by commit R304:6e5a8901cb03: Remove dead icon loading code (authored by vkrause). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23903?vs=65911&id=65921 REVISION DETAIL https

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in kkeysequencewidget.cpp:127 > I understand. but I was talking about this case specifically, it's about > foreach two arguments, and making them const as needed, so that seqAsString > change is in inline with replacing foreach

D23899: Port from KIconLoader to QIcon::fromTheme

vkrause updated this revision to Diff 65920. vkrause added a comment. Make use of D23904 . REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23899?vs=65906&id=65920 BRANCH master REVISION DETAIL https://phabricator.kde

D23904: Add QIcon setters for the password dialogs

vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23904 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23903: Remove dead icon loading code

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. The code is referred to in src/ui/itemsviewdelegate.cpp:322 in a commented-out section, which will likely want to be reimplemented in some other way. However, the code is entirely unused, a

D23904: Add QIcon setters for the password dialogs

vkrause added a comment. Should we deprecate the pixmap methods in favor of the icon ones? Do we need an QIcon getter too? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23904 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23904: Add QIcon setters for the password dialogs

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This avoids having to pass in QPixmaps with a fixed size. REPOSITORY R236 KWidgetsA

D23903: Remove dead icon loading code

vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D23903 To: vkrause, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

vkrause added a comment. Yep, makes sense. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D23899 To: vkrause, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > As someone who looked at a lot of commit history, my recommendation is: don't > do in the same commit. Make it a separate commit with a dedicated commit > message. > While-at-it changes are annoyi

D23903: Remove dead icon loading code

vkrause created this revision. vkrause added reviewers: dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.or

D23902: [KCoreDirLister] replace foreach with range-for

ahmadsamir created this revision. ahmadsamir added reviewers: kde-frameworks-devel, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Also change directoriesForCanonicalPath() to return const TEST PLAN The code compiles and all tests pa

D23899: Port from KIconLoader to QIcon::fromTheme

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwalletd.cpp:636 > kpd->setWindowTitle(i18n("KDE Wallet Service")); > -kpd->setPixmap( > - > K

D23899: Port from KIconLoader to QIcon::fromTheme

vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D23899 To: vkrause, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

vkrause created this revision. vkrause added reviewers: davidedmundson, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.cpp:38 > > +#include > #include what is this used for? > meven wrote in slavebase.cpp:281 > That's on purpose, the first use of mapConfig is i

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

dfaure added a comment. In D23898#529947 , @elvisangelaccio wrote: > I don't have 5.14 around atm, so I trust you've tested this :) Well the only new thing in 5.14 is a runtime warning. This patch should work with older versions of Qt to

D23895: [KDeclarative autotests] Replace fork of old modeltest with QAbstractItemModelTester

dfaure closed this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23895 To: dfaure, mart, davidedmundson, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23895: [KDeclarative autotests] Replace fork of old modeltest with QAbstractItemModelTester

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH modeltest REVISION DETAIL https://phabricator.kde.org/D23895 To: dfaure, mart, davidedmundson, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

dfaure updated this revision to Diff 65905. dfaure added a comment. Clean up autotest code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23898?vs=65903&id=65905 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23898 AFFECTED FILES autotests/

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. I don't have 5.14 around atm, so I trust you've tested this :) INLINE COMMENTS > kurlnavigatortest.cpp:265 > +KFilePlacesModel model; > +const QString pwd = QDir::

D23551: CMake config files: use as dep version the Qt one built against (private API)

kossebau retitled this revision from "CMake config files: use as min dep version the Qt version we built against" to "CMake config files: use as dep version the Qt one built against (private API)". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23551 To: kossebau, #fr

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

dfaure created this revision. dfaure added a reviewer: elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Since Qt-5.14 this leads to a runtime warning from QCharRef. The solution r

D23813: Port away from foreach loops over arguments without calls to owner class

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in kkeysequencewidget.cpp:127 > My two (inexperienced) pennyworth: if it makes sense, and should have been > done to begin with (so most likely it's an oversight), I'd always go for it > (who knows how long it'll be before that

D23813: Port away from foreach loops over arguments without calls to owner class

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in kkeysequencewidget.cpp:127 > I try (hard, there are many temptations when looking at all exisiting loop > code) to usually do not too much other improvements but stay on-topic of > commit message change, but will do an except

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/69/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Sep 2019 10:32:35 + Build duration: 9 min 24 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 79 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/79/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 10:32:35 + Build duration: 6 min 50 sec and counting CONSOLE OUTPUT [...truncated 1883 l

D23893: [KIO] Port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23893 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.13 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.13/16/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 10:30:55 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT [...truncated 43

D23896: [KDeclarative] Port away from deprecated QQuickWindow::sendEvent

dfaure created this revision. dfaure added reviewers: mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The code in QQuickWindow::sendEvent doesn't do anything special for Ungrab

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/17/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 10:26:33 + Build duration: 1 min 42 sec and counting CONSOLE OUTPUT [...truncated 442

D23895: [KDeclarative autotests] Replace fork of old modeltest with QAbstractItemModelTester

dfaure created this revision. dfaure added reviewers: mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN make && ctest REPOSITORY R296 KDeclarative BRANCH modeltest REVISION DETAIL

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 199 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/199/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Sep 2019 10:13:51 + Build duration: 7 min 6 sec and counting BUILD ARTIFACTS abi-compatibil

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

dfaure created this revision. dfaure added reviewers: mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY I'm assuming we don't want to rename the property just yet, for SC? Are th

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.13/18/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 12 Sep 2019 10:13:51 + Build duration: 3 min 15 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/48/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 10:13:51 + Build duration: 2 min 56 sec and counting BUILD ARTIFACTS abi-compatibil

D23893: [KIO] Port away from deprecated methods in Qt 5.14

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH port_to_qt_514 REVISION DETAIL https://phabricator.kde.org/D23893 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/46/ Project: kf5-qt5 AndroidQt5.13 Date of build: Thu, 12 Sep 2019 10:13:50 + Build duration: 1 min 15 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Sep 2019 10:13:51 + Build duration: 49 sec and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 212 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/212/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Sep 2019 09:59:03 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5KIO-5.62.0.xmllog

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/79/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Sep 2019 09:58:11 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 45 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/45/ Project: kf5-qt5 AndroidQt5.13 Date of build: Thu, 12 Sep 2019 10:04:24 + Build duration: 3 min 22 sec and counting CONSOLE OUTPUT [...trunc

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/16/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 10:02:18 + Build duration: 4 min 39 sec and counting CONSOLE OUTPUT [...truncated 430

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/47/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 10:04:25 + Build duration: 1 min 45 sec and counting CONSOLE OUTPUT [...truncated 2

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.13/17/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 12 Sep 2019 10:04:25 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT [.

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 198 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/198/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 12 Sep 2019 10:04:25 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated 257 li

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 12 Sep 2019 10:04:25 + Build duration: 43 sec and counting CONSOLE OUTPUT [...truncated 2

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/31/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 12 Sep 2019 09:58:19 + Build duration: 5 min 1 sec and counting BUILD ARTIFACTS abi-compatib

D23893: [KIO] Port away from deprecated methods in Qt 5.14

dfaure created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN make; ctest REPOSITORY R241 KIO BRANCH port_to_qt_514 REVISION DETAIL https://phabricator.kde.org/D23893 AFFECTED FILES

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Meanwhile lsof was installed on the Linux CI nodes, but this fix is still good to have of course, just in case. INLINE COMMENTS > klistopenfilesjobtest_unix.cpp:34 > + > +bool Ha

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 19 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/19/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 12 Sep 2019 06:46:15 + Build duration: 2 hr 18 min and counting JUnit Tests