ahmadsamir added inline comments. INLINE COMMENTS
> kossebau wrote in kkeysequencewidget.cpp:127 > As someone who looked at a lot of commit history, my recommendation is: don't > do in the same commit. Make it a separate commit with a dedicated commit > message. > While-at-it changes are annoying for future code history readers, which > includes one older-self. So not only for that reason be friendly to them :) I understand. but I was talking about this case specifically, it's about foreach two arguments, and making them const as needed, so that seqAsString change is in inline with replacing foreach with range-for. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23813 To: kossebau, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
