D23700: view: Port away from foreach loops over members without calls to owner

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_view REVISION DETAIL https://phabricator.kde.org/D23700 To: kossebau, #kate, dhaumann Cc: kwrite-devel, kde-frameworks-devel

D23701: undo: Port away from foreach loops over members without calls to owner

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_undo REVISION DETAIL https://phabricator.kde.org/D23701 To: kossebau, #kate, dhaumann

D23702: utils: Port away from foreach loops over members without calls to owner

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm, please commit. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_utils REVISION DETAIL https://phabricator.kde.org/D23702 To: kossebau, #k

D23703: (others): Port away from foreach loops over members without calls to owner

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please commit, thanks. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_others REVISION DETAIL https://phabricator.kde.org/D23703 To: kossebau,

D23713: strongswan support for custom proposals

pino added inline comments. INLINE COMMENTS > strongswanprop.ui:291 > + > + Cipher proposals > + nitpick: "Cipher Proposals" > strongswanprop.ui:295-299 > + > + > +Enable custom proposals > + > + maybe use the checka

D23713: strongswan support for custom proposals

rrichmond created this revision. rrichmond added reviewers: fvogt, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. rrichmond requested review of this revision. REVISION SUMMARY This patch brings feature

D23667: Add == and != operators to KIO::UDSEntry

pino added a comment. please use `QCOMPARE`/`QVERIFY` instead of `Q_ASSERT` in QTest tests INLINE COMMENTS > udsentrytest.cpp:301 > + > +// 4th entry : an additionnal field > +KIO::UDSEntry entry4; typo, "additional" REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

ngraham added a comment. Ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23711: Improve "user-trash" icon

ngraham accepted this revision. ngraham added a reviewer: ndavis. ngraham added a comment. I like it! The old one was a bit stumpy IMO. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23711 To: GB_2, #vdg, ngraham, ndavis Cc: ngraham, kde-frameworks-devel, #vdg,

D23711: Improve "user-trash" icon

GB_2 created this revision. GB_2 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Make some gradients and details look better. Old: F7314350: Old Trash Icon.png

D23707: Fix crash on teardown with Applet's ConfigLoader

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. Indeed, I could reproduce the crash again with `kquitapp5 plasmashell`. I've applied this patch on top of plasma-framework-5.16.4, built, installed, `kquitapp5 plasmashell` no lon

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.12 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Sep 2019 18:08:27 + Build duration: 6 min 51 sec and counting BUILD ARTIFACTS abi-compatibilit

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.13 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.13/11/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Sep 2019 18:08:26 + Build duration: 3 min 44 sec and counting BUILD ARTIFACTS abi-compatibilit

D22069: Localize long number strings

This revision was automatically updated to reflect the committed changes. Closed by commit R249:b0dbb285bd21: Localize long number strings (authored by ngraham). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22069?vs=65283&id=65351 REVISION DETAIL https://ph

D22069: Localize long number strings

ngraham edited the summary of this revision. REPOSITORY R249 KI18n BRANCH localized-long-number-strings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik, aacid Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev,

D22069: Localize long number strings

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH localized-long-number-strings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik, aacid Cc: aacid, huftis, sa

D23699: mode: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. That looks sane for me. If there are threads this will all break into parts, there is no need to care for that (the shared containers are then not the real issue). REPOSITORY R39 KT

D23691: C & ISO C++: add digraphs (folding & preprocessor)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:364ed572e2ec: C & ISO C++: add digraphs (folding & preprocessor) (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.

D23691: C & ISO C++: add digraphs (folding & preprocessor)

cullmann added a comment. Btw., BIG thanks for taking care of all this highlighting issues! REPOSITORY R216 Syntax Highlighting BRANCH cpp-digraphs REVISION DETAIL https://phabricator.kde.org/D23691 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-f

D23688: Allow to customize attributes for KSyntaxHighligting themes

This revision was automatically updated to reflect the committed changes. Closed by commit R39:1c0b0069b960: Allow to customize attributes for KSyntaxHighligting themes (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D23691: C & ISO C++: add digraphs (folding & preprocessor)

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think di-graphs are good enough, tri-graphs are ancient cruft. REPOSITORY R216 Syntax Highlighting BRANCH cpp-digraphs REVISION DETAIL https://phabricator.kde.org/D23691 To: n

D23695: autotests: Port away from foreach loops over members without calls to owner

This revision was automatically updated to reflect the committed changes. Closed by commit R39:54e241d18779: autotests: Port away from foreach loops over members without calls to owner (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann added a comment. :=) I have no idea, I hope future Qt versions are there more consistent with STL, which I prefer. Please push this as is, at least we are away from Q_FOREACH. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_autotests REVISIO

D23695: autotests: Port away from foreach loops over members without calls to owner

kossebau added a comment. I have never seen a range-based for loop with qmap/qhash. But then I also only now learned about the existence of QKeyValueIterator being triggered by your question :) Looking further, given the definition of range-for, for what I understand, we are still out o

D23708: [CopyJob] Fix crash when copying all files is skipped for an already existing dir

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY In copyNextFile() if all files have been skipped QList::erase() will return end() iterator, accessing the element

D23705: Use empty/filled style for monochrome empty/full trash

This revision was automatically updated to reflect the committed changes. Closed by commit R266:34fe98546fae: Use empty/filled style for monochrome empty/full trash (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23705?vs=65329&id=653

D23694: Add support for sshfs to the fstab backend

albertvaka added a comment. If it's a problem for kdeconnect mounts to appear there, how can we hide it? It's an sshfs mountpoint like any other, only that it is mounted programmatically. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, bro

D23707: Fix crash on teardown with Applet's ConfigLoader

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Deleting AppletPrivate will delete the ConfigLoader which will ca

D23705: Use empty/filled style for monochrome empty/full trash

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH trash (branched from master) REVISION DETAIL https://phabricator.kde.org/D23705 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, brun

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann added a comment. I would have thought you could use the it.value/key stuff with the range based for, too, but I must confess I mostly use stl containers with for, perhaps mistaken. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_autotests REV

D23627: Make notification icons use outline style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:db7837d5f5c1: Make notification icons use outline style (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23627?vs=65102&id=65

D23658: Make notification icons use outline style

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e01013922cb9: Make notification icons use outline style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23658?vs=65309&id=65333 REVISION

D21760: Add KListOpenFilesJob

hallas added inline comments. INLINE COMMENTS > klistopenfiles.h:23 > + > +#ifndef KLISTOPENFILES_H > +#define KLISTOPENFILES_H Should these files be renamed to klistopenfilesjob (along with tests etc.) now that is what the class is called? REPOSITORY R244 KCoreAddons REVISION DETAIL http

D21760: Add KListOpenFilesJob

hallas added a comment. In D21760#524860 , @dfaure wrote: > Given that the namespace doesn't contain anything else anymore, I would just get rid of it, and provide a single class, KListOpenFilesJob. Done :) REPOSITORY R244 KCoreAddons

D21760: Add KListOpenFilesJob

hallas updated this revision to Diff 65330. hallas added a comment. Removed KListOpenFiles namespace and renamed ListOpenFilesJob to KListOpenFilesJob REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21760?vs=65284&id=65330 BRANCH add_list_processes_w

D21760: Add KListOpenFilesJob

hallas retitled this revision from "Add KListOpenFiles::ListOpenFilesJob" to "Add KListOpenFilesJob". hallas edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #

D23705: Use empty/filled style for monochrome empty/full trash

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23705 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23705: Use empty/filled style for monochrome empty/full trash

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY We shouldn't rely purely on color to indicate state and red is the wrong color in the first

D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid

maltek added a reviewer: adridg. maltek added a comment. I have no idea who to specify as reviewer, so I'm picking the maintainer from `src/README`, Adriaan de Groot. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D23692 To: maltek, adridg Cc: kde-frameworks-devel, Le

D23695: autotests: Port away from foreach loops over members without calls to owner

kossebau added a comment. In D23695#525155 , @cullmann wrote: > thought not sure why a range based for doesn't work on the m_codesToSpecialKeys stuff with qAsConst. But I assume that has some reason and it is just testing code anyways. T

D23685: Make user-trash icons look like trashcans

Codezela added a comment. I think they looks different The shadow on the empty one make it looks very flat Or maybe squashed The full state looks better REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg, ngraham Cc: Codezela, ngraham,

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann added a comment. thought not sure why a range based for doesn't work on the m_codesToSpecialKeys stuff with qAsConst. But I assume that has some reason and it is just testing code anyways. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_autote

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 65328. apol marked 6 inline comments as done. apol added a comment. Forgot these REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65327&id=65328 BRANCH master REVISION DETAIL https://phabric

D23695: autotests: Port away from foreach loops over members without calls to owner

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ok REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_autotests REVISION DETAIL https://phabricator.kde.org/D23695 To: kossebau, #kate, cullmann

D23682: Make use of KPluginMetaData where we can

apol updated this revision to Diff 65327. apol added a comment. address comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65261&id=65327 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 AFFECTED FILES

D23627: Make notification icons use outline style

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH bell-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma, ngraham Cc: ngraham, filipf, kde-frameworks-dev

D23658: Make notification icons use outline style

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH notifications-outline (branched from master) REVISION DETAIL https://phabricator.kde.org/D23658 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2

D23703: (others): Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23685: Make user-trash icons look like trashcans

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d970e61493a6: Make user-trash icons look like trashcans (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23685?vs=65268&id=65322 REVISION

D23702: utils: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23685: Make user-trash icons look like trashcans

ndavis added a comment. In D23685#525085 , @ngraham wrote: > Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it, defea

D23701: undo: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23685: Make user-trash icons look like trashcans

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it, defeats

D23685: Make user-trash icons look like trashcans

ndavis added a comment. In D23685#525072 , @ngraham wrote: > In D23685#524935 , @ndavis wrote: > > > > Before, the red folder background made it instantly recognizable that the trash was full--even i

D23700: view: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23696: completion: Port away from foreach loops over members without calls to owner

kossebau edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23696 To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23699: mode: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23685: Make user-trash icons look like trashcans

ngraham added a comment. In D23685#524935 , @ndavis wrote: > > Before, the red folder background made it instantly recognizable that the trash was full--even if this wasn't really an appropriate visual metaphor. I wonder if we could play with ot

D23698: document: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23697: buffer: Port away from foreach loops over members without calls to owner

kossebau edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23697 To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23697: buffer: Port away from foreach loops over members without calls to owner

kossebau added a comment. Also candidate for post 5.62-tagging, for some weeks of testing in master. Like all the following review requests. only the autotest one should be good to go in before, not critical to users. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.or

D23697: buffer: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23696: completion: Port away from foreach loops over members without calls to owner

kossebau added a comment. Candidate for post 5.62-tagging, for some weeks of testing in master. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23696 To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, de

D23694: Add support for sshfs to the fstab backend

ngraham added a comment. +1 for doing this and also fixing KDE Connect to not expose its mount as an implementation detail. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: ngraham, kde-frameworks-devel, LeGa

D23696: completion: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY There is some small risk here: - overseen call chains which st

D23695: autotests: Port away from foreach loops over members without calls to owner

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimatio

D23689: Port away from Qt's foreach all loops over rvalue container objects

This revision was automatically updated to reflect the committed changes. Closed by commit R39:baea21ac638f: Port away from Qt's foreach all loops over rvalue container objects (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23689?vs=

D23464: Add breeze icons for ROOT cern files

This revision was automatically updated to reflect the committed changes. Closed by commit R266:018b67eff94c: Add breeze icons for ROOT cern files (authored by Marc Henning , committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://p

D23464: Add breeze icons for ROOT cern files

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23667: Add == and != operators to KIO::UDSEntry

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks, ngraham Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#524994 , @ndavis wrote: > Looks like you've got everything Thank you all for mentoring me! :) REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kd

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

ndavis added a comment. Looks like you've got everything REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ng

D23464: Add breeze icons for ROOT cern files

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n,

D23658: Make notification icons use outline style

ndavis updated this revision to Diff 65309. ndavis added a comment. Move color preference clapper to center REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23658?vs=65195&id=65309 BRANCH notifications-outline (branched from master) REVISION DETAIL

D23694: Add support for sshfs to the fstab backend

broulik added a reviewer: KDE Connect. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23694: Add support for sshfs to the fstab backend

broulik added a comment. This causes KDE connect drive to show up as "/run/user/1000/HASH (fuse.sshfs)" in places panel while being accessed. I really don't like KDE connect using sshfs, though, so +1 from me :P REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 65307. alexde added a comment. 16px: add 2px margins to top and bottom 22px: add 3px margins to top and bottom 32px: use existing and approved 32px icon as template instead of shrinking the 64px version REPOSITORY R266 Breeze Icons CHANGES SINCE LAS

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. In D23694#524968 , @fvogt wrote: > `fuse.sshfs` is used by kdeconnect as well, does that cause some kind of conflict? I can't test this in the current network (no office wifi, broadcast blocked at all levels).

D23694: Add support for sshfs to the fstab backend

fvogt added a comment. `fuse.sshfs` is used by kdeconnect as well, does that cause some kind of conflict? If not, LGTM. Could be improved by adding other filesystems (curlftpfs?) as well and using something like `QStringList{"nfs", "nfs4", "smbfs", "cifs", "fuse.sshfs"}.contain

D23694: Add support for sshfs to the fstab backend

lbeltrame created this revision. lbeltrame added reviewers: bruns, broulik, fvogt. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lbeltrame requested review of this revision. REVISION SUMMARY This commit introduces support for sshfs as network filesystem.

D23689: Port away from Qt's foreach all loops over rvalue container objects

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm REPOSITORY R39 KTextEditor BRANCH moreplainforeachport REVISION DETAIL https://phabricator.kde.org/D23689 To: kossebau, #kate, dhaumann Cc: dhaumann, kwrite-devel, kde-fram

D23685: Make user-trash icons look like trashcans

ndavis added a comment. In D23685#524775 , @ngraham wrote: > Yay real trashcans The appearance is definitely more appropriate compared to before. I really like it. > > However I'm afraid the visual recognizability of the full state compar

D22569: [Dialog] Apply window type after changing flags

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22569 To: broulik, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Sep 2019 10:09:09 + Build duration: 7 min 58 sec and counting JUnit Tests Name: projectroo

D22510: Added dialog to set execute permission for executable file when trying to run it.

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

dfaure accepted this revision. dfaure added a comment. Thanks! I'll land it. REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n,

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski marked an inline comment as done. mdlubakowski added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:147 > Hmm, because isExecutable(mimetype) also returns true for desktop files. > > So this would change behaviour for users of this API. (see why we try to > limit publi

Status of unittests in CI: good news

Hello everyone, I have the pleasure to announce that for the first time in many years, the status of CI is all green (well, blue) on Linux. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/ and https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.13/ say all tests

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski updated this revision to Diff 65302. mdlubakowski added a comment. - Reverted change to KRun::isExecutableFile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=65265&id=65302 BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.k

D23692: kdesu: set kernel flags to prevent ptrace instead of relying on setgid

maltek created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. maltek requested review of this revision. REVISION SUMMARY So I noticed that kdesu is setgid 'nogroup'. That group is the fallback for groups from a remote NFS share that do not ex

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65298. meven added a comment. fix since mention REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65297&id=65298 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES autotests/udsentr

D23667: Add == and != operators to KIO::UDSEntry

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23667 To: meven, #frameworks Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65297. meven added a comment. Fix test udsentrybenchmark REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65296&id=65297 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES autotest

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Sep 2019 09:17:44 + Build duration: 1 min 24 sec and counting JUnit Tests Name: proje

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65296. meven added a comment. Clean spaces changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65295&id=65296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AFFECTED FILES autotests/udse

D23667: Add == and != operators to KIO::UDSEntry

meven updated this revision to Diff 65295. meven added a comment. Move impl to cpp file, fix comment, add unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23667?vs=65218&id=65295 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23667 AF

D23691: C & ISO C++: add digraphs (folding & preprocessor)

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23691 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demski

  1   2   >