kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision.
REVISION SUMMARY There is some small risk here: - overseen call chains which still call the owner and modify the container - other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_completion REVISION DETAIL https://phabricator.kde.org/D23696 AFFECTED FILES src/completion/kateargumenthintmodel.cpp src/completion/katecompletionconfig.cpp src/completion/katecompletionmodel.cpp src/completion/katecompletionwidget.cpp src/completion/katewordcompletion.cpp To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann