D22653: Add view-barcode-qr icons

ndavis added a comment. I think you accidentally included a bunch of unrelated files. BTW, I'm currently on vacation and can't access my laptop. Could you show me a screenshot of the 32px icon at 1x size? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22653 T

D22570: Expose X-KDE-Wayland-Interfaces

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22570 To: apol, #frameworks, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraha

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22786 To: aacid, apol, dfaure Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22786: KTar::openArchive: Don't assert if file has two root dirs

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH arcpatch-D22786 REVISION DETAIL https://phabricator.kde.org/D22786 To: aacid, apol, dfaure Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, brun

D22653: Add view-barcode-qr icons

mbruchert updated this revision to Diff 62761. mbruchert added a comment. remove corners REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62759&id=62761 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILES ico

D22653: Add view-barcode-qr icons

mbruchert updated this revision to Diff 62759. mbruchert added a comment. remove corners REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62754&id=62759 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILES ico

D22653: Add view-barcode-qr icons

mbruchert updated this revision to Diff 62754. mbruchert added a comment. - remove blue corners REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22653?vs=62460&id=62754 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22653 AFFECTED FILE

D22786: KTar::openArchive: Don't assert if file has two root dirs

aacid updated this revision to Diff 62749. aacid added a comment. don't return false on the "two roots scenario" as suggested by dfaure REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22786?vs=62684&id=62749 BRANCH arcpatch-D22786 REVISION DETAIL http

D22782: KZip::openArchive: Don't assert when opening broken files

aacid added a comment. Ok, if you think so, you're the maintainer after all. But since you seem to have a clear idea of how the error messages should look like, maybe we can do it the other way around, you do the patch and i review it? REPOSITORY R243 KArchive REVISION DETAIL https://ph

D22800: Fix KService build on Android

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Change looks fine to me, no opinion on the platform define style. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22800 To: apol, #frameworks,

D22789: KZip::openArchive: Don't assert when opening broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22789 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

volkov added a reviewer: broulik. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22809 To: volkov, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22809: Restore "Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway"

volkov created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY This restores commit 49f8718446322b1722822f99f6b9f3b975ea723e

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added inline comments. INLINE COMMENTS > volkov wrote in kiconloader.cpp:1368 > Looks like a rebase: > https://phabricator.kde.org/D6313?vs=31197&id=34779&whitespace=ignore-most#toc Feel free to submit a patch to restore this REPOSITORY R302 KIconThemes REVISION DETAIL https://pha

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > broulik wrote in kiconloader.cpp:1368 > Dunno, probably oversight or forgotten to rebase.. Looks like a rebase: https://phabricator.kde.org/D6313?vs=31197&id=34779&whitespace=ignore-most#toc REPOSITORY R302 KIconThemes REVISION DETAIL https:

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added inline comments. INLINE COMMENTS > volkov wrote in kiconloader.cpp:1368 > Why this line reverts D12002 ? Dunno, probably oversight or forgotten to rebase.. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: b

D6313: Support Icon Scale from Icon naming specification 0.13

volkov added inline comments. INLINE COMMENTS > kiconloader.cpp:1368 > > -if (group >= 0 && group < KIconLoader::LastGroup) { > +if (group >= 0) { > img = d->mpEffect.apply(img, group, state); Why this line reverts D12002 ? REPOSITORY R30

D22805: set autorcc by default

vkrause added a comment. +1, same for AUTOUIC probably? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22790: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

kossebau added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:29 > Would it make sense to have this option with the macro? This way we make sure > it's easy to disable and we save some boilerplate on every project. Yes, asked myself the same when doing all the patches for all t

D22805: set autorcc by default

kossebau added inline comments. INLINE COMMENTS > sitter wrote in KDECMakeSettings.cmake:243 > This is cmakes's own behavior. <3.0 has no autorcc to begin with. > > That being said the only reason I put the if there is because ECM itself is > compatible with 2.8.12, so the if seemed appropriate

D22805: set autorcc by default

sitter added inline comments. INLINE COMMENTS > kossebau wrote in KDECMakeSettings.cmake:243 > Not sure if anyone is using cmake < 3.0 these days, but if, this will be a > surprise box to them, as with some biulds things work (where cmake >= 3.0) > and with some builds not. > > This needs expl

D22805: set autorcc by default

kossebau added a comment. Just a small principal comment with "supporting-old-versions" hat on. Cannot give feedback on autorcc itself, never used, so no idea how useful/reliable it is. INLINE COMMENTS > KDECMakeSettings.cmake:243 > + # Since CMake 3.0 > + if(NOT CMAKE_VERSION VERSION_

D22805: set autorcc by default

sitter edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22805: set autorcc by default

apol added a comment. +1 I've been using it in several project, it works good. I don't see how this could be misused. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron,

D22805: set autorcc by default

sitter created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY I couldn't find any pertinent discussion on the topic but some reviews I stumbled over did

D22800: Fix KService build on Android

apol added inline comments. INLINE COMMENTS > broulik wrote in kbuildsycoca_main.cpp:26 > `Q_OS_ANDROID`? Why? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D22800 To: apol, #frameworks, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngrah

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 136 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/136/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 29 Jul 2019 10:12:27 + Build duration: 5 min 45 sec and counting JUnit Tests Nam

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/14/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 29 Jul 2019 09:43:47 + Build duration: 4 min 20 sec and counting BUILD ARTIFACTS acc/KF5Purpose-

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 135 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/135/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 29 Jul 2019 09:43:46 + Build duration: 2 min 59 sec and counting CONSOLE OUTPUT [

D22801: [KIO] silence a QFileInfo warning

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22801: [KIO] silence a QFileInfo warning

rjvbb updated this revision to Diff 62715. rjvbb edited the summary of this revision. rjvbb added a comment. It's probably not a bad idea too to return early if ever the computed `realname` is empty, and avoid the iteration which should be pointless in that case. Right?! CHANGES SINCE LAST U

D22801: [KIO] silence a QFileInfo warning

rjvbb created this revision. rjvbb added a reviewer: Frameworks. Herald added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY Prevent qWarning() messages that can arise when browsing samba shares: QFileInfo::absolutePath: Constructed with empty filename

D22786: KTar::openArchive: Don't assert if file has two root dirs

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Let's be tolerant and skip the second root dir (with a warning, but without return false). This would be more in line with what we do in case of duplicated subdirs, and with what

D22782: KZip::openArchive: Don't assert when opening broken files

dfaure added a comment. I disagree. Those errors are for developers, and should therefore be in English (and in qWarning), rather than translated and shown to the user. A bug report with "Could not seek to file compressed size" translated to Russian or Chinese isn't going to be very useful

D7446: [Places panel] Revamp the Recently Saved section

meven added a comment. I am working on allow to filter by resource activity date D22717 and D22775 (I will add this soonish into recentlyused:/ ioslave D22144 ) This will allow