D22253: Improve the Fortran fixed format syntax highlighting

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22253 To: nononux, nibags Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D22253: Improve the Fortran fixed format syntax highlighting

nibags accepted this revision. nibags added a comment. This revision is now accepted and ready to land. That is complicated to do, we would have to make rules for all the columns before 72 and for all the possible matchings, which is a lot of work and would make the code difficult to maintain

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/4/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 06 Jul 2019 03:14:45 + Build duration: 27 min and counting BUILD ARTIFACTS acc/KF5KIO-5.60.0.xmllogs

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 137 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/137/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 06 Jul 2019 03:15:26 + Build duration: 20 min and counting JUnit Tests Name: pr

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/146/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 06 Jul 2019 03:14:50 + Build duration: 18 min and counting JUnit Tests Name: projectroot Fai

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/69/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Jul 2019 03:15:34 + Build duration: 16 min and counting BUILD ARTIFACTS acc/KF5Purpose-5.60.0

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/4/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 06 Jul 2019 03:15:24 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/136/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Jul 2019 03:14:50 + Build duration: 14 min and counting BUILD ARTIFACTS acc/KF5KIO-5.60.0.xmllo

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/127/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 06 Jul 2019 03:15:28 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compat

D22276: Add an action to insert a non-indented newline

ahmadsamir added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.h:827 > I dislike the double negation: noIndentation = false. Later even > !noIndentation. This is bad API design. > > Please change to bool indent = true. Noted. Although I'll use an enum per cullmann's recomme

D22276: Add an action to insert a non-indented newline

cullmann added inline comments. INLINE COMMENTS > dhaumann wrote in kateview.cpp:2881 > Do we really need this call? Also Don't we miss setting the cursor position? > Incliding a begin/endEdit? I assume this is just copied from the normal void KTextEditor::ViewPrivate::keyReturn() { doc()->

D20526: Fix extracting of some properties to match what was written

This revision was automatically updated to reflect the committed changes. Closed by commit R286:a51e96979b4e: Fix extracting of some properties to match what was written (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20526?vs=608

D20526: Fix extracting of some properties to match what was written

astippich added a comment. thanks REPOSITORY R286 KFileMetaData BRANCH arcpatch-D20526 REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngr

D21002: Remove kde4 migration agent completely

bruns added a comment. Can I have a "go"? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

albertvaka added inline comments. INLINE COMMENTS > brute4s99 wrote in kio_sftp.cpp:2257 > yes! thanks Hannah! 🎉 You can keep QT_STAT_LNK on every platform and remove the ifdef. That's the point of the abstraction Qt provides. For consistency, I would also change the other (S_IFDIR, etc.) to t

D20526: Fix extracting of some properties to match what was written

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH arcpatch-D20526 REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashapos

KDE CI: Frameworks » kitemmodels » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 6 min 17 sec and counting

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 5 min 55 sec and counting

KDE CI: Frameworks » kplotting » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:27 + Build duration: 3 min 58 sec and counting

KDE CI: Frameworks » kitemviews » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemviews/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 4 min 9 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 4 min 14 sec and counting

KDE CI: Frameworks » kimageformats » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 4 min 5 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 3 min 42 sec and counting

KDE CI: Frameworks » kholidays » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 4 min 15 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:27 + Build duration: 3 min 38 sec and counting

KDE CI: Frameworks » kcodecs » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 3 min 12 sec and counting

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:27 + Build duration: 3 min 0 sec and counting

KDE CI: Frameworks » threadweaver » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:28 + Build duration: 3 min 14 sec and counting

KDE CI: Frameworks » karchive » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:26 + Build duration: 3 min 12 sec and counting

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:26 + Build duration: 3 min 12 sec and counting

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:26 + Build duration: 3 min 13 sec and counting

KDE CI: Frameworks » syndication » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:27 + Build duration: 2 min 5 sec and counting

KDE CI: Frameworks » ki18n » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:27 + Build duration: 2 min 20 sec and counting

KDE CI: Frameworks » kguiaddons » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kguiaddons/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:27 + Build duration: 2 min 3 sec and counting

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:27 + Build duration: 2 min 13 sec and counting

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:25 + Build duration: 58 sec and counting

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:25 + Build duration: 1 min 7 sec and counting

KDE CI: Frameworks » kcompletion » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:25 + Build duration: 1 min 10 sec and counting

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:25 + Build duration: 52 sec and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/1/ Project: kf5-qt5 AndroidQt5.13 Date of build: Fri, 05 Jul 2019 19:20:26 + Build duration: 1 min 16 sec and counting

D22253: Improve the Fortran fixed format syntax highlighting

nononux marked 2 inline comments as done. nononux added a comment. Thanks for the improvements propositions. In the same way, I note the ">72th column" highlighting is not working when a context start before the 72th column and goes after. For example if a 2 digits number is placed on c

D22253: Improve the Fortran fixed format syntax highlighting

nononux updated this revision to Diff 61238. nononux added a comment. Update with nibags recommendations REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22253?vs=61110&id=61238 BRANCH fortran-fixed-format (branched from master) REVISION DETAI

D22241: KModifierKeyInfo: we are sharing the internal implementation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R273:7ecff22e7215: KModifierKeyInfo: we are sharing the internal implementation (authored by apol). REPOSITORY R273 KGuiA

D22241: KModifierKeyInfo: we are sharing the internal implementation

apol added a comment. Landing because it works and we want it in before the freeze. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D22241 To: apol, broulik Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

brute4s99 added a comment. In D21660#481421 , @bcooksley wrote: > Where possible D-Bus should be avoided on Windows. Thanks for taking a look, @bcooksley! We already use dbus-daemon.exe for a lot of talking with the notifications and (I

D22083: introduce concept of header and footer for kpageview

hpereiradacosta added a comment. In D22083#491299 , @mart wrote: > code issues are fixed. > Now for removing the further margin around the whole window: > should that be done here or in breeze? > if done here, it may make it look bad on a

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in kio_sftp.cpp:2257 > Does > https://code.woboq.org/qt5/qtbase/mkspecs/common/posix/qplatformdefs.h.html#111 > work? yes! thanks Hannah! 🎉 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To:

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked 9 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: andriusr, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, mich

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61225. brute4s99 added a comment. added handling for WIndows. I'll try it on linux and revert on this patch! REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61035&id=61225 BRANCH arcpatch-D22105 REVISIO

D22267: ContainmentAction: Fix loading from KPlugin

kossebau added a comment. FTR now that all dep builds are updated, the plasma-frameworks part of the Plasma product also all passed, so all as it should. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks, mart Cc

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 136 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/136/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 05 Jul 2019 11:57:43 + Build duration: 43 min and counting JUnit Tests Name: pr

D22102: Implement apply-on-double-click for all grid view KCM delegates

ngraham added a comment. In D22102#488774 , @mglb wrote: > In D22102#487806 , @ngraham wrote: > > > use its hidden Alt accelerator. > > > Looks like already working solution for the problem. Wh

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/145/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 05 Jul 2019 11:18:15 + Build duration: 1 hr 5 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/3/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 05 Jul 2019 11:57:43 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/126/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:57:43 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compat

D22275: [Svg] Fix porting error from QRegExp::exactMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R242:214838313d9f: [Svg] Fix porting error from QRegExp::exactMatch (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22275?vs=611

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/3/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 05 Jul 2019 11:18:15 + Build duration: 21 min and counting BUILD ARTIFACTS acc/KF5KIO-5.60.0.xmllogs

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/135/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:18:15 + Build duration: 16 min and counting BUILD ARTIFACTS acc/KF5KIO-5.60.0.xmllo

D22083: introduce concept of header and footer for kpageview

mart added a comment. code issues are fixed. Now for removing the further margin around the whole window: should that be done here or in breeze? if done here, it may make it look bad on all other widget styles? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.o

D22083: introduce concept of header and footer for kpageview

mart reopened this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks, #vdg Cc: hpereiradacosta, cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22083: introduce concept of header and footer for kpageview

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. mart marked 3 inline comments as done. Closed by commit R236:fd5899d49d01: adress code style comments (authored by mart). CHANGED PRIOR TO C

D22083: introduce concept of header and footer for kpageview

mart updated this revision to Diff 61206. mart added a comment. - introduce concept of header and footer for kpageview - adress code style comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22083?vs=60603&id=61206 BRANCH mart/pageviewfooter

D22267: ContainmentAction: Fix loading from KPlugin

kossebau added a comment. In D22267#491236 , @kossebau wrote: > Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look. Ah, my had. This is the build variant

D22281: Do not crash if the inner file wants to be bigger than QByteArray max size

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D22281 To: aacid, apol Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22265: KPluginMetaData: use Q_DECLARE_METATYPE

kossebau added a comment. This runs the chance to break some 3rd-party software which also calls the Q_DECLARE_METATYPE(KPluginMetaData) macro. Any chance this could be moved to the place that needs this for now, and perhaps add a KF6 TODO instead? See e.g. R36:3aacbbaab50ac6e0557c5d69

D22276: Add an action to insert a non-indented newline

bruns added a comment. In D22276#491055 , @mickaelbo wrote: > Another way to avoid indented empty line is to clear the trailing spaces/indentation when pressing enter while the cursor is at the end of a line containing only spaces or \t. This c

D22267: ContainmentAction: Fix loading from KPlugin

kossebau added a comment. Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks

D22155: Add new activities and virtual desktops icons

GB_2 added a comment. Ping REPOSITORY R266 Breeze Icons BRANCH add-new-activities-and-virtual-desktops-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D22155 To: GB_2, #vdg, ndavis Cc: anthonyfieroni, ngraham, ndavis, kde-frameworks-devel, #vdg, LeGast00n, mi

D22276: Add an action to insert a non-indented newline

dhaumann added inline comments. INLINE COMMENTS > katedocument.h:827 > > -void newLine(KTextEditor::ViewPrivate *view); // Changes input > +void newLine(KTextEditor::ViewPrivate *view, const bool noIndentation = > false); // Changes input > void backspace(KTextEditor::ViewPrivat