dhaumann added inline comments. INLINE COMMENTS
> katedocument.h:827 > > - void newLine(KTextEditor::ViewPrivate *view); // Changes input > + void newLine(KTextEditor::ViewPrivate *view, const bool noIndentation = > false); // Changes input > void backspace(KTextEditor::ViewPrivate *view, const KTextEditor::Cursor > &); I dislike the double negation: noIndentation = false. Later even !noIndentation. This is bad API design. Please change to bool indent = true. > kateview.cpp:2881 > + doc()->newLine(this, true); > + m_viewInternal->iconBorder()->updateForCursorLineChange(); > + m_viewInternal->updateView(); Do we really need this call? Also Don't we miss setting the cursor position? Incliding a begin/endEdit? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22276 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: mickaelbo, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
