D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54919. guoyunhe added a comment. Output to stderr REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54918&id=54919 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES .gi

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54918. guoyunhe added a comment. Don't use remote JavaScript library REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54688&id=54918 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 A

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/51/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Mar 2019 01:56:05 + Build duration: 7 min 17 sec and counting BUILD ARTIFACTS abi-comp

D20046: Verify mimetypes for all existing sample files, add some more

bruns added inline comments. INLINE COMMENTS > astippich wrote in extractorcoveragetest.cpp:50 > Is it really audio/x-aifc? Taglibextractor the never actually got called. > Looks like we should also wire the new helper funciton into the extractor > tests, so that we make sure they support the r

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/50/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 27 Mar 2019 01:49:01 + Build duration: 7 min 3 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/46/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 01:51:58 + Build duration: 2 min 33 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 51 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Mar 2019 01:51:46 + Build duration: 1 min 54 sec and counting JUnit Tests Name:

D20046: Verify mimetypes for all existing sample files, add some more

This revision was automatically updated to reflect the committed changes. Closed by commit R286:67bcc588feca: Verify mimetypes for all existing sample files, add some more (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20046?vs=54785

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/45/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 01:49:00 + Build duration: 2 min 56 sec and counting BUILD ARTIFACTS abi-comp

D20045: Add helper function to determine mime type based on content and extension

bruns marked 3 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20045 To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abraham

D20045: Add helper function to determine mime type based on content and extension

This revision was automatically updated to reflect the committed changes. Closed by commit R286:69c25514cf6a: Add helper function to determine mime type based on content and extension (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20

D20045: Add helper function to determine mime type based on content and extension

bruns updated this revision to Diff 54908. bruns added a comment. add documentation REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20045?vs=54784&id=54908 BRANCH submit_mime REVISION DETAIL https://phabricator.kde.org/D20045 AFFECTED FILES sr

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#439031 , @arvidhansson wrote: > In D19952#438965 , @ndavis wrote: > > > The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he chan

D20045: Add helper function to determine mime type based on content and extension

bruns added inline comments. INLINE COMMENTS > astippich wrote in mimeutils.cpp:39 > That reads a little bit confusing. I think it is more clear to write > something like "Check if extension based mime type is a specialized..."? that would be the wrong way round ... REPOSITORY R286 KFileMeta

D20041: [balooctl] Reduce nesting level for addOption arguments, cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit R293:cc705f52d908: [balooctl] Reduce nesting level for addOption arguments, cleanup (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20041?vs=54769&id=5

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 27 Mar 2019 00:08:08 + Build duration: 9 min 22 sec and counting BUILD ARTIFACTS abi-compatibilit

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

bruns marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19087 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/42/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 27 Mar 2019 00:08:08 + Build duration: 2 min 41 sec and counting JUnit Tests Name: projectro

D20042: Show the plasmoid context menu on long tap

apol updated this revision to Diff 54901. apol added a comment. Convert to the containment coordinate system, otherwise we show the context menu of the applet at 0,0 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20042?vs=54777&id=54901

D20070: [PlasmaComponents3 ComboBox] Fix textColor

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D20070 To: broulik, #plasma, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D20065 To: broulik, #frameworks, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail updated this revision to Diff 54897. krutovmikhail added a comment. - Update per phabricator comments: styling, boolean to enum, windows fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20026?vs=54893&id=54897 BRANCH mkrutov/20190324/feat/kur

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#438965 , @ndavis wrote: > The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. Yes, I was mostly pointing out that it seems to be out of scope of this revision to fix that problem :-) https://bugs.kde.org/show_bug.cgi?id=157593#c4 this seems to be the most reasonable solution, if to keep the patch there. However, pressing "return" or

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail updated this revision to Diff 54893. krutovmikhail marked 11 inline comments as done. krutovmikhail added a comment. - Update per phabricator comments: styling, boolean to enum, windows fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20026?vs=5

D20026: Go up in folder hierachy when in "edit mode"

ngraham added a comment. In D20026#438993 , @krutovmikhail wrote: > ngraham, in Dolphin, this commit is to blame for loosing editMode on changing URL: https://github.com/KDE/dolphin/commit/2af331b42c0514f4fdf848d0cc22f02717f7bec0 > > I don'

D20070: [PlasmaComponents3 ComboBox] Fix textColor

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Uses the one from `ColorScope` rather than `Kirigami`. `Kirigami.Theme` isn't u

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. ngraham, in Dolphin, this commit is to blame for loosing editMode on changing URL: https://github.com/KDE/dolphin/commit/2af331b42c0514f4fdf848d0cc22f02717f7bec0 I don't think that this behavior has any logic in it to be honest; but it seems that it was ex

D20007: Add GetProcessList for retrieving the list of currently active processes

davidedmundson added a comment. These two should make the unit tests windows compatible (untested) INLINE COMMENTS > kprocesslisttest.cpp:38 > +{ > +struct passwd *pwdEntry = getpwuid(uid); > +if (pwdEntry == nullptr) { KUser::KUser() (fortunately it's in kcoreaddons!) > kprocessli

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand off responsibility for the patch to someone else. REPOSITORY R266 Breeze Icons REVISI

D20007: Add GetProcessList for retrieving the list of currently active processes

elvisangelaccio added a comment. Don't forget to update the commit message (it still mentions "Add GetProcessList") ;) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20007 To: hallas, davidedmundson, broulik Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-

D12327: Show Detailed Tree View by default

ndavis added a comment. +1 Navigation is so much faster in tree view. I think navigation speed is what matters most of the time when people are selecting files or locations. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham, #frameworks, #vdg, apol

D12327: Show Detailed Tree View by default

ngraham added a reviewer: apol. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham, #frameworks, #vdg, apol Cc: kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, michaelh, ngraham, bruns

D12327: Show Detailed Tree View by default

ngraham removed a dependency: D12326: In Short View, display icons on top and increase icon size. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, michaelh, ngraham, bruns

D12326: In Short View, display icons on top and increase icon size

ngraham removed a dependent revision: D12327: Show Detailed Tree View by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: rkflx, abetts, anemeth, #frameworks, michaelh, ngraham, bruns

D12327: Show Detailed Tree View by default

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

bruns added a comment. This definitely should be part of the StorageVolume interface. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20062 To: chinmoyr, #frameworks, bruns, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/52/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 26 Mar 2019 17:47:58 + Build duration: 16 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/66/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Mar 2019 17:47:58 + Build duration: 13 min and counting BUILD ARTIFACTS abi-compatibility-result

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/70/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 26 Mar 2019 17:47:58 + Build duration: 10 min and counting JUnit Tests Name: projectroot Fail

D20060: [KDynamicJobTracker] Use generated DBus interface

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ed158497a322: [KDynamicJobTracker] Use generated DBus interface (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20060?vs=54848&id=54873 REVISION

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

broulik created this revision. broulik added reviewers: Frameworks, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ensures `args` are passed into the `KQuickAddons::ConfigModule` TEST PLAN

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven updated this revision to Diff 54869. meven added a comment. update commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54868&id=54869 BRANCH arcpatch-D19824 REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES src/

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

ngraham added inline comments. INLINE COMMENTS > kfilewidgettest_saving_gui.cpp:2 > +/* This file is part of the KDE libraries > +Copyright (C) 2015 David Faure > + Your copyright, since you wrote this file REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: me

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven updated this revision to Diff 54868. meven marked an inline comment as done. meven added a comment. Updated after review, add another test file instead of modifying it. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54082&id=54868 BRANCH arcpa

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

ngraham added reviewers: dfaure, sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19439 To: marten, #plasma, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarro

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

marten added a comment. Ping - anyone able to review please? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19439 To: marten, #plasma, #frameworks Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, an

D20063: Sublime Merge Icon.

filipf added a comment. Looks good. Since it's a proprietary program just check if they have any restrictions about having to use their icons. And yep, the xmlerrors file should be removed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg

D20063: Sublime Merge Icon.

ngraham added a reviewer: ndavis. ngraham added a comment. Thanks! The new icon looks good to me. However it looks like an `xmlerrors` file was accidentally added to this patch. Can you remove that? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otav

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20063: Sublime Merge Icon.

otavva added a reviewer: VDG. otavva added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg Cc: #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, roo

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert retitled this revision from "Proposal for KFileItem to skip stat()" to "KFileItem: call stat() on demand, add SkipMimeTypeDetermination option". hoffmannrobert edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hof

D20063: Sublime Merge Icon.

otavva created this revision. otavva added a project: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. otavva requested review of this revision. REVISION SUMMARY Just added Sublime Merge icon. F6720983: screenshotSMIcon.png

D20026: Go up in folder hierachy when in "edit mode"

ngraham added a comment. In D20026#438747 , @krutovmikhail wrote: > Thanks, I'll apply styling changes & will take a look at GWenView. Out of KDE Applications, what other consumers use KUrlNavigator? Is there an easy way to find out? Ch

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 54863. hoffmannrobert added a comment. - Use new KFileItem::SkipMimeTypeDetermination parameter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=54339&id=54863 BRANCH fix_recent_documents_kicker_

D19887: Proposal for KFileItem to skip stat()

hoffmannrobert updated this revision to Diff 54862. hoffmannrobert added a comment. - On-demand stat(), helper function, SkipMimeTypeDetermination REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54338&id=54862 BRANCH add_skipStat REVISION DETAIL h

D20062: [RFC] Add support for changing volume label.

chinmoyr added a comment. The issue here is the placement of code. There are no API for changing any volume attributes so adding the changeLabel() method here feels awkward. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20062 To: chinmoyr, #frameworks, bruns, brouli

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/69/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 26 Mar 2019 15:02:22 + Build duration: 28 min and counting JUnit Tests Name: projectroot Fail

D20026: Go up in folder hierachy when in "edit mode"

krutovmikhail added a comment. Thanks, I'll apply styling changes & will take a look at GWenView. Out of KDE Applications, what other consumers use KUrlNavigator? Is there an easy way to find out? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/51/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 26 Mar 2019 15:02:22 + Build duration: 21 min and counting BUILD ARTIFACTS abi-compatibility-result

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel added a comment. No worries, the other patch is better actually. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/65/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 26 Mar 2019 15:02:22 + Build duration: 12 min and counting BUILD ARTIFACTS abi-compatibility-result

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. Done in D19849 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

This revision was automatically updated to reflect the committed changes. Closed by commit R241:cb8f77ec441b: [KFileWidget] When saving, highlight filename after clicking existing file also… (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D198

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH highlight-filename-after-click-when-saving (branched from master) REVISION DETAIL https://phabricator.kde.org/D19849 To: ngraham, #frameworks, #vdg, broulik, cfeck, dfaure, apol Cc: kd

D16913: Add the possibility to give focus to the KPluginSelector search field

ngraham added a comment. Oh gosh I completely forgot about this, sorry. :( REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D19913: [plasma-desktop] make it compiles without foreach

apol added a comment. It's bad enough that we need to give things names because Qt keeps detaching on foreach, I'd be giving at least more semantic names to these temporary variables. INLINE COMMENTS > coronatest.cpp:149 > > -foreach (auto cont, m_corona->containments()) { > +cons

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel abandoned this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks, #plasma Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20059: Take clang-cl into account.

apol added a comment. LGTM, looks like clang-cl will be missing a few arguments though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf, #windows Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20060: [KDynamicJobTracker] Use generated DBus interface

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20060 To: broulik, #frameworks, davidedmundson, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20059: Take clang-cl into account.

apol added a reviewer: Windows. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf, #windows Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20034: Pass focus to child searchbar when KPluginSelector is focused

This revision was automatically updated to reflect the committed changes. Closed by commit R295:03653f4e4ef7: Pass focus to child searchbar when KPluginSelector is focused (authored by jayeshbhoot, committed by ngraham). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.

D20062: [RFC] Add support for changing volume label.

ngraham added reviewers: bruns, broulik. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20062 To: chinmoyr, #frameworks, bruns, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19956: ki18n: updating memory manager and removing compile warnings

tcanabrava added a comment. -1 gettext is c code, should not use c++ includes. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19956 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

ngraham added reviewers: broulik, cfeck, dfaure. ngraham added a comment. Ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19849 To: ngraham, #frameworks, #vdg, broulik, cfeck, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

chinmoyr created this revision. chinmoyr added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY Is this the right approach to take? REPOSITORY R245 Solid BRANCH master

D20046: Verify mimetypes for all existing sample files, add some more

astippich accepted this revision. astippich added inline comments. INLINE COMMENTS > extractorcoveragetest.cpp:50 > +m_knownFiles = { > +{ "test.aif", "audio/x-aifc"}, > +{ "test.ape", "audio/x-ape"}, Is it really audio/x-

D20045: Add helper function to determine mime type based on content and extension

astippich accepted this revision. astippich added a comment. Just two small nitpicks INLINE COMMENTS > mimeutils.cpp:39 > +for (auto mime : extensionMimes) { > +// check if the content is a specialized type (child) for a generic > container, e.g.: > +// *.mkv -> [ applica

D20042: Show the plasmoid context menu on long tap

ngraham added a comment. [testing with D20043 ] The context menu that is shown on press-and-hold seems to differ from the one shown when right-clicked: Right-clicked: F6720720: Screenshot_20190326_072442.png

D20046: Verify mimetypes for all existing sample files, add some more

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH extractor_coverage REVISION DETAIL https://phabricator.kde.org/D20046 To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson,

D20045: Add helper function to determine mime type based on content and extension

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. REPOSITORY R286 KFileMetaData BRANCH submit_mime REVISION DETAIL https://phabricator.kde.org/D20045 To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko Cc: kde-

D20047: Add X-GNOME-UsesNotifications as recognized key

ngraham accepted this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D20047 To: broulik, #frameworks, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19875: [Kactivities-stats] compile without foreach

broulik added a reviewer: ivan. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19875 To: mlaurent, dfaure, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

adridg added a comment. On FreeBSD, `/proc` is not necessarily mounted (it might be a Linuxism). So while I do **have** `/proc`, it's empty because procfs isn't mounted there. If I **do** mount it, then there's the expected list of processes and a curproc symlink. But `/proc/` doesn't contai

D19875: [Kactivities-stats] compile without foreach

mlaurent added a comment. Ping ?:) REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D19875 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

mlaurent added a comment. Ping ?:) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

adridg added a comment. Config: Using QtTest library 5.12.1, Qt 5.12.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 6.0.1 (tags/RELEASE_601/final 335540)) PASS : KProcessListTest::initTestCase() PASS : KProcessListTest::testKProcessInfoConstructionAssignment

D20026: Go up in folder hierachy when in "edit mode"

ngraham added inline comments. INLINE COMMENTS > kurlnavigator.cpp:400 > +while (hasParent) { > +urlList.append(currentDirectory.path()); > +hasParent = (currentDirectory != > QUrl(parentDirectory(currentDirectory.path(; Use `toLocalFile()` instead of `path()`, otherwise

D20041: [balooctl] Reduce nesting level for addOption arguments, cleanup

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20041 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, mic

D20026: Go up in folder hierachy when in "edit mode"

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks, this works great in Dolphin. However it does not work properly in Gwenview; the URL Navigator switches back to breadcrumbs mode every time the Up arrow is pressed. I've

D20026: Go up in folder hierachy when in "edit mode"

ngraham retitled this revision from "Bug 195801 - go up in folder hierachy when in "edit mode"" to "Go up in folder hierachy when in "edit mode"". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20026 To: krutovmikhail, ngraham,

D19779: point readme to the wiki page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:998982a47cbc: point readme to the wiki page (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D19779: point readme to the wiki page

sitter added a comment. I am taking silence as indifference. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19779 To: sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

davidedmundson added subscribers: adridg, vonreth. davidedmundson added a comment. Awesome progress. Thanks ever so much. @vonreth could you test the windows side for us and tell us how to do the unit test? @adridg could you run this on BSD. You should just need to run ./bin/kproce

D20060: [KDynamicJobTracker] Use generated DBus interface

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids doing a blocking introspection call. TEST PLAN Started a

D14598: Keep checking return value from calling browse_stat_path() in SMBSlave::stat() in sync with SMBSlave::listDir()

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. I don't really know this code, but I don't know who does REPOSITORY R320 KIO Extr

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/32/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 26 Mar 2019 05:59:12 + Build duration: 4 hr 10 min and counting JUnit Tests Name: projec

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/53/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 25 Mar 2019 21:02:33 + Build duration: 12 hr and counting JUnit Tests Name:

  1   2   >