apol added a comment.
LGTM, looks like clang-cl will be missing a few arguments though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf, #windows Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns