D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

loh.tar added a comment. Personally I would avoid doxygen style or multiline comments in code and prefer // INLINE COMMENTS > katerenderer.cpp:988 > // ensure minimal height of one pixel to not fall in the div by 0 trap > somewhere > // use font line spacing, this includes the lea

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 25 Feb 2019 04:48:04 + Build duration: 52 min and counting JUnit Tests Name: pro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/18/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 25 Feb 2019 04:48:05 + Build duration: 42 min and counting BUILD ARTIFACTS abi-compati

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/26/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 25 Feb 2019 04:48:05 + Build duration: 23 min and counting BUILD ARTIFACTS abi-compati

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

smithjd added inline comments. INLINE COMMENTS > taglibextractor.cpp:109 > +{ > +if (savedProperties.contains("TITLE")) { > +result->add(Property::Title, > TStringToQString(savedProperties["TITLE"].toString()).trimmed()); This could return early if the property map is empty. > tagl

D18563: Don't create directory tree when a new folder has a '/' in the name

shubham added a comment. @ngraham Any updates? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, kde-f

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. @ngraham Any updates? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17737: [CopyJob] Create clones in btrf/xfs mount

bruns added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, davidedmundson, #frameworks Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D17737: [CopyJob] Create clones in btrf/xfs mount

bruns added a comment. The code looks sane to me, but I have not found time to test it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, davidedmundson, #frameworks Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D17737: [CopyJob] Create clones in btrf/xfs mount

bruns added a comment. Can you update the summary - although CoW and cloning typically come together, they are two different functions (and you can e.g. have CoW disabled for a dir/file, and cloning still works). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To

D17737: [CopyJob] Create clones in btrf/xfs mount

bruns added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, davidedmundson, #frameworks Cc: bruns, kde-frameworks-devel, michaelh, ngraham

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D19287: [ExtractorCollection] Load extractor plugins lazily

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In many cases, only a few plugins are required,

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/46/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Feb 2019 20:18:25 + Build duration: 5 min 54 sec and counting BUILD ARTIFACTS abi

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/40/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Feb 2019 20:18:25 + Build duration: 6 min 24 sec and counting BUILD ARTIFACTS abi

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 54 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/54/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 20:18:25 + Build duration: 1 min 35 sec and counting JUnit Tests N

D19255: WIP: Alternate approach to D19253

romangg added a comment. In D19255#418729 , @davidedmundson wrote: > > Maybe add a TODO comment on merge to the setLogicalSize (that it does not handle the size plus scale change correctly in every case). > > Can you expand on what you mean?

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 39 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Feb 2019 20:08:35 + Build duration: 3 min 43 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 53 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/53/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 20:08:35 + Build duration: 2 min 58 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 45 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/45/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Feb 2019 20:08:35 + Build duration: 3 min 1 sec and counting BUILD ARTIFACTS abi

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

ngraham added a comment. Updating the patch to only do that makes sense, but putting this minimum-value-is-always-zero guard in there too may also make sense just as a safety valve. I'll leave it up to the #plasma folks at this point. REPOSITORY R

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Hi Jos, could you please check again the output of the highlighting indexer? ContextChecker::check: "/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/markdown.xml" Unused contexts: QSet("kconfig-code") The checker says that this context is

D19215: Install DefinitionDownloader header

This revision was automatically updated to reflect the committed changes. Closed by commit R216:df18fada76b2: Install DefinitionDownloader header (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19215?vs=52269&id=52478 REVISI

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

This revision was automatically updated to reflect the committed changes. Closed by commit R216:41f4e86ee522: Add unit test for definitionsForFileName() and definitionsForMimeType() (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19286?vs=52471&id=52477#toc REPOSIT

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH test-definitions-getters REVISION DETAIL https://phabricator.kde.org/D19286 To: dhaumann, cullmann, davschul, vkrause Cc: kwrite-devel, kde-frameworks-devel, domson,

D19215: Install DefinitionDownloader header

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas,

D19285: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R292:6d3e49e94e98: Make it compile without foreach (authored by mlaurent). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19285?vs=52468&id=52473 REVISION DETAI

D19278: Make it compile without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R279:33bd17052e98: Make it compile without foreach (authored by mlaurent). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19278?vs=52452&id=52474 REVISION DETAIL

D19271: Make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R238:3fbec01f6f7c: Make it compiles without foreach (authored by mlaurent). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19271?vs=52435&id=52472 REVISION DETAIL h

D19215: Install DefinitionDownloader header

dhaumann added a comment. I also do not see an issue with this. But I would like to add some background info that may be interesting: Downloading the syntax highlighting files will download all files, and not just the ones that changed etc. This by itself is fine, since it guarantees co

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

dhaumann created this revision. dhaumann added reviewers: cullmann, davschul. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Add unit tests for newly added functions for KF 5.56.

D19285: Make it compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R292 KUnitConversion BRANCH build_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19285 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19278: Make it compile without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R279 ThreadWeaver BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19278 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19271: Make it compiles without foreach

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19271 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-doc-english, gennad, michae

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

thomassc added a comment. I think that this change will fix bug 403470 as well. Suggestion: in updateFontHeight() in katerenderer.cpp, add a comment saying that the line height needs to match that which is used by Qt, since Qt may handle some parts of the drawing, e.g. selection backgro

D19285: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R292 KUnitConversion BRANCH build_without_

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY using a better height and removing the overpainting stuff TEST

D19255: WIP: Alternate approach to D19253

davidedmundson added a comment. > Maybe add a TODO comment on merge to the setLogicalSize (that it does not handle the size plus scale change correctly in every case). Can you expand on what you mean? REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.

D19168: Fix crash in Dolphin when dropping trashed file in trash

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix_crash_when_dropping_trashed_file_in_trash (branched from master) REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc:

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas added a comment. @dfaure - do you have any other comments for this commit? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19035: Help build on Windows with usage of CMake Targets

cullmann commandeered this revision. cullmann edited reviewers, added: dantti; removed: cullmann. cullmann added a comment. > I will abandon it. I compile syntax-highlighting btw. nightly, too, in the AbsInt compile farm on Windows (MSVC) and macOS (xcode toolchain)

D19035: Help build on Windows with usage of CMake Targets

cullmann abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19035 To: cullmann, #framework_syntax_highlighting, dhaumann, vkrause, dantti Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8fb410574b14: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https:/

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given the docs explicitly state one shall use the new enum value, I think this should go in. REPOSITORY R39 KTextEditor BRANCH syntax-hl (branched from master) REVISION DETAIL h

D18734: Update octave.xml to Octave 4.2.0

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c27d13d75155: Update octave.xml to Octave 4.2.0 (authored by sirgienko, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18734?vs=

D19163: Make it possible to show all spaces in the document

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0a9aeb183314: Make it possible to show all spaces in the document (authored by apol, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?

D19163: Make it possible to show all spaces in the document

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is ok now, thanks for the nifty feature. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate, cullmann Cc: c

D18734: Update octave.xml to Octave 4.2.0

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. But beside the stuff with the xcvxv.xcvc stuff, I think you can commit this already as a first step to have a nicer highlighting, nice to see all hard coded colors gone! REPOSITORY R

D18734: Update octave.xml to Octave 4.2.0

cullmann added a comment. For the . stuff in keywords, have you tried to specify some style stuff? INLINE COMMENTS > sirgienko wrote in octave.xml:2745 > Could one word (`end`) be in several region? > Because, in Octave, you could end `if` statement by `endif` or just `end`. > In t

D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP

This revision was automatically updated to reflect the committed changes. Closed by commit R216:df1afdbedcbf: Improve highlighting of TypeScript (and React) and add more tests for PHP (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE h

D19215: Install DefinitionDownloader header

cullmann added a comment. I would have no issues with this if Volker is ok, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraha

D19278: Make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R279 ThreadWeaver BRANCH compile_without_f

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

benjaminrobin added a comment. In D19256#418577 , @ngraham wrote: > Feels like we should close this as well as the bug report ... I am agree with you, but this patch still fix 2 very minor issues : - `resizeFrame(QSize(` was used inst

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

This revision was automatically updated to reflect the committed changes. Closed by commit R824:a2ebf9dd3b51: Skip base64 encoding of QDataStream, avoid temporary QByteArray (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19202?vs=522

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

This revision was automatically updated to reflect the committed changes. Closed by commit R824:0c782040b212: Let tests use the baloo_filemetadata_temp_extractor from the build dir (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19268

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D19202 To: bruns, #frameworks, #baloo, astippich, ngraham Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Great catch! REPOSITORY R824 Baloo Widgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D19268 To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko Cc: domson,

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19256 To: benjaminrobin, #plasma Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

ngraham added a comment. Why is this number negative though? That seems wrong. The bug report seems to indicate that Qt is returning a garbage value: https://bugreports.qt.io/browse/QTBUG-73691 There's even a patch: https://codereview.qt-project.org/#/c/254226/ Feels like we should

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/36/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 15:47:32 + Build duration: 7 min 0 sec and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/35/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 15:38:27 + Build duration: 6 min 51 sec and counting JUnit Tests Name: projectroo

D19103: Middle-elide very long filenames in error strings

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d996ee0a4453: Middle-elide very long filenames in error strings (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19103?vs=51931&id=52446 REVISION

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 34 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Feb 2019 14:52:27 + Build duration: 6 min 18 sec and counting BUILD ARTIFACTS abi

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 142 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/142/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 24 Feb 2019 14:52:27 + Build duration: 7 min 4 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 48 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/48/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 14:52:27 + Build duration: 1 min 57 sec and counting JUnit Tests N

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 40 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/40/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Feb 2019 14:52:27 + Build duration: 2 min 30 sec and counting BUILD ARTIFACTS abi

D19263: Add more highlighting for nested languages in markdown.

vandenoever added a comment. done REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D18734: Update octave.xml to Octave 4.2.0

sirgienko updated this revision to Diff 52442. sirgienko added a comment. Remove outdate Octave tests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18734?vs=52441&id=52442 BRANCH octave REVISION DETAIL https://phabricator.kde.org/D18734

D18734: Update octave.xml to Octave 4.2.0

sirgienko updated this revision to Diff 52441. sirgienko added a comment. Add tests for Octave highlighting REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18734?vs=50963&id=52441 BRANCH octave REVISION DETAIL https://phabricator.kde.org/D1

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Well, if it's fixed by adding the missing reference update then please do so. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-framewo

D19255: WIP: Alternate approach to D19253

romangg added a comment. Also CCBUG: 400987 REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D19255 To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19255: WIP: Alternate approach to D19253

romangg added a comment. Maybe add a TODO comment on merge to the setLogicalSize (that it does not handle the size plus scale change correctly in every case). REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D19255 To: davidedmundson, #kwin, romangg

D19255: WIP: Alternate approach to D19253

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I just tested it and it works. As you said in D19253 has same caveat as I pointed out not being in sync with wl_output::done event in case resolution

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/33/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Feb 2019 11:38:45 + Build duration: 2 min 20 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/39/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Feb 2019 11:38:45 + Build duration: 2 min 29 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/47/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 11:38:45 + Build duration: 1 min 41 sec and counting JUnit Tests

D19271: Make it compiles without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach REPOSITORY R238 KDocTools

D19103: Middle-elide very long filenames in error strings

elvisangelaccio accepted this revision. elvisangelaccio added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > job_error.cpp:30 > > +static const int maxFilePathLength = 80; > + Maybe it's worth using the `s_` prefix here. REPOSITORY R241 KIO BRANCH squ

D19258: Do not print indent lines

This revision was automatically updated to reflect the committed changes. Closed by commit R39:b11afe5a1438: Do not print indent lines (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19258?vs=52389&id=52434#toc REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDAT

D19263: Add more highlighting for nested languages in markdown.

vandenoever added a comment. I see that one test fails after committing this patch. The example output was modified by `/autotests/update-reference-data.sh` but I did not submit it. I thought it was not related to the markdown change. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 140 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/140/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 24 Feb 2019 09:21:54 + Build duration: 22 min and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 32 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/32/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 24 Feb 2019 09:21:54 + Build duration: 10 min and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 38 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/38/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 24 Feb 2019 09:21:54 + Build duration: 2 min 25 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 46 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/46/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 24 Feb 2019 09:21:54 + Build duration: 1 min 38 sec and counting JUnit Tests

D19263: Add more highlighting for nested languages in markdown.

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bbb5188d9e12: Add more highlighting for nested languages in markdown. (authored by vandenoever). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19263?vs

D19263: Add more highlighting for nested languages in markdown.

vandenoever updated this revision to Diff 52430. vandenoever added a comment. Increased kateversion to 5.0. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19263?vs=52410&id=52430 BRANCH nested (branched from master) REVISION DETAIL https:/

D19251: Make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R243:ff2240350387: Make it compiles without foreach (authored by mlaurent). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19251?vs=52377&id=52426 REVISION DETAIL ht

D19251: Make it compiles without foreach

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, no, you're right. I remembered that there was a problem with function calls (rvalues) but that problem is not what I thought, it's the fact that one can't write qAsConst(myFunc())