D18630: Fix warning

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18630 To: apol, #plasma, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18638: Avoid using trimmed method

mlaurent added a reviewer: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18638 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18638: Avoid using trimmed method

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY We don't want to use trimmed() but we want to avoid to call sonnet code for empty text REPOSITORY R246 Sonnet BRA

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. ... though I'm not sure whether that's a bug. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham Cc: zzag, davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. Well, there are still issues with corners F6580225: Screenshot_20190131_151157.png (both the blur and the background contrast effect are disabled) REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DET

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works as intended for me on both Breeze and Breeze Dark and looks fantastic. Sooo... is there anything left to do here, or shall we land it? REPOSITORY R242 Plasma Framework (Libra

D18450: Add extractor for AppImage files

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Just noticed, you never use the AppDataParser.name(). Is that intentional? Otherwise looks good, but you may want to wait for someone more experienced than me. REPOSITORY R286 KFi

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

ngraham added a comment. Can you provide your email address so we can land this patch for you with proper authorship information? Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, antho

D18533: Improve the Notfication Bell Icon by using the KAlarm design

ngraham added a comment. Any update/progress on this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18533 To: trickyricky26, #vdg Cc: ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18610: Introduce KF5AuthCore

aacid updated this revision to Diff 50622. aacid added a comment. Only have one debug category for now REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18610?vs=50563&id=50622 BRANCH arcpatch-D18610 REVISION DETAIL https://phabricator.kde.org/D18610 AFFE

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#402952 , @astippich wrote: > got it up and running! Yay :) Thanks for keeping trying. > One question: Why is the extra desktop file parser necessary? Shouldn't all required information be availabl

D18237: Fix ResultIterator

aacid added a comment. In D18237#402918 , @bruns wrote: > Oh, and you forgot to undelete the operator=, so this is still BIC ... No, that is not BIC REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid,

D18450: Add extractor for AppImage files

astippich added a comment. got it up and running! One question: Why is the extra desktop file parser necessary? Shouldn't all required information be available from the app data parser? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18450 To: kossebau, #bal

D16643: Correct the accept flag of the event object on DragMove

fvogt added a comment. I tried to understand what this change does both by trying to reproduce the issue and reading Qt code. Here the symptom was more drags not getting accepted at all than flipping back and forth, but this patch fixes that as well. What might cause confusion is that

D18237: Fix ResultIterator

bruns added a comment. Oh, and you forgot to undelete the operator=, so this is still BIC ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoo

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. > So according to you, this line is useful ? from my point of view, it's needless and just looks like a syntax error. Yes, it shows which compiler is being queried and for what. The line is going to be there anyway because CMake's Check*CompilerFlag macros don't

D18237: Fix ResultIterator

bruns added a comment. The correct way to **fix** this is by allocating a new ResultIteratorPrivate and "copying" the QStringList. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo, ash

D16894: [ECM] use a macro to add compiler flags conditionally

cgiboudeaux added a comment. In D16894#402901 , @rjvbb wrote: > > Forget that. The syntax is confusing, please remove this HASFLAG > > That I'm not going to do. The goal is to both to have useful feedback like below, and to avoid caching issu

D18601: Rewrite taglib writer to use property interface

bruns added a comment. I think this becomes better structured when you: 1. Create one function per file type, with parameters (Taglib::Filestream, KFM::PropertyMap) 2. From this function, call a generic `updateProperties(oldProperties, newProperties) -> mergedProperties` 3. Call the

D18604: Implement support for writing rating information for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:409 > +QTest::addRow("mp3_0") > +<< QStringLiteral("mp3") > +<< QStringLiteral("audio/mpeg3") What are the differences between the various mp3 test cases? > taglibwriter.cpp:153 > +//map the rating v

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. > Forget that. The syntax is confusing, please remove this HASFLAG That I'm not going to do. The goal is to both to have useful feedback like below, and to avoid caching issues that would cause on the first query to be performed (if you were to use a single result

D18601: Rewrite taglib writer to use property interface

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:123 > > -TagLib::Tag* tags = file.tag(); > +TagLib::File *file = openFile(&stream, mimeType); > +if (!file) { use a smart pointer (unique_ptr, QScopedPtr) here, and get rid of the delete below. REPOSITORY R286 KFil

D18163: Set the color scheme to Printing for Print Preview

dhaumann accepted this revision. dhaumann added a comment. Now this looks good to me. @mwolff: you also agree? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff Cc: kwrite-devel, kde-frameworks-deve

D14467: Auth Support: Drop privileges if target is not owned by root

mgerstner added a comment. chinmoyr asked me to review this patch since I was involved with A CVE in similar code in kate / ktexteditor a while ago. Back then the logic was special purpose to replace a file in the file system with content provided via D-Bus. This here is a way more gener

D18603: Implement more tags for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:276 > +QFAIL("This mime type is not supported by the extractor. Likely a > newer KDE Frameworks version is required."); > +KFileMetaData::Extractor* ex = extractorList.first(); > +KFileMetaData::SimpleExtractionR

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 31 Jan 2019 16:06:05 + Build duration: 19 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 31 Jan 2019 15:45:42 + Build duration: 20 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 31 Jan 2019 15:54:45 + Build duration: 9 min 25 sec and counting BUILD ARTIFACTS abi-compatibil

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 31 Jan 2019 15:45:42 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibility-res

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/9/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 31 Jan 2019 15:45:42 + Build duration: 9 min 2 sec and counting BUILD ARTIFACTS abi-compatibili

D18628: [server] Generate correct touch ids

This revision was automatically updated to reflect the committed changes. Closed by commit R127:e167526d0bdb: [server] Generate correct touch ids (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18628?vs=50599&id=50606 REVISION DETAIL htt

D18421: [autotests] Stabilize testWindowmanagement

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:e6aa2c847df5: [autotests] Stabilize testWindowmanagement (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE

D18630: Fix warning

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY org/kde/plasma/components.3/TextArea.qml:54:5: Unable to assign [undefined] to QQmlComponent*

D18628: [server] Generate correct touch ids

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fix-test-wayland-set REVISION DETAIL https://phabricator.kde.org/D18628 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

cgiboudeaux added inline comments. INLINE COMMENTS > ECMAddCompilerFlag.cmake:108 > +check_cxx_compiler_flag(${flag} ${HASFLAG}) > +if({${HASFLAG}}) > +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${flag}" > PARENT_SCOPE) Forget that. The syntax is confusing,

D18421: [autotests] Stabilize testWindowmanagement

zzag added a comment. If there are no objections, I'm going to land this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18421 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

cgiboudeaux added inline comments. INLINE COMMENTS > ECMAddCompilerFlag.cmake:108 > +check_cxx_compiler_flag(${flag} ${HASFLAG}) > +if({${HASFLAG}}) > +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${flag}" > PARENT_SCOPE) if(HASFLAG) you're testing the result

D18628: [server] Generate correct touch ids

zzag added a comment. I don't own any device with touchscreen. Could someone please test this patch? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18628 To: zzag, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18628: [server] Generate correct touch ids

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY testWaylandSeat fails because the seat interface generates incorrect id for the second touch.

D16894: [ECM] use a macro to add compiler flags conditionally

cgiboudeaux added a comment. In D16894#402701 , @rjvbb wrote: > > There are tests for other ECM modules in the **tests** subdir. > > That's not the expected answer, so let me rephrase: which existing test can I clone and adapt (which is abo

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#402668 , @zzag wrote: > Shot in the dark: maybe purge cache? No change unfortunately. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ng

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. > There are tests for other ECM modules in the **tests** subdir. That's not the expected answer, so let me rephrase: which existing test can I clone and adapt (which is about the only thing I know how to do in this domain)? I'm going to need a hand here if no

D16894: [ECM] use a macro to add compiler flags conditionally

cgiboudeaux added a comment. In D16894#402364 , @rjvbb wrote: > > Christophe: can you please be more specific why sphinx fails? Also, is there an existing unittest I can clone and adapt? There are tests for other ECM modules in

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system, kfunk Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb updated this revision to Diff 50589. rjvbb marked an inline comment as done. rjvbb added a comment. Updated as requested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16894?vs=50451&id=50589 REVISION DETAIL https://phabricator.kde.org/D16894 AFFECTED FILES docs/module/E

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb marked 9 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > cgiboudeaux wrote in ECMAddCompilerFlag.cmake:1-25 > Shall be moved after the module documentation I'm guessing you meant "Please move [...]" and not that this would somehow happen automagically(?) REPOSITOR

T3689: Add abi compliance checker to CI

danders added a comment. I get ABI error on use of QPair and QSet in kdiagram: https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/8/artifact/compat_reports/KGantt_compat_report.html#Type_Binary_Problems_Medium Afaics these lines have not been changed since last releas

D18163: Set the color scheme to Printing for Print Preview

ahmadsamir marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18163 To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18163: Set the color scheme to Printing for Print Preview

ahmadsamir updated this revision to Diff 50588. ahmadsamir retitled this revision from "Set the color scheme to Printing when print preview'ing" to "Set the color scheme to Printing for Print Preview". ahmadsamir added a comment. Use a setter REPOSITORY R39 KTextEditor CHANGES SINCE LAST U

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

zzag added a comment. In D18545#402636 , @ngraham wrote: > It there indeed a bug in the KWin effect somewhere? I don't think so. Both the blur and the background contrast effect operate on regions. Rounded corners are approximated by a bu

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, GB_2, ragr