bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:123
>  
> -    TagLib::Tag* tags = file.tag();
> +    TagLib::File *file = openFile(&stream, mimeType);
> +    if (!file) {

use a smart pointer (unique_ptr, QScopedPtr) here, and get rid of the delete 
below.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Reply via email to