D18329: Remove the AndroidX support library dependency

apol added subscribers: nicolasfella, apol. apol added a comment. LGTM, @nicolasfella? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D18329 To: vkrause Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D18302: Add Android notification channel support

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18302 To: vkrause, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18299: ComboBox: fix default delegate

apol added inline comments. INLINE COMMENTS > broulik wrote in ComboBox.qml:58 > Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a > `ComboBox` is recommended as: > "This ensures that the interaction works as expected, and the popup will > automatically close when app

Re: KDE file dialog column resize no longer possible?

On Friday January 18 2019 14:11:38 Nate Graham wrote: > Yeah, go ahead and put it up on Phab! > > Nate Okidoki. Willdo tomorow, I'm still tweaking it a bit. R.

Re: KDE file dialog column resize no longer possible?

Yeah, go ahead and put it up on Phab! Nate On 1/18/19 1:56 PM, René J.V. Bertin wrote: Hi, Assistance would be appreciated. :-) I've whipped up something, a bit sneaky but it does more or less what I had in mind. - the QEvent::Polish handler connects to the sectionResized signal - this

Re: KDE file dialog column resize no longer possible?

Hi, >Assistance would be appreciated. :-) I've whipped up something, a bit sneaky but it does more or less what I had in mind. - the QEvent::Polish handler connects to the sectionResized signal - this sectionResized slot will check if the QTreeView contains a positive number of elements, if th

D18205: Test empty and zero gps data

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH gps_tests REVISION DETAIL https://phabricator.kde.org/D18205 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, br

D17977: Improve reliability and semantic correctless of dupe test

ngraham abandoned this revision. ngraham added a comment. Since this is essentially a workaround for doing in-source builds, the obvious superior course of action is for me to the the work to set up some basic infrastructure for painless out-of-source builds. :) REPOSITORY R266 Breeze Icon

Re: KDE file dialog column resize no longer possible?

OK, bummer, apparently Qt didn't think it a good idea to add a "size automatically but allow the user to change afterwards) :-( There is QHeaderView::sectionSizeFromContents() but using that may give the same performance issue as your reverted fix (it's protected so you'd need to use a wrapped

D18369: Create tel: links for phone numbers

vkrause updated this revision to Diff 49836. vkrause added a comment. Handle empty tel: URLs, as found in the review email. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18369?vs=49834&id=49836 BRANCH master REVISION DETAIL https://phabricator.kd

D18369: Create tel: links for phone numbers

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KDE Connect can handle tel: URLs and trigger a call, so this enables to directly call phone numbers found e.g. in emai

D17977: Improve reliability and semantic correctless of dupe test

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I found an issue. With the patch, the dupe test does not detect 2 identical files with the same name in different categories. It is able to detect that issue from How to

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. @loh.tar: I'll think that over, thanks for the pointers :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18317 To: ahmadsamir, sandsmark, loh.tar Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D17977: Improve reliability and semantic correctless of dupe test

rizzitello added a comment. Seams to function correctly. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17977 To: ngraham, #breeze, ndavis, GB_2 Cc: rizzitello, tcanabrava, kde-frameworks-devel, michaelh, ngraham, bruns

D17977: Improve reliability and semantic correctless of dupe test

tcanabrava added inline comments. INLINE COMMENTS > dupetest.cpp:87-88 > } > for (auto dir : ICON_DIRS) { > -dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + > dir); > +for (auto type : ICON_TYPES) { > +dupesForDirectory(PROJE

Re: KDE file dialog column resize no longer possible?

OK, bummer, apparently Qt didn't think it a good idea to add a "size automatically but allow the user to change afterwards) :-( There is QHeaderView::sectionSizeFromContents() but using that may give the same performance issue as your reverted fix (it's protected so you'd need to use a wrapped

Re: KDE file dialog column resize no longer possible?

Yes, this was an intentional change: https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5 Check out the listed bugs that it fixed! However I understand that it did cause some fallout: https://bugs.kde.org/show_bug.cgi?id=401506 I tried to fix that in https://cgit.kd

Re: KDE file dialog column resize no longer possible?

Yes, this was an intentional change: https://cgit.kde.org/kio.git/commit/?id=e504bc1fd56412ee7e9748a0dfafa537977ec1b5 Check out the listed bugs that it fixed! However I understand that it did cause some fallout: https://bugs.kde.org/show_bug.cgi?id=401506 I tried to fix that in https://cgit.kd

D18345: Fix python binding generation for classes with deleted copy constructors

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a2a404f9f924: Fix python binding generation for classes with deleted copy constructors (authored by aacid). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.or

Re: KDE file dialog column resize no longer possible?

Hmmm, I never see a scrollbar. Maybe the easiest workaround would be a mode where the user can disable all automatic sizing (possibly after getting a good initial setting), and then use the user's size choices? That's the behaviour you get on Mac (and MSWin) and something I more or less expect

D18365: Add a flag to keep a window on top

davidedmundson retitled this revision from "Add flag to keep a window on top." to "Add a flag to keep a window on top". davidedmundson edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18365 To: davidedmundson, #kwin Cc: zzag, kde-fra

D18365: Add flag to keep a window on top.

zzag added a comment. Looks good to me. (please remove period from the title) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18365 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE file dialog column resize no longer possible?

Kai Uwe Broulik wrote: > Yes, to ensure sane default sizing of the columns, especially as you > resize the dialog, which were often too narrow or too wide or otherwise > unfitting. Hmm, where? Could have been made optional as they were indeed often not the appropriate size and while I haven't se

D18365: Add flag to keep a window on top.

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Intended usage is just for the calendar/system tray "keep on top" p

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Just my thoughts: - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. - To set the dict to the system locale seems to me the less smartest trick. If everybody want such "auto-

D18317: Don't fail if defaultLanguage dictionary can't be loaded

ahmadsamir added a comment. In D18317#395530 , @pino wrote: > In D18317#395513 , @pino wrote: > > > This makes a "core" library grow a dependency on widgets -- not really a good idea, considering the

D17691: Add rows info to the plasma virtual desktop protocol

zzag added a comment. David's comment is still not done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

fvogt updated this revision to Diff 49806. fvogt marked 2 inline comments as done. fvogt added a comment. Add some style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=49802&id=49806 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D17122: Add option to use wl_display_add_socket_auto

fvogt added a comment. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/8/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 Jan 2019 11:34:42 + Build duration: 15 min and counting BUILD ARTIFACTS abi-compatib

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 18 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/18/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 18 Jan 2019 11:34:42 + Build duration: 3 min 28 sec and counting BUILD ARTIFACTS abi-c

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/12/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 18 Jan 2019 11:34:42 + Build duration: 1 min 51 sec and counting JUnit Tests Nam

D18356: [Plasma Theme] Use new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8c5099140751: [Plasma Theme] Use new connect syntax (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18356?vs=49804&id=49805

D18356: [Plasma Theme] Use new connect syntax

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18356 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18356: [Plasma Theme] Use new connect syntax

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Saves some cycles TEST PLAN Saves like 0.6ms on startup here, given the amount of `

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/17/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 18 Jan 2019 11:25:02 + Build duration: 7 min 8 sec and counting CONSOLE OUTPUT [...trun

D18149: Share Plasma::Theme instances between multiple ColorScope

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eac69e04690b: Share Plasma::Theme instances between multiple ColorScope (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D181

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/7/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 18 Jan 2019 11:25:02 + Build duration: 4 min 39 sec and counting BUILD ARTIFACTS abi-co

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 18 Jan 2019 11:25:02 + Build duration: 4 min 9 sec and counting JUnit Tests Name

D18149: Share Plasma::Theme instances between multiple ColorScope

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18149 To: broulik, #plasma, mart Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

romangg added inline comments. INLINE COMMENTS > display.cpp:87 > +bool running = false, > + automaticSocketNaming = false; > QList outputs; bool running = false; bool automaticSocketNaming = false; REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17

D17122: Add option to use wl_display_add_socket_auto

zzag added inline comments. INLINE COMMENTS > display.cpp:86-87 > QString socketName = QStringLiteral("wayland-0"); > -bool running = false; > +bool running = false, > + automaticSocketNaming = false; > QList outputs; Style: https://techbase.kde.org/Policies/Frameworks

D18345: Fix python binding generation for classes with deleted copy constructors

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. As far as I understand the logic of the whole thing, it looks sane. At some point we ought to find a way to properly test that the generated code... REPOSITORY R240 Extra CMake Mod

D17122: Add option to use wl_display_add_socket_auto

fvogt retitled this revision from "RFC: Use wl_display_add_socket_auto by default" to "Add option to use wl_display_add_socket_auto". fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt updated this revision to Diff 49802. fvogt added a comment. Use a new bool instead. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17122?vs=46075&id=49802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17122 AFFECTED FILES autote

Re: KDE file dialog column resize no longer possible?

Has resizing support been turned off in KF5 maybe, and if so, where and why? Yes, to ensure sane default sizing of the columns, especially as you resize the dialog, which were often too narrow or too wide or otherwise unfitting. Cheers Kai Uwe

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. In D17122#395762 , @romangg wrote: > In D17122#395745 , @fvogt wrote: > > > > Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket

KDE file dialog column resize no longer possible?

Hi, Sorry for cross-posting (initially), I'm not certain which list is the most appropriate. It's often been tricky to trigger column resize mode in the KDE file dialog (when in one of the detailed view modes) but I realise I haven't been able to do this at all for a little while now. I just c

D17122: RFC: Use wl_display_add_socket_auto by default

romangg added a comment. In D17122#395745 , @fvogt wrote: > > Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behav

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. > Hmm, maybe then add another setter setAutomaticSocketNaming instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior. That would need changes in KWin though so Plasma 5.16 only :-( REPOSITORY

D17122: RFC: Use wl_display_add_socket_auto by default

romangg added a comment. In D17122#395705 , @fvogt wrote: > In D17122#395704 , @romangg wrote: > > > In D17122#395696 , @fvogt wrote: > > > > > In D171

D18288: Make the clock svg's shadows more logically correct and visually appropriate

shubham added a dependent revision: D17751: Add shadow to Hour's hand. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18288 To: ngraham, #vdg, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

cgiboudeaux added a reviewer: lbeltrame. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18345 To: aacid, lbeltrame Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17122: RFC: Use wl_display_add_socket_auto by default

fvogt added a comment. In D17122#395704 , @romangg wrote: > In D17122#395696 , @fvogt wrote: > > > In D17122#395537 , @romangg wrote: > > > > > I don't

D17122: RFC: Use wl_display_add_socket_auto by default

romangg added a comment. In D17122#395696 , @fvogt wrote: > In D17122#395537 , @romangg wrote: > > > I don't think we need a second variable effectiveSocketName. Just test if socketName is empty. I