romangg added a comment.
In D17122#395705 <https://phabricator.kde.org/D17122#395705>, @fvogt wrote: > In D17122#395704 <https://phabricator.kde.org/D17122#395704>, @romangg wrote: > > > In D17122#395696 <https://phabricator.kde.org/D17122#395696>, @fvogt wrote: > > > > > In D17122#395537 <https://phabricator.kde.org/D17122#395537>, @romangg wrote: > > > > > > > According to description some autotest fails. Which one exactly? > > > > > > > > > testSocketName as the default value of socketName changed. > > > > > > FAIL! : TestWaylandServerDisplay::testSocketName() Compared values are not the same > > > Actual (display.socketName()) : "" > > > Expected (QStringLiteral("wayland-0")): "wayland-0" > > > Loc: [/home/fabian/kderepos/kwayland/autotests/server/test_display.cpp(54)] > > > > > > > > > Is there an argument against just checking on empty string at this location? Since the socket name is not yet set in line 54, there shouldn't be one. > > > The argument is that the default value changed, which is technically an ABI break - that's why this is an RFC. If you say that it's fine, I'll do the change and remove the RFC. Hmm, maybe then add another setter `setAutomaticSocketNaming` instead to switch to automatic socket name query instead. When it's not called before start it would fall back to old behavior. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17122 To: fvogt, #kwin, #plasma Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
