D17817: Build without D-Bus on Android

vkrause added a comment. In D17817#383354 , @dhaumann wrote: > +1, although it will likely break quickly since this branch is not tested via CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting branches that were added for standal

D17623: Add YaST and new preference icons

ndavis added a comment. > (again, not taking size constraints into consideration) This is what is wrong with the test. I've set the size constraints for apps/32 to not overlap with apps/48, so there should be no problem. apps/48 does overlap with apps/64, but apps/64 isn't that important

D17623: Add YaST and new preference icons

ngraham added a subscriber: sitter. ngraham added a comment. @sitter added the test in 7d01f3d8b5c0f2c9dc6014e8e04ba5701804fec2 . Maybe he can shed some light on the best course of action here. Pertinent quote fro

D17623: Add YaST and new preference icons

ndavis added a comment. OK, so it seems I can't have multiple scalable directories with different versions of the same icon when the directories have the Application context. This test is such a pain in the ass. I know most tests are there for a good reason, but this one has only ever gotten

D17623: Add YaST and new preference icons

ngraham added a comment. Look in `Testing/Temporary/LastTest.log` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#383392 , @ngraham wrote: > With the latest change, this now fails the `scalable` test. How do I see what tests a patch will pass or fail? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabrica

D17623: Add YaST and new preference icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. With the latest change, this now fails the `scalable` test. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik

D17623: Add YaST and new preference icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48332. ndavis added a comment. Add most recent changes to breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48331&id=48332 BRANCH yast-icons (branched from master) REVISION DETAIL https://pha

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48331. ndavis added a comment. fix yast-installation REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48329&id=48331 BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/

D17692: Add a proper python-bytecode icon, use consistent color in python icons

ngraham added a comment. I've fixed the symlink issue in master, so now both `application-x-python-bytecode` and `text-x-python3` are both symlinks pointing to `text-x-python` You'll need to re-base this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17

D17623: Add YaST and new preference icons

ndavis added a comment. F6513963: Screenshot_20181228_223854.png I'm guessing I'll need to either do manual edits in the XML or recreate them from scratch. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL

D17623: Add YaST and new preference icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. How strange, you're right! I never noticed that. Oh well, material for another patch I suppose... REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETA

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#383376 , @ngraham wrote: > Outstanding. Only one final issue that I can see: the long shadow cast by the arrow in `yast-installation` doesn't fade out; it just continues off the rest of the icon: > > F651396

D17623: Add YaST and new preference icons

ngraham added a comment. Outstanding. Only one final issue that I can see: the long shadow cast by the arrow in `yast-installation` doesn't fade out; it just continues off the rest of the icon: F6513961: Screenshot_20181228_203322.png REPOSITORY

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48329. ndavis added a comment. Shift servers in dhcp and dns server icons to the right a bit and fix the shadow of the services icon REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48297&id=48329 BRANCH

D17651: Escape bytes that are larger than or equal to 127 in config files

aacid added a comment. In D17651#383320 , @vandenoever wrote > Can you give some more details? I see no problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/ You need to look harder ;) Those yellow bubbles mean tests are

D17623: Add YaST and new preference icons

hellcp added a comment. That happens in Inkscape and other renderers with uneven (133%, 146% etc) magnification. When rendering also sometimes you will get a darker border when there is something dark behind an object. I used that to my advantage with new YaST Package Management icons F

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/99/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 28 Dec 2018 23:57:03 + Build duration: 4 min 38 sec and counting JUnit Tests Name: (root) Fa

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 28 Dec 2018 23:57:03 + Build duration: 1 min 35 sec and counting JUnit Tests Name: (root)

D17817: Build without D-Bus on Android

dhaumann added a comment. +1, although it will likely break quickly since this branch is not tested via CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting branches that were added for standalone deployment. Another +1 would be appreciated. REPOSITORY R289 KNotificatio

D17310: Improve Kile icon with LaTeX font

ngraham added a comment. #kile folks, are you good with this now? If we don't hear back in a week or two, we'll have to assume yes. :) REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricat

D17623: Add YaST and new preference icons

ndavis added a comment. Here's the same icon in cuttlefish, except the line you saw on the bottom doesn't show up for me: F6513637: Screenshot_20181228_180802.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#383325 , @ngraham wrote: > A few more little nitpicks: > > - `preferences-system-services` still has a shadow over the background rather than another part of itself: F6513586: shadow.png

D17623: Add YaST and new preference icons

ngraham added a comment. A few more little nitpicks: - `preferences-system-services` still has a shadow over the background rather than another part of itself: F6513586: shadow.png - All the the `preferences-system-network-server-*` icons have a l

D17623: Add YaST and new preference icons

ngraham added a comment. `preferences/32/preferences-system-network-dsl.svg` and `preferences/32/preferences-system-network-ethernet.svg` are now very slightly different from the device icon versions. :) They have a bottom shadow, while the new device versions you just commitetd do not. Is t

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Can you give some more details? I see problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/ Since my commits there was one more patch, but it's not related. https://cgit.kde.org/kconfig.git/commit/?id=d90a37b5a1d892d7b0ff7cc3b56c8a6e8c4bfe1a

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 28 Dec 2018 21:51:58 + Build duration: 1 min 24 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 98 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/98/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 28 Dec 2018 21:51:58 + Build duration: 1 min 39 sec and counting JUnit Tests Name: (root) Fa

D17845: Add device icons for RJ11 and RJ45 ports

This revision was automatically updated to reflect the committed changes. Closed by commit R266:abed651411b9: Add device icons for RJ11 and RJ45 ports (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17845?vs=48321&id=48322 REVISION D

D17845: Add device icons for RJ11 and RJ45 ports

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! REPOSITORY R266 Breeze Icons BRANCH network-jacks (branched from master) REVISION DETAIL https://phabricator.kde.org/D17845 To: ndavis, #vdg, #breeze, ngraham Cc: ngraham,

D17845: Add device icons for RJ11 and RJ45 ports

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17845 To: ndavis, #vdg, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

ndavis updated this revision to Diff 48321. ndavis added a comment. Update style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17845?vs=48316&id=48321 BRANCH network-jacks (branched from master) REVISION DETAIL https://phabricator.kde.org/D17845

D17623: Add YaST and new preference icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17623 To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham Cc: fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17845: Add device icons for RJ11 and RJ45 ports

ngraham added a comment. In D17845#383277 , @ndavis wrote: > You mean like this? > F6513525: Screenshot_20181228_160335.png Yeah, I like that much better! Making the female version more femal

D17845: Add device icons for RJ11 and RJ45 ports

ndavis added a comment. In D17845#383266 , @ngraham wrote: > I love the full-color versions! For the monochrome ones, what do you think about putting them within a rounded rectangular frame like the full-color versions do? Right now the "femalen

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17845: Add device icons for RJ11 and RJ45 ports

ngraham added a comment. I love the full-color versions! For the monochrome ones, what do you think about putting them within a rounded rectangular frame like the full-color versions do? Right now the "femaleness" of the monochrome icons is not communicated as well as I think it could be; to

D17845: Add device icons for RJ11 and RJ45 ports

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17845 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17845: Add device icons for RJ11 and RJ45 ports

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17845 To: ndavis, #vdg, #breeze Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17845: Add device icons for RJ11 and RJ45 ports

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH network-jacks (branched from master) REVISION DETAIL https:/

D17167: Provide a method of assigning custom default icons for non-XDG dirs

ngraham added a comment. In D17167#371906 , @cfeck wrote: > But why hardcode the list in the source, instead of reading it from a file/resource that the user could expand? I don't see the benefit of putting the data into a configuration f

D17797: Include applets/22

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. This needs to be rebased REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17797 To: nicolasfella, #breeze, ndavis Cc: ndavis, kde-frameworks-devel, t

D17617: Display error instead of silently failing when asked to create folder that already exists

ngraham added a comment. @elvisangelaccio? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin, elvisangelaccio, dfaure Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

knauss added a revision: D17843: python3.6 has no capture_output paramenter for subprocess.run.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17651: Escape bytes that are larger than or equal to 127 in config files

aacid added a comment. You broke the tests with this change. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48297. ndavis added a comment. Change apps/32 to scalable and add apps/64 in index.theme REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17623?vs=48277&id=48297 BRANCH yast-icons (branched from master) REVISION D

D17623: Add YaST and new preference icons

ndavis added a comment. In D17623#382989 , @ngraham wrote: > In D17623#382912 , @ndavis wrote: > > > We still haven't figured out where to put all of the `yast-*` icons. Most of them are now symlinks

T3689: Add abi compliance checker to CI

knauss added a revision: D17837: Switch to the new syntax (spaces -> tabs).. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

knauss added a revision: D17836: add clang/7.0.0/include to make abi-compliance-checker happy again.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48285. loh.tar retitled this revision from "[WIP] Review KateStatusBar (based on D17729)" to "[WIP] Review KateStatusBar ". loh.tar edited the summary of this revision. loh.tar added a comment. - Introduce StatusBarButton - Don't gray out m_modifiedLabel

D17816: Initial support for xattrs on kio copy/move

cochise added a comment. There is one use case (copy of dirs with rename, due name conflict) where the patches not work, and I can't test on *BSD or Mac. The first problem says I would need to add a very similar snippet in a third place, i trying to find right now, (any help from someone

D17623: Add YaST and new preference icons

ngraham added a comment. In D17623#382912 , @ndavis wrote: > We still haven't figured out where to put all of the `yast-*` icons. Most of them are now symlinks to preferences icons, but that doesn't fix the fact that this patch can't pass the sc

D17816: Initial support for xattrs on kio copy/move

ngraham added a comment. Thanks so much for working on this! Is it ready for review yet, or are you still changing things? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, mich

D17817: Build without D-Bus on Android

vkrause updated this revision to Diff 48282. vkrause added a comment. Remove accidentally added block that is not supposed to be part of this commit. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17817?vs=48241&id=48282 BRANCH arcpatch-D17817 R

D15910: Implement wl_surface::damage_buffer

davidedmundson added inline comments. INLINE COMMENTS > surface_interface.cpp:453 > +if (tr == Tr::Rotated90 || tr == Tr::Rotated270 || > +tr == Tr::Flipped90 || tr == Tr::Rotated270) { > +// calculate transformed + scaled bu

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/62/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 28 Dec 2018 10:13:55 + Build duration: 7 min 50 sec and counting BUILD ARTIFACTS logs/KF5Config/5

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 28 Dec 2018 10:13:54 + Build duration: 1 min 55 sec and counting BUILD ARTIFACTS logs/KF5Config/

D17623: Add YaST and new preference icons

ndavis updated this revision to Diff 48277. ndavis retitled this revision from "Add YaST icons" to "Add YaST and new preference icons". ndavis added a comment. Change most `yast-*` icons to symlinks and create preference icons to use as `yast-*` icons REPOSITORY R266 Breeze Icons CHANGES

D17830: Add YaST and new preferences icons

ndavis abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17830 To: ndavis Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17830: Add YaST and new preferences icons

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH yast-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D17830 AFFECTED FI

D15910: Implement wl_surface::damage_buffer

romangg added a comment. Ping REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D15910 To: romangg, #kwin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns