cochise added a comment.

  There is one use case (copy of dirs with rename, due name conflict) where the 
patches not work, and I can't test on *BSD or Mac.
  
  The first problem says I would need to add a very similar snippet in a third 
place, i trying to find right now, (any help from someone that knows KIO better 
than me is appreciated) but after this, we would need to rewrite as a function, 
to remove code duplication (and I'm open for suggestions of where to place it, 
as KIO is a rather big codebase). Baloo uses some very similar functions, from 
where i  so maybe we can unify the implementations in KIO level. So I'm 
planning to change things, but need some review to do this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh, 
bruns

Reply via email to