KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 378 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/378/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 13 Dec 2018 23:43:18 + Build duration: 7 min 34 sec and counting BUILD ARTIFACTS compat_reports/KF5K

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/17/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Dec 2018 23:43:18 + Build duration: 7 min 5 sec and counting BUILD ARTIFACTS compat_reports/KF5K

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Reverted. Will find another way. Sorry for the regression, everyone! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham,

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

thsurrel updated this revision to Diff 47545. thsurrel added a comment. Create KUrlNavigator::isInsideCompressedPath Use this function instead of comparing the url scheme with tar, zip, ... REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17270?vs=46589&id=4754

D10446: Add KLanguageName

aacid added a comment. > @aacid what were the changes you had planned here? As Aleix mentioned the two methods can probably be made to call eachother, or maybe not, but needs to be investigated and an answer given to why not if not possible. REPOSITORY R265 KConfigWidgets REVISION DE

D17528: Refactor SlaveInterface::calcSpeed

bruns added inline comments. INLINE COMMENTS > slaveinterface_p.h:59 > +QVector sizes; > +QVector times; > +QElapsedTimer elapsed_timer; You could use a struct for both, e.g.: struct SpeedSample { KIO::filesize_t remainder; qint64 elapsedTime; } QVector transferSpe

D17500: Restore mobipocket extractor

bruns added a comment. In D17500#376324 , @mgallien wrote: > In D17500#376221 , @aacid wrote: > > > Do I understand that the answer to my "Is it possible to move the extractor to kdegraphics-mobipock

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/7/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Dec 2018 16:16:21 + Build duration: 4 min 42 sec and counting JUnit Tests Name: (root) F

D17496: Change network/web color icons to consistent style

ngraham added a comment. Now that this is landed, feel free to change the symlinks by hand. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17496 To: ndavis, #vdg, ngraham Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 94 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/94/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 13 Dec 2018 16:16:21 + Build duration: 1 min 28 sec and counting JUnit Tests Name: (root) Fa

D17496: Change network/web color icons to consistent style

This revision was automatically updated to reflect the committed changes. Closed by commit R266:50077910f783: Change network/web color icons to consistent style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17496?vs=47499&id=47526

D17496: Change network/web color icons to consistent style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R266 Breeze Icons BRANCH network-icon-consistency (branched from master) REVISION DETAIL https://phabricator.kde.org/D17496 To: ndavis, #vdg, ngraham Cc: abetts

D10446: Add KLanguageName

sitter added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @aacid what were the changes you had planned here? Does anyone else have thoughts on kcoreaddons vs. kconfigwidgets? I suppose we could move the class along with kf5_entry.desktop to kcore

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Actually I feel like this regressed the visuals for the file dialog itself in the name of improving the situation for apps that use this view in a sidebar. Unfortunately, since it also regresses performance, I will be reverting it and and will look for another ap

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

abetts added a comment. +1 for improving visuals REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

knauss added a comment. @bcooksley for akonadi-search we need some special settings for the abi-create step. Where we should store such settings? This is a more general solution, that we can also modify the settings for other platforms etc. `ci-tooling/local-metadata/abi-complience

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham added a comment. @dfaure I'm not so familiar writing unit tests. This is one I have made by doing some modifications. would you like to give me some help? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: davidedmundson,

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham added a comment. void JobTest::moveDirectoryToInaccessibleFilesystem() { #ifdef Q_OS_WIN QSKIP("Skipping unaccessible folder test on Windows, cannot remove all permissions from a folder"); #endif // Given a directory that cannot be moved to destination bea

D17528: Refactor SlaveInterface::calcSpeed

chinmoyr updated this revision to Diff 47518. chinmoyr added a comment. 1. Updating D17528 : Refactor SlaveInterface::calcSpeed # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines

D17545: Do not stat move/copy job if the destination file system does not support writing

dfaure added a comment. The logic is the same in all cases, the mode doesn't really make a difference, so I'm ok with picking one -- let's say Move, so we can also check that nothing disappeared. File or folder also makes no difference, so I'm ok with just one of these. The one thing that

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. In D17461#376509 , @apol wrote: > Hey, this change makes the file dialog crawl on big directories. > For me, going into /usr/include makes the whole application freeze. > > We should consider reverting and trying a

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

apol added a comment. Hey, this change makes the file dialog crawl on big directories. For me, going into /usr/include makes the whole application freeze. We should consider reverting and trying a different approach. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D

D17528: Refactor SlaveInterface::calcSpeed

chinmoyr added a comment. In D17528#376349 , @dfaure wrote: > I'm surprised, how can a QLinkedList (with nodes allocated all over the memory) be better than a static array (which fits into the same memory cache) ? IMO It is better only in

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham marked an inline comment as done. shubham added a comment. @dfaure do you need tests for all three modes ie. copy,move and link And individually for files and folders REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: dav

D17558: Fix XDGForeign Client header installs

davidedmundson edited the summary of this revision. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D17558 To: davidedmundson, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17558: Fix XDGForeign Client header installs

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D17558 To: davidedmundson, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17558: Fix XDGForeign Client header installs

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY XdgForeign.h contains the public classes that a client could use. Xdgforeign_v2 is entirely internal.

D17545: Do not stat move/copy job if the destination file system does not support writing

dfaure added inline comments. INLINE COMMENTS > shubham wrote in copyjob.cpp:868-872 > emitresult() emits the corresponding signal and then commits suicide, hence > no such chance possible. Still, don't call statNextSrc() then. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 377 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/377/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 13 Dec 2018 10:39:43 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 0 test(s

T3689: Add abi compliance checker to CI

knauss updated the task description. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17545 To: shubham, #frameworks, dfaure Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham added inline comments. INLINE COMMENTS > davidedmundson wrote in copyjob.cpp:868-872 > emitting a result and then continuing seems questionable, you'll end up with > the job emitting another result later emitresult() emits the corresponding signal and then commits suicide, hence no suc

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/16/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Dec 2018 10:39:43 + Build duration: 6 min 58 sec and counting JUnit Tests Name: (root) Failed: 0

T3689: Add abi compliance checker to CI

knauss added a comment. okay with merging D17534 CI now successfully builds the abis for the mentioned packages. (I modified the last comment) TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmi

D17545: Do not stat move/copy job if the destination file system does not support writing

davidedmundson added a comment. > And there should be a unittest for it. This still needs doing INLINE COMMENTS > copyjob.cpp:867 > +q->setError(ERR_CANNOT_WRITE); > +q->setErrorText(m_currentDestURL.toDisplayString()); > +q->emitResult();

D17545: Do not stat move/copy job if the destination file system does not support writing

shubham updated this revision to Diff 47503. shubham marked 3 inline comments as done. shubham added a comment. Done above requested changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17545?vs=47465&id=47503 REVISION DETAIL https://phabricator.kde.org/D

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/15/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 13 Dec 2018 08:59:27 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 0 test(

D17496: Change network/web color icons to consistent style

ndavis updated this revision to Diff 47499. ndavis added a comment. Re-add `applications-internet` symlink to `preferences/32` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17496?vs=47359&id=47499 BRANCH network-icon-consistency (branched from mast

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 376 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/376/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 13 Dec 2018 08:59:27 + Build duration: 6 min 0 sec and counting JUnit Tests Name: (root) Failed: 0 t

D17554: [KFileItem] Fix isLocal check in checkDesktopFile

This revision was automatically updated to reflect the committed changes. Closed by commit R241:86e3142f8588: [KFileItem] Fix isLocal check in checkDesktopFile (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17554?vs=47493&id=47498 REVISION

D17528: Refactor SlaveInterface::calcSpeed

dfaure added a comment. I'm surprised, how can a QLinkedList (with nodes allocated all over the memory) be better than a static array (which fits into the same memory cache) ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17528 To: chinmoyr, dfaure Cc: kde-frameworks-

D17545: Do not stat move/copy job if the destination file system does not support writing

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:862 > +// if the destination file system doesn't support writing, do not > stat > +QFileInfo destInfo(m_currentDestURL.toString())

D17554: [KFileItem] Fix isLocal check in checkDesktopFile

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17554 To: broulik, dfaure, davidedmundson, shubham Cc: kde-frameworks-devel, michaelh, ngraham, bruns