davidedmundson added a comment.
> And there should be a unittest for it.
This still needs doing
INLINE COMMENTS
> copyjob.cpp:867
> + q->setError(ERR_CANNOT_WRITE);
> + q->setErrorText(m_currentDestURL.toDisplayString());
> + q->emitResult();
that's not going to be a helpful error text on it's own.
Code above calls buildErrorString
> copyjob.cpp:868-872
> + q->emitResult();
> + if (that) {
> + statNextSrc();
> + }
> + return;
emitting a result and then continuing seems questionable, you'll end up with
the job emitting another result later
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17545
To: shubham, #frameworks, dfaure
Cc: davidedmundson, ngraham, broulik, kde-frameworks-devel, michaelh, bruns
