D16643: Correct the accept flag of the event object on DragMove

trmdi edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

trmdi edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

On Sun, 4 Nov 2018, 14:18 Aleix Pol I'm confused, this adds rsync and comments rsync out. > I had to comment rsync out because we can't rebuild the image at the moment. I added it to the image for later on, when we can rebuild the image again. Once we can, then that part of this commit can be r

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/90/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 01:30:31 + Build duration: 9 min 30 sec and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/109/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Nov 2018 01:30:31 + Build duration: 1 min 52 sec and counting JUnit Tests Name: (root

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 71 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/71/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 04 Nov 2018 01:27:17 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT [...tr

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R286:3129ba1798fd: [XmlExtractor] Use QXmlStreamReader for better performance (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 299 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/299/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Nov 2018 01:21:11 + Build duration: 6 min 55 sec and counting JUnit Tests Name: (root) Failed: 0 t

D16466: [KSambaShare] Add unit test for "net usershare info" parser

This revision was automatically updated to reflect the committed changes. Closed by commit R241:35c861bf146a: [KSambaShare] Add unit test for "net usershare info" parser (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16466?vs=44322&id=44811 R

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. @ngraham How to see the full file content from this page? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16465: [KSambaShare] Make "net usershare info" parser testable

This revision was automatically updated to reflect the committed changes. Closed by commit R241:253d58f6734e: [KSambaShare] Make "net usershare info" parser testable (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16465?vs=44321&id=44810 REVIS

Re: [sysadmin/ci-tooling] /: Disable parts of the System Dependency building on Android CI until rsync can be made available.

I'm confused, this adds rsync and comments rsync out. On Sat, Nov 3, 2018 at 4:48 AM Ben Cooksley wrote: > > Git commit a01c4d1ba8fd31f1112c207b61542b14aab3e9e8 by Ben Cooksley. > Committed on 03/11/2018 at 03:48. > Pushed by bcooksley into branch 'master'. > > Disable parts of the System Dependen

D16591: [XmlExtractor] Use QXmlStreamReader for better performance

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D16591 To: bruns, #frameworks, astippich, apol Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D16466: [KSambaShare] Add unit test for "net usershare info" parser

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH net_usershare REVISION DETAIL https://phabricator.kde.org/D16466 To: bruns, #frameworks, broulik, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16465: [KSambaShare] Make "net usershare info" parser testable

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH net_usershare REVISION DETAIL https://phabricator.kde.org/D16465 To: bruns, #frameworks, broulik, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. In D16643#353670 , @bruns wrote: > This is not covered by your summary - you have only listed cases where the drag is erroneously **not** accepted. Please update the summary. I wrote it in the first line: > m_e

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. In D16643#353670 , @bruns wrote: > No. The event loop is running in a single thread. m_enabled is constant during the function. Can it be changed from outside? REPOSITORY R296 KDeclarative REVISION DETAIL http

D16643: Correct the accept flag of the event object on DragMove

bruns added a comment. In D16643#353669 , @trmdi wrote: > @bruns > If `setAccepted` goes below the first if: > > - if there is a change that make m_enabled change from true -> false while moving, the cursor still display the draggable icon

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. @bruns If `setAccepted` goes below the first if: - if there is a change that make m_enabled change from true -> false while moving, the cursor still display the dragable icon So I let it be on the top to make the cursor be able to change the icon to forbidde

D16579: Fix APE tag extraction

smithjd added a comment. In D16579#352887 , @astippich wrote: > You're doing the exact opposite of what we're asking for. > Look, I'd love to merge the bug fix for the DISC property. But we need compatibility. > I'll give you another reaso

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/123/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 22:35:50 + Build duration: 5 min 48 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/67/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 22:35:50 + Build duration: 1 min 22 sec and counting JUnit Tests Name: (root) Fa

D16633: Add root version of drive-harddisk

This revision was automatically updated to reflect the committed changes. Closed by commit R266:67312861ffa3: Add root version of drive-harddisk (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16633?vs=44797&id=4

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16633: Add root version of drive-harddisk

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH drive-harddisk-root_and_home (branched from master) REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham added a dependent revision: D15739: [Places panel] Don't show Root by default. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

ngraham edited the summary of this revision. ngraham added a dependency: D15739: [Places panel] Don't show Root by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc: svenmauch, kde-frame

D15739: [Places panel] Don't show Root by default

ngraham added a dependent revision: D7446: [Places panel] Add a Recently Used item by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, kde-framewo

D16633: Add root version of drive-harddisk

ngraham added a comment. Awesome, let's do it. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15739: [Places panel] Don't show Root by default

ngraham edited the summary of this revision. ngraham added a dependency: D16653: Use the new `drive-harddisk-root` icon for the root volume. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: ndavis, romangg, bruns, davidedmundson, abetts,

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D16653 To: ngraham, romangg, #vdg, #dolphin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16633: Add root version of drive-harddisk

ngraham added a dependent revision: D16653: Use the new `drive-harddisk-root` icon for the root volume. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16653: Use the new `drive-harddisk-root` icon for the root volume

ngraham created this revision. ngraham added reviewers: romangg, VDG, Dolphin, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Use the new `drive-harddisk-root` icon to mark the root volu

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9a0505af2dbf: Introduce AbstractAnnotationItemDelegate for more control by consumer (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8708?vs=43868&id=44806#toc REPOSITORY

D16643: Correct the accept flag of the event object on DragMove

bruns added a comment. So if I understand it correctly, the sequence of events is: - an object is dragged to the target area - m_enabled is initially false - m_enabled becomes true because the object is acceptable - the mouse is moved, but the //integer// position probably is unchang

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/11/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 03 Nov 2018 12:01:51 + Build duration: 6 hr 59 min and counting JUnit Tests

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 169 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/169/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 18:35:43 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 0 tes

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 137 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/137/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 18:35:43 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0 test(

D16633: Add root version of drive-harddisk

ndavis updated this revision to Diff 44797. ndavis added a comment. Change color of forward slash to grey REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16633?vs=44759&id=44797 BRANCH drive-harddisk-root_and_home (branched from master) REVISION DET

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 52 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/52/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 03 Nov 2018 18:35:43 + Build duration: 6 min 19 sec and counting

D16643: Correct the accept flag of the event object on DragMove

trmdi retitled this revision from "Correct m_enabled on DragMove " to "Correct the accept flag of the event object on DragMove ". REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: dkorth, ngraham, kde-

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 52 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/52/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 03 Nov 2018 18:35:43 + Build duration: 2 min 26 sec and counting

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 71 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/71/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 18:24:08 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 3 te

D16643: Correct m_enabled on DragMove

trmdi added a comment. In D16643#353517 , @ngraham wrote: > Wow, does this really fix 396011!? If so, congratulations! I wish I could test, but alas (or thankfully?) I don't experience the problem. Yes, it fixes the problem on my system.

D16643: Correct m_enabled on DragMove

dkorth added a comment. This fixes the issue for me for both desktop icons and panel widgets. Using KF 5.51, Plasma 5.14.2, and Qt 5.11.2. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: dkor

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/97/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 18:24:08 + Build duration: 5 min 17 sec and counting JUnit Tests Name: (root) Fail

D16633: Add root version of drive-harddisk

ngraham added a comment. That's true. Okay, let's stay with a slash for now and just make it Icon Gray. In general I'd like to see us reduce our use of the red color for things that aren't actually destructive or errors, which I think will make it more meaningful for things that are. REPOSI

D16633: Add root version of drive-harddisk

ndavis added a comment. In D16633#353510 , @ngraham wrote: > Hmm, you're right. > > Maybe we could use a slash for the 16px version, and the plasma logo for the larger ones? That would cause confusion though. The meaning of a forward

D16643: Correct m_enabled on DragMove

ngraham added reviewers: broulik, Plasma, hein, davidedmundson. ngraham added a comment. Wow, does this really fix 396011!? If so, congratulations! I wish I could test, but alas (or thankfully?) I don't experience the problem. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabrica

D16633: Add root version of drive-harddisk

ngraham added a comment. Hmm, you're right. Maybe we could use a slash for the 16px version, and the plasma logo for the larger ones? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16643: Correct m_enabled on DragMove

trmdi created this revision. trmdi added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trmdi requested review of this revision. REVISION SUMMARY - `m_enabled` could change while moving. - Don't call `setAccepted(false)` wrongly if `event

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 51 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/51/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 03 Nov 2018 14:55:11 + Build duration: 2 hr 17 min and counting CONSOLE OUTPUT [...t

D16633: Add root version of drive-harddisk

ndavis added a comment. In D16633#353308 , @ngraham wrote: > Thank you! Two comments: > > - I'm not sure using the negative color is appropriate here. That color is used for dangerous operations or error conditions, neither of which apply to

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 136 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/136/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 14:55:11 + Build duration: 7 min 41 sec and counting CONSOLE OUTPUT [...truncated 119.3

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 51 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/51/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 03 Nov 2018 14:55:11 + Build duration: 28 sec and counting CONSOLE OUTPUT [...truncated 92.2

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 168 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/168/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 14:55:11 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated 115.30 KB

D12045: Clean up existing documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R293:580d2feff619: Clean up existing documentation (authored by michaelh, committed by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12045?vs=31739&id=44774 REVI

D12045: Clean up existing documentation

bruns commandeered this revision. bruns added a reviewer: michaelh. REPOSITORY R293 Baloo BRANCH doc-cleanup REVISION DETAIL https://phabricator.kde.org/D12045 To: bruns, #baloo, ngraham, michaelh Cc: kde-frameworks-devel, ngraham, bruns, ashaposhnikov, michaelh, astippich, spoorun, abra

D16594: Add context to kcmodule connection to lambdas

bruns accepted this revision. bruns added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleqml.cpp:74 > Technically yes, but there's no sane scope for a code path where configModule > is emitting anything between deleting d and this. Thanks for the confirmation, hope nobody fi

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 108 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/108/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 14:34:11 + Build duration: 1 min 42 sec and counting JUnit Tests Name: (root

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 89 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/89/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 14:34:11 + Build duration: 1 min 48 sec and counting JUnit Tests Name: (root) F

D16593: [ExtractorCollection] Use only best matching extractor plugin

This revision was automatically updated to reflect the committed changes. bruns marked 2 inline comments as done. Closed by commit R286:497a69ca846b: [ExtractorCollection] Use only best matching extractor plugin (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE htt

D16592: [ExtractorCollection] Add unit-test to verify only specific extractor is used

This revision was automatically updated to reflect the committed changes. Closed by commit R286:7e484b968fd9: [ExtractorCollection] Add unit-test to verify only specific extractor is used (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/68/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 14:00:26 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/124/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 14:00:25 + Build duration: 8 min 32 sec and counting JUnit Tests Name: (root)

D16633: Add root version of drive-harddisk

ngraham added a comment. Thank you! Two comments: - I'm not sure using the negative color is appropriate here. That color is used for dangerous operations or error conditions, neither of which apply to the OS volume. It's true that you could potentially blow yourself up by messing with

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 176 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/176/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 12:03:27 + Build duration: 1 hr 20 min and counting JUnit Tests Name: (root

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 70 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/70/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 12:02:51 + Build duration: 1 hr 9 min and counting CONSOLE OUTPUT [...truncated 554.5

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/37/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 12:03:01 + Build duration: 1 hr 9 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/62/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 12:02:01 + Build duration: 1 hr 4 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 298 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/298/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 12:01:15 + Build duration: 1 hr 4 min and counting JUnit Tests Name: (root) Failed: 1 te

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/25/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 12:01:06 + Build duration: 1 hr 2 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/46/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 12:00:00 + Build duration: 1 hr 1 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/67/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 11:59:41 + Build duration: 53 min and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/66/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Nov 2018 11:58:44 + Build duration: 47 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/96/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 12:02:51 + Build duration: 34 min and counting JUnit Tests Name: (root) Failed: 3

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 12:03:01 + Build duration: 34 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 250 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/250/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 12:03:27 + Build duration: 26 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/84/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 12:02:01 + Build duration: 26 min and counting JUnit Tests Name: (root) Failed: 4

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/72/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 12:00:00 + Build duration: 23 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/31/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 12:01:06 + Build duration: 19 min and counting JUnit Tests Name: (root) Faile

D16434: Fix keyboard layout change notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R268:4d28bd4183d2: Fix keyboard layout change notifications (authored by fvogt). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44765&id=44766 REVISION DE

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/62/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 12:00:20 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/123/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 11:59:40 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed

D16434: Fix keyboard layout change notifications

fvogt updated this revision to Diff 44765. fvogt marked 2 inline comments as done. fvogt added a comment. This file needs to be reformatted anyway. REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16434?vs=44715&id=44765 BRANCH master REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 122 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/122/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Nov 2018 11:58:43 + Build duration: 5 min 38 sec and counting JUnit Tests Name: (root)

D16633: Add root version of drive-harddisk

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16434: Fix keyboard layout change notifications

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Pls do the coding style improvements and push. INLINE COMMENTS > kglobalaccel_x11.cpp:75 > + const xcb_query_extension_reply_t *reply = > xcb_get_extension_data(QX11Info::connection(

D16633: Add root version of drive-harddisk

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16633: Add root version of drive-harddisk

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 399307 I did not add `drive-harddisk-home` in this commit because it was simply too

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent added inline comments. INLINE COMMENTS > emateli wrote in batchrenamedialog.h:69 > You mean to initialize them to nullptr on the header file or using a > constructor initialization list? Also see what problem? in header file. REPOSITORY R241 KIO REVISION DETAIL https://phabricato