romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land.
Pls do the coding style improvements and push. INLINE COMMENTS > kglobalaccel_x11.cpp:75 > + const xcb_query_extension_reply_t *reply = > xcb_get_extension_data(QX11Info::connection(), &xcb_xkb_id); > + if (reply && reply->present) > + m_xkb_first_event = reply->first_event; https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces > kglobalaccel_x11.cpp:207 > const uint8_t responseType = event->response_type & ~0x80; > - switch (responseType) { > - case XCB_MAPPING_NOTIFY: > - qCDebug(KGLOBALACCELD) << "Got XMappingNotify event"; > - xcb_refresh_keyboard_mapping(m_keySymbols, > reinterpret_cast<xcb_mapping_notify_event_t*>(event)); > - x11MappingNotify(); > - return true; > - > - case XCB_KEY_PRESS: > + if(responseType == XCB_MAPPING_NOTIFY) { > + x11MappingNotify(); https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces space after `if` > kglobalaccel_x11.cpp:213 > + } > + else if(responseType == XCB_KEY_PRESS) { > #ifdef KDEDGLOBALACCEL_TRACE https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces space and on same line as closing brace REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D16434 To: fvogt, #frameworks, #plasma, romangg Cc: romangg, ngraham, anthonyfieroni, kde-frameworks-devel, michaelh, bruns
