KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 43 - Still unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/43/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 06:09:03 + Build duration: 24 min and counting JUnit Tests Name: (root) Faile

D16141: Disable unmount option for / or /home

2018-10-11 Thread Kai Uwe Broulik
broulik added a comment. Why would you be unable to unmount `/home`? If you're logged in as root (not saying that one should or can), whose home is `/root` you can surely unmount `/home` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, n

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Still Failing!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/32/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Oct 2018 05:32:54 + Build duration: 58 min and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.9 - Build # 38 - Fixed!

2018-10-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.9/38/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 06:05:50 + Build duration: 11 min and counting JUnit Tests Name: (root) Fail

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/59/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:58:14 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 4 te

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 69 - Still unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/69/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 06:09:03 + Build duration: 3 min 17 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.11 - Build # 11 - Fixed!

2018-10-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.11/11/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 12 Oct 2018 06:09:03 + Build duration: 2 min 36 sec and counting

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.10 - Build # 49 - Fixed!

2018-10-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 06:05:50 + Build duration: 2 min 27 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 42 - Failure!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/42/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:33:42 + Build duration: 32 min and counting CONSOLE OUTPUT [...truncated 86

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.9 - Build # 37 - Failure!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.9/37/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:34:26 + Build duration: 30 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 63 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/63/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:20:13 + Build duration: 42 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/58/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:20:57 + Build duration: 37 min and counting JUnit Tests Name: (root) Failed: 4 te

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 81 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/81/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 05:34:05 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 4

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.10 - Build # 48 - Failure!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.10/48/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 05:34:26 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncate

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 68 - Failure!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/68/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 05:33:42 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.11 - Build # 10 - Failure!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.11/10/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 12 Oct 2018 05:33:42 + Build duration: 7 min 10 sec and counting CONSOLE OUTPUT [.

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/80/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 05:20:57 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 4

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/119/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 05:20:13 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 31 - Still Failing!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/31/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Oct 2018 05:19:33 + Build duration: 10 min and counting CONSOLE OUTPUT [...trunca

D16141: Disable unmount option for / or /home

2018-10-11 Thread Shubham
shubham added inline comments. INLINE COMMENTS > kfileplacesview.cpp:33 > +#include > > #include Move this header up > kfileplacesview.cpp:54 > +#include > > #include "kfileplaceeditdialog_p.h" Move the header up, to its appropriate position letter wise. REPOSITORY R241 KIO REVISI

D16145: Adapt autotest to new menu structure

2018-10-11 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: gregormi, dhaumann. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY D13880 changed the menu

D16141: Disable unmount option for / or /home

2018-10-11 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Can you add `CCBUG: 399659` to this so that bug report reflects that two commits were necessary to fully resolve it? Thanks! However, I'm afraid this doesn't actually work f

D16135: refactor tests for taglibextractor

2018-10-11 Thread Stefan Brüns
bruns added a comment. Can you split this up in two patches, the first one updating the test files and fixing the values in the tests, and the second one doing the refactoring? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16135 To: astippich, mgallien, brun

D13425: File indexer closing improvements.

2018-10-11 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The content and summary still do not match. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham,

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-11 Thread Albert Astals Cid
aacid added a comment. Adding new parameters is unfortunately Binary Incompatible so this can't go in this way, for it to work you'd need to add a new function with all the parameters and then call one from the other. Maybe what we need is one that takes two bools we should have one that

D16141: Disable unmount option for / or /home

2018-10-11 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY This disables the 'Unmount' context menu in the Places panel for discs corres

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/120/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 11 Oct 2018 19:30:17 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 79 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/79/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 11 Oct 2018 19:30:17 + Build duration: 3 min 1 sec and counting JUnit Tests Name: (root) Failed

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-11 Thread Tim __
kadabash created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kadabash requested review of this revision. REVISION SUMMARY Scrolling a settings page horizontally feels awkward most of the time. This (optionally) lets the dialogue resize wh

D16135: refactor tests for taglibextractor

2018-10-11 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY refactors all tests so that they can be reused for

D16060: Reduce double and triple lookups to the frames hash

2018-10-11 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:d9b907e953a4: Reduce double and triple lookups to the frames hash (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16060?vs=431

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 238 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/238/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 11 Oct 2018 15:28:56 + Build duration: 3 min 4 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 163 - Still Unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/163/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 11 Oct 2018 15:28:56 + Build duration: 3 min 5 sec and counting JUnit Tests Name: (root

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-11 Thread Stefan Brüns
bruns added a comment. In D15939#341094 , @smithjd wrote: > https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the storagedevice

KDE4 build question: turning off hidden visibility?

2018-10-11 Thread René J . V . Bertin
Hi, Please excuse me for a question that's not directly related to KF5 frameworks; I don't know where else to reach an audience who might know (remember) the answer. In short: how do I configure a build so it will use default (public) visibility for all symbols, preferably without patching som

KDE CI: Frameworks » kconfig » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Still unstable!

2018-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.11/16/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 11 Oct 2018 08:49:38 + Build duration: 14 min and counting JUnit Tests Name: (roo

Re: DBus thread shutdown issue on Windows

2018-10-11 Thread David Faure
On jeudi 11 octobre 2018 10:39:18 CEST Ben Cooksley wrote: > > I believe it also stores "accept this certificate for this session", > > which makes sense on Windows as well > > > > Though not in unittests, I guess, so disabling it use on CI sounds like a > > possibility. Not sure exactly how t

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.10 - Build # 52 - Fixed!

2018-10-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.10/52/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 11 Oct 2018 08:51:51 + Build duration: 4 min 18 sec and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks » kconfig » kf5-qt5 WindowsMSVCQt5.11 - Build # 15 - Still Failing!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.11/15/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 11 Oct 2018 08:42:53 + Build duration: 1.6 sec and counting CONSOLE OUTPUT Started

KDE CI: Frameworks » kconfig » kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Failure!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.11/14/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 11 Oct 2018 08:41:58 + Build duration: 1.6 sec and counting CONSOLE OUTPUT Started

KDE CI: Frameworks » kconfig » kf5-qt5 WindowsMSVCQt5.11 - Build # 13 - Failure!

2018-10-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.11/13/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Oct 2018 13:51:33 + Build duration: 18 hr and counting CONSOLE OUTPUT [...trunc

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-11 Thread Christoph Cullmann
cullmann added a comment. Hi, not that I am a expert in delegates but from a glance the interface part looks ok. I would have no issues with merging this. It is an optional feature, we have one user. We can still evolve this interface with some Vx version if bad issues are discover

Re: DBus thread shutdown issue on Windows

2018-10-11 Thread Ben Cooksley
On Thu, Oct 11, 2018 at 3:20 AM David Faure wrote: > > [Adjusting CC list] > > On mercredi 10 octobre 2018 11:55:01 CEST Ben Cooksley wrote: > > On Thu, Oct 4, 2018 at 3:15 PM Thiago Macieira > > > > wrote: > > > On Wednesday, 3 October 2018 18:12:08 PDT David Faure wrote: > > > > On another note

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-10-11 Thread Christoph Cullmann
cullmann added a comment. Hi, I still need to test this. For the enum, I have no issue with scoped enums, but I think something like DefinitionData::LoadOptions::OnlyKeywords would be better than a enum that just encapsules a bool. Actually one could create a proper Q_FLAGS to all