cullmann added a comment.

  Hi, I still need to test this.
  For the enum, I have no issue with scoped enums, but I think something like
  
  DefinitionData::LoadOptions::OnlyKeywords
  
  would be better than a enum that just encapsules a bool.
  Actually one could create a proper Q_FLAGS to allow combinations, if we later 
want to extend that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

Reply via email to