D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. No problem @siddharthasahu. For the issue you're having with bindings i'd suggest raising a separate thread about that on kde-frameworks-devel as others might have missed it buried in this review. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricat

D13488: Make XDGShellV5 co-compilable with XDGWMBase

rikmills added a comment. In libkf5waylandclient5 and libkf5waylandserver5 I see the previously emitted symbol xdg_shell_interface@Base is now reported as MISSING. Can you confirm this is private and/or not an ABI break? Build symbols output: https://paste.kde.org/pfpkps1mb#line-109

D13808: Fix KMainWindow saving incorrect widget settings

anthonyfieroni added inline comments. INLINE COMMENTS > maxrd2 wrote in kmainwindow_unittest.cpp:267 > Retried with all of these... none of them causes the failure, only closing > the window manually cause it > > QApplication::postEvent(mw, new QDeferredDeleteEvent); // qpa/window > manager

D13808: Fix KMainWindow saving incorrect widget settings

ngraham added a comment. Yeah, I say let's remove the test for now so we can commit this, and then you can add the test back in another patch please (in working form, of course!). :) REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D1380

D13773: [KDirOperator] Use alternating background colors for multi-column views

ngraham retitled this revision from "[KDirOperator] Use alternating background colors for list-style views" to "[KDirOperator] Use alternating background colors for multi-column views". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241

D13773: [KDirOperator] Use alternating background colors for list-style views

ngraham updated this revision to Diff 37920. ngraham added a comment. Only use the alternating row colors for multi-column views, to avoid having it on any vertical sidebar-style lists REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13773?vs=36806&id=37920 BRA

D14175: Support cursor hints on locked pointer

romangg added a dependent revision: D14176: Use locked cursor position hint. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg added a task: T4692: [kwayland] Support cursor hint on LockedPointerInterface. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14175 To: romangg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14175: Support cursor hints on locked pointer

romangg updated this revision to Diff 37917. romangg added a comment. - Cleanup: remove hint getter REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14175?vs=37916&id=37917 BRANCH cursorHints REVISION DETAIL https://phabricator.kde.org/D14175 AFFECTED

D14175: Support cursor hints on locked pointer

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY Implement support for locked pointer cursor hints. TE

D14052: Add bluetooth plugin

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:1 > Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`? Makes sense. When I include it cmake tells me it's not found, although /usr/lib/qt/qml/org/kde/bluezqt exists. Am I missing something? REPOSITORY R

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 57 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/57/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 21:30:24 + Build duration: 6 min 4 sec and counting

D14137: CSS: update syntax and fix some errors

jpoelen added a comment. It is done. So much emotion :') REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, s

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/41/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 21:30:24 + Build duration: 2 min 21 sec and countin

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 113 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/113/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 21:30:24 + Build duration: 2 min 14 sec and counting

D14137: CSS: update syntax and fix some errors

This revision was automatically updated to reflect the committed changes. Closed by commit R216:423239c45ec5: CSS: update syntax and fix some errors (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14137?vs=37815&id=37912 REVI

D14160: [KMessageBox] Call style for icon

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. In general, looks good to me. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14160 To: broulik, dfaure, kfunk, dhaumann Cc: dhaumann, kde-frameworks-de

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. @ngraham Don't think I can. I have no commit rights. Should i revert/remove test part, as currently it doesn't test anything i believe.. it always passes. REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

siddharthasahu added a comment. Thank you for the clarification @bcooksley. I wonder if there is a way to enforce compilation of certain parts single threaded in make. Or some other way to ensure testing these components. But in any case, the builds are still failing for me. I hope @brun

D13808: Fix KMainWindow saving incorrect widget settings

ngraham added a comment. Shall we commit this? maxrd2 , can you do it, or does one of us need to commit it for you? REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik,

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb updated this revision to Diff 37897. rjvbb added a comment. Using QApplication::style() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14000?vs=37568&id=37897 REVISION DETAIL https://phabricator.kde.org/D14000 AFFECTED FILES plugin/kquickstyleitem.cpp plugin/kquickstyle

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop Style. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D14000 To: rjvbb, #frameworks Cc: alexeymin, davidedmundson, mart, broulik, plasma-devel, ragreen, Pitel, Zr

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

aacid added a comment. The docu of ki18n says we localize numbers (as far as i remember), so that patch you discarded is "the right thing" imho REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D12164 To: kossebau, ilic Cc: aacid, kde-frameworks-devel, huftis,

D14052: Add bluetooth plugin

apol accepted this revision. apol added a comment. LGTM overall. INLINE COMMENTS > CMakeLists.txt:1 > +add_share_plugin(bluetoothplugin bluetoothplugin.cpp) Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`? REPOSITORY R495 Purpose Library BRANCH bluetooth REVISION DETAIL http

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

alexeymin added a comment. Don't know how much offtopic will be what I'm going to say, but I recently ran into an issue while packaging QQC2 application in flatpak with org.kde.Platform//5.9 runtime. My app was functioning perfectly fine in system, but under flatpak it failed to start with t

D14123: Add `drive-optical` icon

andreaska added a comment. Thanks for the patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14123 To: ngraham, broulik, andreask, #breeze, #vdg Cc: andreaska, kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Upon close look I realised that there was a lot of allocati

D13773: [KDirOperator] Use alternating background colors for list-style views

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D14161: [KStyle] Use dialog-question for question icon

broulik created this revision. broulik added reviewers: dfaure, ngraham, rkflx. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This was changed in `KMessageBox` in 9b

D14160: [KMessageBox] Call style for icon

broulik created this revision. broulik added reviewers: dfaure, kfunk. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `QMessageBox::standardIcon` is deprecated. Also,

D13773: [KDirOperator] Use alternating background colors for list-style views

ngraham added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13773 To: ngraham, #frameworks, #vdg, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

davidedmundson added a comment. Please swap qApp->style for QApplication::style as it's static. Solution is quite clever. It's risky as any qstyle will always be written assuming it's a QApplication; but by definition the QQC2 code shields from a lot of the QWidget casting that would

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/96/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 15:23:37 + Build duration: 3 min 50 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/40/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 15:23:37 + Build duration: 1 min 35 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/16/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 15:23:37 + Build duration: 1 min 23 sec and counting JUnit

D14123: Add `drive-optical` icon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:ca645a423dbb: Add `drive-optical` icon (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDAT

D14123: Add `drive-optical` icon

ngraham added a comment. @andreask verbally (textually?) approved this in the VDG room; landing it. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D14123 To: ngraham, broulik, andreask, #breeze, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12388: Output device color curves correction

davidedmundson updated this revision to Diff 37879. davidedmundson added a comment. Rebase and fix conflicts REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=34770&id=37879 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12388 AFFE

D12388: Output device color curves correction

davidedmundson commandeered this revision. davidedmundson edited reviewers, added: romangg; removed: davidedmundson. davidedmundson added a comment. Comadeering to rebase on top of my changes that also moved outputdevice to version 2. REPOSITORY R127 KWayland REVISION DETAIL https://phab

D14097: Change default sort order in the download dialog to Rating

ngraham closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D14097 To: ngraham, apol, leinir, #knewstuff Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13899: KMessageWidget: use theme instead of hardcoded colours

ngraham added a comment. I think the problem here is that while themes have dedicated Positive, Negative, and Neutral colors, for the Informational color we just re-use the active or highlight color from the theme, which may not always be appropriate for use as a background for informational

D13828: Revert "updated Japanese holidays (in Japanese and English)"

phanect abandoned this revision. phanect added a comment. Sorry, I didn't notice that I have permission to close this. I just closed this. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13828 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlauren

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/68/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 14:13:46 + Build duration: 16 min and counting JUnit Tests Name: (

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/30/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 14:13:46 + Build duration: 15 min and counting JUnit Tests N

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/41/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 14:13:46 + Build duration: 7 min 15 sec and counting JUnit Tests Nam

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/29/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 13:39:06 + Build duration: 13 min and counting JUnit Tests N

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/40/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 13:39:06 + Build duration: 8 min 29 sec and counting JUnit Tests Nam

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/67/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 13:39:06 + Build duration: 8 min 7 sec and counting JUnit Tests Na

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 79 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/79/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 13:29:26 + Build duration: 13 min and counting JUnit Tests Name: (roo

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb added a comment. This is what approach 1 looks like with (clockwise) Breeze Dark, Oxygen and Wonton Soup: F6110913: image.png Positive messages don't have an icon here because currently only the Breeze icon set has a "positive" icon. The

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

broulik added a comment. Should this show an error to the user? I could also imagine this interfering with thumbnail generation when viewing the device REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14158 To: jtamate, #frameworks Cc: broulik

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 56 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/56/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 13:29:26 + Build duration: 1 min 46 sec and counting JUnit Tests Name:

D14052: Add bluetooth plugin

nicolasfella added a comment. @apol I would like your opinion before merging REPOSITORY R495 Purpose Library BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D14052 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14107: [Telegram] Don't wait for Telegram to be closed

This revision was automatically updated to reflect the committed changes. Closed by commit R495:6803b1203e46: [Telegram] Don't wait for Telegram to be closed (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14107?vs=37723&id=3

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 66 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/66/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 12:21:56 + Build duration: 14 min and counting JUnit Tests Name: (

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 28 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/28/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 12:21:56 + Build duration: 7 min 6 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/39/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 12:21:56 + Build duration: 6 min 9 sec and counting JUnit Tests Name

D13510: Add XDG WM Base support to our XDGShell API

This revision was automatically updated to reflect the committed changes. Closed by commit R127:59259d8dc1f3: Add XDG WM Base support to our XDGShell API (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13510?vs=36244&id=37872 REV

D13488: Make XDGShellV5 co-compilable with XDGWMBase

This revision was automatically updated to reflect the committed changes. Closed by commit R127:63bd1f441644: Make XDGShellV5 co-compilable with XDGWMBase (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13488?vs=37034&id=37871 RE

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

jtamate created this revision. jtamate added a reviewer: Frameworks. jtamate requested review of this revision. REVISION SUMMARY When the device is blocked, for example by amarok mtp plugin, the result of LIBMTP_Open_Raw_Device_Uncached(rawDevice) is nullptr and LIBMTP_Get_Friendlyname(nullp

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 65 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/65/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 12:03:46 + Build duration: 4 min 3 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/38/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 12:03:46 + Build duration: 3 min 57 sec and counting CONSOLE OUTPUT [

D14107: [Telegram] Don't wait for Telegram to be closed

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I guess this only happens if Telegram wasn't running already. REPOSITORY R495 Purpose Library BRANCH finishtelegramjob REVISION DETAIL https://phabricator.kde.org/D14107 To: nicolasfell

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/27/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 12:03:46 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT

D14154: Add

phanect retitled this revision from "Update substitute holidays & holidays between public holidays" to "Add ". phanect edited the summary of this revision. phanect added reviewers: winterz, mlaurent, KDE PIM, Frameworks. REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.

D14122: KFormat: Replace unicode literal with unicode codepoint to fix MSVC build

bcooksley added inline comments. INLINE COMMENTS > dhaumann wrote in kformatprivate.cpp:121 > Would it make sense to mention with which MSVC version this was tested? At > some point in time, this may be fixed, and then the comment is wrong. For the record, the current version of MSVC in use is

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. In regards to Python, that is not enabled as the bindings generation is not reliable and can easily fail on a highly parallel system (which the CI is, depending on the node it could be a Hexa Core with HT, so run using make -j13) The generation also had a nasty te

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/82/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 10:17:31 + Build duration: 4 min 49 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/81/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 16 Jul 2018 03:20:27 + Build duration: 6 hr 57 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 325 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/325/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 16 Jul 2018 09:41:55 + Build duration: 7 min 43 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 172 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/172/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Jul 2018 09:41:55 + Build duration: 7 min 54 sec and counting JUnit Tests Name: (root)

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3523ba575b39: [KFilePlacesModel] Support pretty baloosearch URLs (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14043?vs=37553&id=37858 REVISION

D14042: Support special URLs for finding files of a certain type

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d02597aa9406: Support special URLs for finding files of a certain type (authored by broulik). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14042?vs=37552&id=37857

D14095: Fix DownloadDialog window margins to meet general theme margins

This revision was automatically updated to reflect the committed changes. Closed by commit R304:6c4fe2cf761d: Fix DownloadDialog window margins to meet general theme margins (authored by kossebau). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14095?vs=3769

D14097: Change default sort order in the download dialog to Rating

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. As an aside, I'd probably like this to end up being remembered between sessions, but this no different to the current state, and so outside the scope of this patch. As a default setting, yu

D14095: Fix DownloadDialog window margins to meet general theme margins

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In principle, this would really want to go via the designers, but at the same time it does seem that this was what was originally intended anyway. Shippit :) REPOSITORY R304 KNewStuff BR