apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision.
REVISION SUMMARY Upon close look I realised that there was a lot of allocations there. It turned out to be because it's allocating for the whole size of the value for every item. This way we just do it for the value of the element. It also includes a unit test that showed this escaping code never actually worked because the parser was choking on it. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D14162 AFFECTED FILES autotests/kconfigtest.cpp src/core/kconfiggroup.cpp src/core/kconfigini.cpp To: apol, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns