D13892: Restore compatibility of UDS::insert

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13892 To: jtamate, dfaure, #frameworks, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13892: Restore compatibility of UDS::insert

jtamate updated this revision to Diff 37170. jtamate marked 2 inline comments as done. jtamate added a comment. Added KIOCORE_DEPRECATED REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13892?vs=37163&id=37170 REVISION DETAIL https://phabricator.kde.org/D13892

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 68 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/68/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Thu, 05 Jul 2018 03:13:03 + Build duration: 2 min 42 sec and counting JUnit Tests Nam

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/44/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Jul 2018 03:13:03 + Build duration: 2 min 0 sec and counting JUnit Tests Name:

D13895: Fix off by one error in Cache::clear

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY beginRemoveRows args are int first, int last i.e If you have 1 entry

D13510: Add XDG WM Base support to our XDGShell API

davidedmundson added a comment. > Or would it make sense to wait on merging until Qt 5.12 with XDG WM Base support is available to have more test candidates? I don't think it's needed. The protocol is 90% the same it's mostly just awkward name changes. Same on the Qt side. We haven'

D13892: Restore compatibility of UDS::insert

dfaure added inline comments. INLINE COMMENTS > udsentry.h:148 > */ > void insert(uint field, const QString &value); > KIOCORE_DEPRECATED void... > udsentry.h:156 > */ > void insert(uint field, long long l); > KIOCORE_DEPRECATED void... REPOSITORY R241 KIO REVISIO

D13892: Restore compatibility of UDS::insert

jtamate updated this revision to Diff 37163. jtamate added a comment. Now better. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13892?vs=37161&id=37163 REVISION DETAIL https://phabricator.kde.org/D13892 AFFECTED FILES src/core/udsentry.cpp src/core/uds

D13892: Restore compatibility of UDS::insert

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks, aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Restore KIO backwards compatibility

D13885: taglibextractor: Restore extracting audio props without tags existing

kossebau added a comment. In D13885#287042 , @astippich wrote: > I just checked all the no-meta files. The reason that they did not cause the tests to fail is that they still have at least one tag defined that is not read (encoder settings for

D13813: Make this test work again with new uds implementation

dfaure added a comment. In D13813#287032 , @jtamate wrote: > > But ForwardingSlaveBase::prepareUDSEntry in KIO itself, uses insert() to replace UDS_URL, and in fact all of ForwardingSlaveBase should use replace(), as well as users of ForwardingS

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich added a comment. Sorry for causing the regressions and thanks for the fix! I just checked all the no-meta files. The reason that they did not cause the tests to fail is that they still have at least one tag defined that is not read (encoder settings for example). I think it would

D13813: Make this test work again with new uds implementation

jtamate added a comment. > But ForwardingSlaveBase::prepareUDSEntry in KIO itself, uses insert() to replace UDS_URL, and in fact all of ForwardingSlaveBase should use replace(), as well as users of ForwardingSlaveBase like kio_desktop. In ForwardingSlaveBase::prepareUDSEntry, it uses ins

D13813: Make this test work again with new uds implementation

dfaure added a comment. Albert, you are of course fully right. My reasoning was "in practice, [outside of strangely written tests such as the one here], there is zero reason to replace entries in a UDSEntry. All kioslaves either create a new UDSEntry for every file, or do reuse it after

D13869: [solid] Notify when interface to mounted fs is lost

bcooksley added a comment. Predicates are Solid's query language for searching for only the devices you are interested in. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, mich

D12820: Add KWayland virtual desktop protocol

romangg added a comment. In D12820#286961 , @mart wrote: > But.. how would you implement "move this window to a new desktop" in that case? This functionality is part of the (amended) plasma window management protocol and not of the new V

D13888: JavaScript: Add unicode escape `\u{1234\}`

nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nibags requested review of this revision. REVISION SUMMARY - ECMAScript 2015 Language Specification. 11.8.4 String Literals: https://ecma-internatio

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. Relative Qt Bug is here: https://bugreports.qt.io/browse/QTBUG-69277 Seems it's not their bug. And Qt guy commented there with: > ... You should, however, not save the window layout anymore then, because after closeEvent() any other widgets or child windows could

D12820: Add KWayland virtual desktop protocol

mart added a comment. In D12820#286960 , @romangg wrote: > The VD protocol was a pure "consumer" protocol before this last revision. Now it gets more complicated by putting requests into it for asking the compositor to change its configuration.

D12820: Add KWayland virtual desktop protocol

romangg added a comment. The VD protocol was a pure "consumer" protocol before this last revision. Now it gets more complicated by putting requests into it for asking the compositor to change its configuration. I thought this was supposed to go through Dbus. How do you plan to restrict s

D13880: [KMoreTools] Reduce menu hierarchy

ngraham added a comment. If it's important for uninstalled tools to be not always be visible, maybe what we should do is embed the //content// of the KNewStuff menu in Spectacle rather than exposing the whole thing as a sub-menu. Then we could make a few string changes, and it would be like

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. I'm aware that does not an idea, what is the purpose of Predicate. What should i search in Solid::Predicate::matches? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bruns, kde-framew

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 37149. mart added a comment. - add a request remove to the protocol - add api call to request removal of a desktop - requestCreate - remove window management features: - active() -> isactive() - requestEnterNewVirtualDesktop REPOSITORY R127 KWayla

D13885: taglibextractor: Restore extracting audio props without tags existing

kossebau created this revision. kossebau added reviewers: astippich, mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY 7f9de32eedff7f818

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#286816 , @ngraham wrote: > Or even this: > > Open SimpleScreenRecorder > - > Install Peek > Install Vokoscreen > - > Configur

D13869: [solid] Notify when interface to mounted fs is lost

bruns added a comment. In D13869#286746 , @broulik wrote: > Sure, but the device isn't "removed", so emitting a remove signal for something that is still there, is wrong, isn't it? Perhaps we could signal a removal if the device lost *all* its i

D13403: Android: Make it possible to override a target's APK directory

This revision was automatically updated to reflect the committed changes. Closed by commit R240:d6cc583f32a4: Android: Make it possible to override a target's APK directory (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13403?vs

D13884: [KMessageWidget] Update stylesheet when palette changes

ngraham accepted this revision. ngraham added a comment. Thanks, works as expected and I couldn't find any regressions. Code looks good. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: kde-frameworks-d

D13884: [KMessageWidget] Update stylesheet when palette changes

rjvbb accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13884: [KMessageWidget] Update stylesheet when palette changes

rjvbb added a comment. Otherwise LGTM (I also checked the in-app palette change myself: seems to work fine). INLINE COMMENTS > kmessagewidget.cpp:57 > void createLayout(); > +void applyStyleSheet(); > void updateSnapShot(); Nitpick: shouldn't this be called `setStyleSheet` or

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik updated this revision to Diff 37144. broulik added a comment. - Juggle it around a bit REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13884?vs=37143&id=37144 REVISION DETAIL https://phabricator.kde.org/D13884 AFFECTED FILES src/kmessage

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik created this revision. broulik added reviewers: Frameworks, rjvbb, ngraham, cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The colors are hardcoded rig

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#286820 , @ngraham wrote: > In D13880#286818 , @nicolasfella wrote: > > > Do you know if/how we can check if there is a handler for appstream://? So we can fal

D13880: [KMoreTools] Reduce menu hierarchy

ngraham added a comment. In D13880#286818 , @nicolasfella wrote: > Do you know if/how we can check if there is a handler for appstream://? So we can fall back to website if none is available I think you added that data and functionality

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#286800 , @ngraham wrote: > You are the most awesome person in the world today. Yay! > Here's a radical thought: get rid of the More menu entirely and move all of its content inline, like so:

D13880: [KMoreTools] Reduce menu hierarchy

ngraham added a comment. Or even this: Open SimpleScreenRecorder - Install Peek Install Vokoscreen - Configure... ...And clicking on the menu items for any of the Install options would open the `appstream:/

D13880: [KMoreTools] Reduce menu hierarchy

ngraham added a comment. You are the most awesome person in the world today. Here's a radical thought: get rid of the More menu entirely and move all of its content inline, like so: Installed: SimpleScreenRecorder - Not inst

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella created this revision. nicolasfella added reviewers: gregormi, dhaumann, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Skip 'More' submenu

D13386: haskell.xml: remove types from "prelude function" section

xialiyao added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13386 To: xialiyao, #framework_syntax_highlighting Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13373: haskell.xml: highlight promoted data constructors

xialiyao added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13373 To: xialiyao, #framework_syntax_highlighting Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13370: haskell.xml: add keywords family, forall, pattern

xialiyao added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13370 To: xialiyao, #framework_syntax_highlighting Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/25/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 04 Jul 2018 10:30:42 + Build duration: 36 min and counting JUnit Tests N

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/35/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Jul 2018 10:30:42 + Build duration: 9 min 30 sec and counting JUnit Tests Nam

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/63/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Jul 2018 10:30:42 + Build duration: 9 min 44 sec and counting JUnit Tests N

D13559: Fix some of cppcheck warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R127:84bc3cbd6102: Fix some of cppcheck warnings (authored by bshah). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13559?vs=37088&id=37135 REVISION DETAIL https://

D13627: [KIconThemes] Isolate private data from race conditions

anthonyfieroni added a reviewer: hein. anthonyfieroni added a subscriber: hein. anthonyfieroni added a comment. It happen again, so it's not a threading issue @hein when you hover grouped task in taskmanager end up with broken icons, sometimes, kcache in ~/.cache is generated at same that ic

D13510: Add XDG WM Base support to our XDGShell API

romangg added a comment. From my side I can't see anything wrong right now. Since we would merge after the next release anyways we have some time to correct any overlooked mistakes afterwards. Or would it make sense to wait on merging until Qt 5.12 with XDG WM Base support is available to ha

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. So about docs when interface is added it will notify again for mounting, i think that's the idea behind interfaces. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bruns, kde-framewor

D13869: [solid] Notify when interface to mounted fs is lost

broulik added a comment. Sure, but the device isn't "removed", so emitting a remove signal for something that is still there, is wrong, isn't it? Perhaps we could signal a removal if the device lost *all* its interfaces? But it probably doesn't in the unmount case. REPOSITORY R245 Solid

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. So if KFilePlacesModel wants to hide, i don't see how this will break things, it only notify when udisk2 loose interface to mounted fs. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc:

D13816: Make KItinerary work as a static library

vkrause added a comment. In D13816#286689 , @apol wrote: > It does have some advantages, I personally thing though that we shouldn't be compromising code readability and convenience for size, but I don't know how much better it is shared vs stat