kossebau created this revision. kossebau added reviewers: astippich, mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. kossebau requested review of this revision.
REVISION SUMMARY 7f9de32eedff7f81818145001fc38bbed01de1b7 <https://phabricator.kde.org/R286:7f9de32eedff7f81818145001fc38bbed01de1b7> made extraction of audio properties depending on the presence of any tag, by moving the extraction into the "if (!tags->isEmpty())" branch. This dependency is not necessary and prevents extracting the audio data for files without a tag (as sideeffect broke a test in baloo-widgets). Existing sample autotest files in no-meta/ subdir have not catched this, as they still had an ID3 tag content (TSSE), so tags->isEmpty() was false. Patch moves the existing files in a new subdir empty-meta/, to reflect they have some metadata but appear empty for the extraction. And adds a new test file with no metadata at all (for now only mp3 as I have no idea about metadata for the others formats) TEST PLAN New no-meta/test.mp3 sample file no longer fails with the test. Unit test extractortest in baloo-widgets also works again, as audio metadata is extracted again from a file with no id3 data. REPOSITORY R286 KFileMetaData BRANCH restoreaudiopropextractionwithouttags REVISION DETAIL https://phabricator.kde.org/D13885 AFFECTED FILES autotests/samplefiles/empty-meta/test.flac autotests/samplefiles/empty-meta/test.m4a autotests/samplefiles/empty-meta/test.mp3 autotests/samplefiles/empty-meta/test.mpc autotests/samplefiles/empty-meta/test.ogg autotests/samplefiles/empty-meta/test.opus autotests/samplefiles/no-meta/test.flac autotests/samplefiles/no-meta/test.m4a autotests/samplefiles/no-meta/test.mp3 autotests/samplefiles/no-meta/test.mpc autotests/samplefiles/no-meta/test.ogg autotests/samplefiles/no-meta/test.opus autotests/taglibextractortest.cpp src/extractors/taglibextractor.cpp To: kossebau, astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
