D13869: [solid] Notify when interface to mounted fs is lost

broulik added a comment. I don't think this is the right approach, technically the device isn't gone but filtered by the client (`KFilePlacesModel` and Device Notifier use a predicate to show only matching devices). This probably needs some "device changed" signal, or even cooler, in `Soli

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. Thank you! QEventLoop and creating window with new operator did it. Now the only problem is that no matter how i close the window from code it's not reproducing behavior. Only closing the window manually through window manager works. Have tried: QApplication::post

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 updated this revision to Diff 37131. maxrd2 added a comment. Added event loop to test and replicated wanted KMainWindow behavior. REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=36973&id=37131 BRANCH fix-window-state-save REVISION DETAIL

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added inline comments. INLINE COMMENTS > bruns wrote in udisksmanager.cpp:220 > This code needs some restructuring, and with the additional conditions, some > comments ... > > 1. `if (udi.isEmpty()) return;` > 2. you are whitelisting a lot of conditions (`... || .. || ...`) - are

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni updated this revision to Diff 37129. anthonyfieroni added a comment. 1. Return early when path is empty 2. Don't check for empty interfaces REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13869?vs=37110&id=37129 REVISION DETAIL https://phab

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/67/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Jul 2018 03:28:37 + Build duration: 13 min and counting JUnit Tests Name: (roo

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 43 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/43/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Jul 2018 03:28:37 + Build duration: 2 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 04 Jul 2018 03:28:19 + Build duration: 1 min 46 sec and counting JUnit Tests

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. Have tried doing QApplication::processEvents() and QApplication::sendPostedEvents(), between main window instances... didnt change Have removed mw.close() and clicked close buttons manually... didnt change Then have started all three in separate process using QProce

D13869: [solid] Notify when interface to mounted fs is lost

bruns added inline comments. INLINE COMMENTS > udisksmanager.cpp:220 > > -if (!udi.isEmpty() && (interfaces.isEmpty() || > device.interfaces().isEmpty())) { > +if (!udi.isEmpty() && (!dir.exists() || dir.isEmpty() || > interfaces.isEmpty() > +|| interfaces.contains(UD2_DBUS_INTERF

D13816: Make KItinerary work as a static library

apol added a comment. It does have some advantages, I personally thing though that we shouldn't be compromising code readability and convenience for size, but I don't know how much better it is shared vs static. If we need to have a list of `::init()` with all frameworks we depend on, i

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/36/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Jul 2018 22:07:58 + Build duration: 1 min 40 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/12/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 03 Jul 2018 22:07:58 + Build duration: 1 min 33 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/92/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Jul 2018 22:07:58 + Build duration: 1 min 36 sec and counting JUnit Tests

D13869: [solid] Notify when interface to mounted fs is lost

aacid resigned from this revision. aacid added a comment. Removing myself i don't think i know much/anything about solid, sorry REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D13808: Fix KMainWindow saving incorrect widget settings

aacid added a comment. In D13808#286480 , @maxrd2 wrote: > QTEST_MAIN already provides QApplication and event loop It does, but not between your NativeMainWindow mw; mw.close(); and as far as i understood the problem was wi

D13559: Fix some of cppcheck warnings

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fix-cppcheck REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks, aacid Cc: apol, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D13813: Make this test work again with new uds implementation

aacid added a subscriber: dfaure. aacid added a comment. In D13813#286358 , @jtamate wrote: > In D13813#286313 , @aacid wrote: > > > Did we break how KIO works and we're now going after the users of K

D13813: Make this test work again with new uds implementation

jtamate updated this revision to Diff 37119. jtamate retitled this revision from "make this test work again with new uds implementation" to "Make this test work again with new uds implementation". jtamate edited the summary of this revision. jtamate added a comment. Call items.append inside th

D13510: Add XDG WM Base support to our XDGShell API

davidedmundson added a dependent revision: D13530: Add XDG WmBase support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

davidedmundson removed a dependency: D13530: Add XDG WmBase support. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added a comment. In D13777#286557 , @rjvbb wrote: > > That just doesn't look good, sorry. > > Again, that's an argument one should avoid. It's too subjective. I myself find it looks much better (I'm biased against everything Breeze, s

D13698: Improve ECMAddAppIconMacro.

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R240 Extra CMake Modules BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerr

D13698: Improve ECMAddAppIconMacro.

apol added a comment. +1 Looks good to me, even tested. :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

cgiboudeaux added a comment. from a buildsystem pov, the change looks fine. Maybe someone has comments to add. @apol ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-framewor

D13813: make this test work again with new uds implementation

bruns added inline comments. INLINE COMMENTS > kfileitemmodeltest.cpp:1562 > +entry[i].insert(KIO::UDSEntry::UDS_ACCESS_TIME, 0); > +} > + if you move the `insert(UDS_NAME, ...)` and `insert(UDS_USER, ...)` in front of the loop, you can call `items.append(entry[i]...)` inside the lo

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb added a comment. Seems my reply per email went AWOL: This is a work-in-progress ticket, but I can change the title because it is indeed not just about reverting a regression. > That just doesn't look good, sorry. Again, that's an argument one should avoid. It's too subject

D13848: Fix device label with unknown size

This revision was automatically updated to reflect the committed changes. Closed by commit R245:cc7760bd33e4: Fix device label with unknown size (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13848?vs=37063&id=37111 REVISION DETAIL http

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni updated this revision to Diff 37110. anthonyfieroni added a comment. Add loop interface REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13869?vs=37108&id=37110 REVISION DETAIL https://phabricator.kde.org/D13869 AFFECTED FILES src/solid/dev

D13848: Fix device label with unknown size

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13848 To: broulik, davidedmundson Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni created this revision. anthonyfieroni added reviewers: broulik, cfeck, dfaure, aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY Mostly moun

D13866: Fix ResultModel item moving

This revision was automatically updated to reflect the committed changes. Closed by commit R159:75d6103df944: Fix ResultModel item moving (authored by davidedmundson). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13866?vs=37100&id=37106 REVIS

D13866: Fix ResultModel item moving

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. It works for me. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D13866 To: davidedmundson, ivan, hein Cc: hein, kde-frameworks-devel, m

D13866: Fix ResultModel item moving

davidedmundson added a comment. In an email > Without being able to test, I can only rely on the fact that the reasoning sounds ok and that it is authored by David 5. > Thanks, you have my blessing to push. > Ivan So will do so, unless someone objects soon. REPOSITORY

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 305 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/305/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Jul 2018 13:16:01 + Build duration: 9 min 18 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/60/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 03 Jul 2018 13:16:01 + Build duration: 6 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 154 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/154/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Jul 2018 13:16:01 + Build duration: 4 min 38 sec and counting JUnit Tests Name: (root)

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D13777#286439 , @rjvbb wrote: > Have you guys considered using the 4 colours in question only for the message text and outer fr

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

ngraham added a reviewer: VDG. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks, #vdg Cc: aacid, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added a comment. QTEST_MAIN already provides Application and event loop REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: wbauer, aacid, ngraham, kde

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/42/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Tue, 03 Jul 2018 11:54:16 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/66/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Tue, 03 Jul 2018 11:54:16 + Build duration: 2 min 18 sec and counting JUnit Tests Nam

D13124: Add Share action to Dolphin context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R495:efbb952f10b3: Add Share action to Dolphin context menu (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=37052&id=37102 R

D13867: [KMessageWidget] Pass widget to standardIcon()

cfeck added inline comments. INLINE COMMENTS > kmessagewidget.cpp:94 > closeAction->setToolTip(KMessageWidget::tr("Close message")); > - > closeAction->setIcon(q->style()->standardIcon(QStyle::SP_DialogCloseButton)); > + > closeAction->setIcon(q->style()->standardIcon(QStyle::SP_Dial

D13866: Fix ResultModel item moving

anthonyfieroni added a reviewer: ivan. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D13866 To: davidedmundson, ivan Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13867: [KMessageWidget] Pass widget to standardIcon()

broulik created this revision. broulik added reviewers: Frameworks, cfeck, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This way the style knows what widge

D13866: Fix ResultModel item moving

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The intention of this code is to find the new insertion index in the cac

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

rjvbb added a comment. Since there's been mention about aligning Kirigami and re: the (IMHO) controversial approach of using foreground (text) colours for background purposes: Have you guys considered using the 4 colours in question only for the message text and outer frame, keeping the

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a comment. In D10040#286064 , @davidedmundson wrote: > @dvratil want me to finish this? @davidedmundson Yes, I'd appreciate it. I won't have time to look into this any time soon, sorry :( REPOSITORY R127 KWayland REVIS

D13752: Build solidautoeject only on FreeBSD

broulik updated this revision to Diff 37098. broulik retitled this revision from "Kill solidautoeject" to "Build solidautoeject only on FreeBSD". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Keep it around for FreeBSD

D13752: Kill solidautoeject

adridg added a comment. - Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*. - Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running. - Insert CD, pick *open in file manager* from the de

D13601: OutputManagement fractional scaling

davidedmundson updated this revision to Diff 37097. davidedmundson added a comment. Rebase REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13601?vs=36919&id=37097 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13601 AFFECTED FILES autot