D13394: C++: update for c++20 and fix some syntax errors

2018-06-23 Thread jonathan poelen
jpoelen added a comment. I do not have a developer account, but I can do it. This is not a problem because I will contribute again. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-fram

D13700: implement reading of the replaygain tags

2018-06-23 Thread Stefan Brüns
bruns added a comment. "dB" is nothing more than deci-Bel, i.e. 0.1 Bel. You can convert the value to e.g. mB or uB. This looks unfamiliar, but is e.g. also used by the CRDA WiFi compliance tool. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astip

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-23 Thread Nicolas Fella
nicolasfella added a comment. @apol As soon as we land this we have two ways of sharing with KDE Connect. Should we just remove the FileItemActionPlugin from KDE Connect? Are there more applications than Dolphin using FIAPs? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabri

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-23 Thread Nicolas Fella
nicolasfella marked 3 inline comments as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-23 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36578. nicolasfella added a comment. Use JSON metadata and install in kf5/fileitemaction namespace REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34934&id=36578 BRANCH fiap REVISION DETAIL ht

D13700: implement reading of the replaygain tags

2018-06-23 Thread Alexander Stippich
astippich retitled this revision from "implement the replaygain tags" to "implement reading of the replaygain tags". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, ast

D13700: implement the replaygain tags

2018-06-23 Thread Alexander Stippich
astippich added a comment. I decided to store the values as string, including the "dB" unit. Another possibility would be to store them as floats, but this would require adjustments to baloo first. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13700 To: ast

D13700: implement the replaygain tags

2018-06-23 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the ability to read the

text search balloon background colour

2018-06-23 Thread René J . V . Bertin
Hi, Has the background colour used for text search balloons ("Continuing search from top" , for instance) been changed recently? Idem for the background colour in the search widget itself. I may be imagining this, but I'd swear the former has become some sort of light cobalt blue and the latter

D13570: Add workaround for labels with word-wrapping

2018-06-23 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13570 To: elvisangelaccio, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

2018-06-23 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > FindIcoTool.cmake:1 > +# Copyright 2017 Vincent Pinon > + - Missing doc - Missing license > ECMAddAppIcon.cmake:70 > > + > > #= extra line that shouldn't be the

D13698: Improve ECMAddAppIconMacro.

2018-06-23 Thread Dominik Schmidt
dschmidt edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

2018-06-23 Thread Dominik Schmidt
dschmidt updated this revision to Diff 36564. dschmidt added a comment. Update documentation again REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36563&id=36564 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde

D13698: Improve ECMAddAppIconMacro.

2018-06-23 Thread Dominik Schmidt
dschmidt updated this revision to Diff 36563. dschmidt added a comment. Updated documentation REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13698?vs=36562&id=36563 BRANCH app-icon-modernization REVISION DETAIL https://phabricator.kde.org/

D13698: Improve ECMAddAppIconMacro.

2018-06-23 Thread Dominik Schmidt
dschmidt edited the summary of this revision. dschmidt added reviewers: vpinon, apol, alexmerry. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D13698: Improve ECMAddAppIconMacro.

2018-06-23 Thread Dominik Schmidt
dschmidt edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

2018-06-23 Thread Dominik Schmidt
dschmidt created this revision. dschmidt added a reviewer: vonreth. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. dschmidt requested review of this revision. REVISION SUMMARY - Add support for SID

D13601: OutputManagement fractional scaling

2018-06-23 Thread Roman Gilg
romangg requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13601 To: davidedmundson, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

2018-06-23 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > outputdevice_interface.cpp:449 > SETTER(setScale, int, scale) > +SETTER(setScaleF, qreal, scale) > SETTER(setSubPixel, SubPixel, subPixel) The macro does not do a fuzzy compare. > outputdevice_interface.h:138 > void refreshRateChanged(int)

D13695: Make sure KLineEdit::clearButtonClicked is emitted

2018-06-23 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY Even when calling setClearButtonEnabled instead of setClearButtonShown Recently KLineEd

D13692: Add highlighting of JavaScript React

2018-06-23 Thread Nibaldo González
nibags added reviewers: Framework: Syntax Highlighting, dhaumann. nibags added a project: Framework: Syntax Highlighting. nibags edited subscribers, added: Framework: Syntax Highlighting; removed: kde-frameworks-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.k

D13692: Add highlighting of JavaScript React

2018-06-23 Thread Nibaldo González
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nibags requested review of this revision. REVISION SUMMARY Add syntax hightlighting of JSX files (ReactJS). Basically, this is JavaScript plus tags

KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.9 - Build # 37 - Fixed!

2018-06-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.9/37/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.9 Date of build: Sat, 23 Jun 2018 07:42:58 + Build duration: 1 min 37 sec and counting JUnit Tests

KDE CI: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 - Build # 57 - Fixed!

2018-06-23 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/57/ Project: Frameworks kfilemetadata kf5-qt5 SUSEQt5.10 Date of build: Sat, 23 Jun 2018 07:42:58 + Build duration: 1 min 31 sec and counting JUnit Test