michaeleden created this revision.
michaeleden added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
michaeleden requested review of this revision.
REVISION SUMMARY
Added `subseq` and `~subseq` operators whi
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
I did an accept to undo my earlier "Changes required" because Phab messed up
the lines I commented on, and because I realized I wasn't commenting on your
specific changes. Sorry about
anthonyfieroni updated this revision to Diff 36492.
anthonyfieroni added a comment.
Fix deadlock, icon of DragonPlayer and its related is not showed, i have no
idea why !?
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13627?vs=36487&id=36492
REVISION
lbeltrame requested changes to this revision.
lbeltrame added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcharselect-generate-datafile.py:41
Perhaps the diff view is wrong.. but the `return size` here (at this level of
nesting) wouldn't make the downstrea
cfeck requested review of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13641
To: cfeck, #frameworks, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
cfeck updated this revision to Diff 36490.
cfeck added a comment.
This revision is now accepted and ready to land.
len() of UTF-8 encoded bytearray is different than len(str).
Account for the difference when accumulating sizes.
Unicode Names are always ASCII, so here len(bytearray) == le
ngraham added a comment.
@mmustac very nice! Should we consider 191632 to be resolved, or wait until
you're implemented support for plain old non-`.desktop` files in `~/Templates`?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10363
To: mmustac, #frameworks, dfaure
Cc
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/299/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Thu, 21 Jun 2018 21:05:49 +
Build duration:
5 min 48 sec and counting
CONSOLE OUTPUT
[...trun
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/55/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
Date of build:
Thu, 21 Jun 2018 21:05:49 +
Build duration:
3 min 54 sec and counting
JUnit Tests
Name:
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/148/
Project:
Frameworks kio kf5-qt5 SUSEQt5.9
Date of build:
Thu, 21 Jun 2018 21:05:49 +
Build duration:
1 min 34 sec and counting
CONSOLE OUTPUT
[...trunca
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:de5ab5e74b4c: [KIO] Add support for XDG_TEMPLATES_DIR in
KNewFileMenu (authored by mmustac, committed by elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
anthonyfieroni updated this revision to Diff 36487.
anthonyfieroni added a comment.
Protect also dbus slot
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13627?vs=36486&id=36487
REVISION DETAIL
https://phabricator.kde.org/D13627
AFFECTED FILES
src
mtrescott edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D13643
To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
cfeck planned changes to this revision.
cfeck added a comment.
Needs more changes :/
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13641
To: cfeck, #frameworks, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mtrescott added a comment.
@ngraham I edited it to have a screenshot.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D13643
To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
mtrescott edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D13643
To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
anthonyfieroni updated this revision to Diff 36486.
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13627?vs=36376&id=36486
REVISION DETAIL
https://phabricator.kde.org/D13627
AFFECTED FILES
src/kiconloader.cpp
src/kiconloader.h
To: anthonyfieroni, d
dhaumann added a comment.
@jpoelen Can you push yourself, or do you still not have a KDE contributor
account?
REPOSITORY
R216 Syntax Highlighting
BRANCH
cpp
REVISION DETAIL
https://phabricator.kde.org/D13394
To: jpoelen, dhaumann, cullmann
Cc: cullmann, kde-frameworks-devel, michaelh
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13657
To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michae
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/56/
Project:
Frameworks kfilemetadata kf5-qt5 SUSEQt5.10
Date of build:
Thu, 21 Jun 2018 17:09:44 +
Build duration:
1 min 22 sec and counting
JUnit Tes
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:535de62bec16: implement the lyrics tag for
taglibextractor (authored by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13460?vs=35941&id=36476
RE
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.
REVISION SUMMARY
While at it, add alert support to Groovy comments too.
REPOSITORY
R216 Syntax Highlig
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:0e580ae9bdc5: Do not cancel old clipboard selection if it
is same as the new one. (authored by michalsrb, committed by fvogt).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricato
romangg accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13535
To: fvogt, #plasma, #frameworks, romangg
Cc: michalsrb, romangg, graesslin, kde-frameworks-devel, michaelh, ngraham,
vkrause abandoned this revision.
Restricted Application added a subscriber: kde-frameworks-devel.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D11099
To: vkrause, #frameworks
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns
ngraham added a comment.
Icon patches always need screenshots! :)
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D13643
To: mtrescott, #labplot, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
anthonyfieroni added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kiconloader.cpp:616
> Yeah, i saw it, i'll made a sequenceLock like this
>
> void sequenceLock(std::function func)
> {
> QMutexLocker locker(&mutex);
> func():
> }
> //usage
> S_D(d)->sequenceL
anthonyfieroni added inline comments.
INLINE COMMENTS
> dfaure wrote in kiconloader.cpp:616
> This locks and unlocks three times in a row, which is not only slightly
> inefficient, it also means that another thread could interleave calls in
> between, and get completely inconsistent state.
Yea
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
This is the wrong approach for thread safety (wrong level of locking). It
should come with a multithreaded unittest so it can be checked for safety (with
clang+tsan for instance).
mmustac added a comment.
@dfaure Can you commit these changes as I don't have the access to ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10363
To: mmustac, #frameworks, dfaure
Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/54/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
Date of build:
Thu, 21 Jun 2018 07:21:49 +
Build duration:
7 min 35 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/298/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Thu, 21 Jun 2018 07:21:49 +
Build duration:
5 min 28 sec and counting
JUnit Tests
Name: (root
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:34d6917f46a3: update trash docbook to 5.48 (authored by
lueck).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13226?vs=35227&id=36432
REVISION DETAIL
https://phabri
33 matches
Mail list logo
