KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 28 May 2018 06:28:41 + Build duration: 6 min 11 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 May 2018 06:28:41 + Build duration: 1 min 48 sec and counting JUnit Tests Nam

D12291: Accept file descriptor only from root owned process

chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:89 > i don't see why that would be horrible; as i pointed out multiple times > already, this change is redundant. one correction, though: add a code comment > here rather than extending the commit message. > > getso

KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 28 May 2018 06:05:36 + Build duration: 2 min 17 sec and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 May 2018 05:30:29 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Mon, 28 May 2018 05:30:29 + Build duration: 23 min and counting JUnit Tests

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 28 May 2018 05:30:29 + Build duration: 6 min 39 sec and counting

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. @dfaure can you have a look at this? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11685: Implement single click on line number to select line of text

dhaumann added a comment. Ok, thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #frameworks,

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/26/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 28 May 2018 03:31:06 + Build duration: 2 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 50 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/50/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 May 2018 03:31:06 + Build duration: 2 min 25 sec and counting JUnit Tests Nam

D12992: New elisa icon

ngraham added a comment. I like it! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: abetts, paullesur, januz, astippich, mgallien, alex-l, andreask, kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, myko

D12992: New elisa icon

abetts added a comment. I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that

D12992: New elisa icon

januz added a comment. In D12992#267534 , @lshoravi wrote: > I agree in that a circle doesn't have as much personality as maybe a > casette. I also agree in that the casette felt off when looking at it. > > How would something like an LP pl

D13150: Add ellipsis where appropriate

nicolasfella added a comment. Quote from VDG: If there will be further user input needed and a dialogue or similar popping up for it: needs ellipsis Therefore Pastebin would not need one, but I guess this is neglectable REPOSITORY R495 Purpose Library REVISION DETAIL https://phabr

D13150: Add ellipsis where appropriate

apol added a comment. In D13150#269388 , @nicolasfella wrote: > It's done this way in Email, KTP and KDE Connect already. If we add the ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if it would be inappropriate.

D13150: Add ellipsis where appropriate

nicolasfella added a comment. It's done this way in Email, KTP and KDE Connect already. If we add the ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if it would be inappropriate. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D131

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/25/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sun, 27 May 2018 22:31:51 + Build duration: 1 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/24/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sun, 27 May 2018 22:13:45 + Build duration: 18 min and counting JUnit Tests Name: (root

D12291: Accept file descriptor only from root owned process

ossi added inline comments. INLINE COMMENTS > chinmoyr wrote in fdreceiver.cpp:89 > I don't think making acceptConnection unconditionally true is a good idea. At > least it will make this patch look horrible. > Since getsocketopt conforms to posix, how about we check for __ unix __ , and > posi

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 27 May 2018 22:19:45 + Build duration: 6 min 55 sec and counting JUnit Tests Name

D13158: Fix i18n issues in Phabricator Plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:e052c9e88fd1: Fix i18n issues in Phabricator Plugin (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13158?vs=34984&id=35004#toc REPOSITORY R495 Purpose Library CH

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/48/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 27 May 2018 22:13:45 + Build duration: 1 min 46 sec and counting JUnit Tests Nam

D13160: Highlight the selected device in the KDE Connect plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:956efe4cd21f: Highlight the selected device in the KDE Connect plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13160?vs=34

D13151: Fix Phabricator icon

This revision was automatically updated to reflect the committed changes. Closed by commit R495:65f9072a2ec7: Fix Phabricator icon (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13151?vs=34976&id=35002#toc REPOSITORY R495 Purpose Library CHANGES SINCE LAST

D13160: Highlight the selected device in the KDE Connect plugin

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH highlight REVISION DETAIL https://phabricator.kde.org/D13160 To: nicolasfella, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13158: Fix i18n issues in Phabricator Plugin

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > phabricatorplugin_config.qml:125 > // use i18n().arg() to avoid showing the "%1" when inactive > -text: i18n("Summary of the update to %1:").arg(updateDR) >

D13150: Add ellipsis where appropriate

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. That's not correct. This is the plugin name. If you want elipsis add it onto the model's displayrole. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/

D13151: Fix Phabricator icon

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH phabicon REVISION DETAIL https://phabricator.kde.org/D13151 To: nicolasfella, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D11685: Implement single click on line number to select line of text

rkron added a comment. Yes, tested and it works. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: kwrite-devel, kde-frameworks-devel, dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #f

D13146: Drop old QString::null usage

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH drop-old-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D13146 To: elvisangelaccio, dfaure, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12992: New elisa icon

mgallien added a subscriber: paullesur. mgallien added a comment. @januz and @astippich I really understand your point of view about the current icon. I share your point of view the need to have an icon easy to differentiate from many other players. For example, I would like Elisa be easy to

D11685: Implement single click on line number to select line of text

dhaumann added a comment. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. Btw, did anyone test with dynamic word wrap enabled? Does it still work, when a line spans multiple view lines? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 27 May 2018 18:40:10 + Build duration: 11 min and counting JUnit Tests

D13160: Highlight the selected device in the KDE Connect plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH highlight REVIS

D12513: CVE-2018-10361: privilege escalation

cullmann added a comment. > What should we do with this? == REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, dfaure Cc: kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, fvogt, cullmann, michaelh, kevi

D13158: Fix i18n issues in Phabricator Plugin

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13158 To: nicolasfella, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D7245: Improve reStructuredText highlighting

dhaumann added a comment. @turbov ping again :-) After adding the reference file in autotest/input, run make test, and then call ./autotests/update-reference-data.sh in your build folder. Then git status will tell you which files are new and need to be added updated. REVISION DETAIL http

D10719: Highlighting for OpenSCAD

This revision was automatically updated to reflect the committed changes. Closed by commit R216:849aea294446: Highlighting for OpenSCAD (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10719?vs=28190&id=34985#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE

D13158: Fix i18n issues in Phabricator Plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When the diffs combo box is empty i18n re

D10719: Highlighting for OpenSCAD

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Looks good, will integrate! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https:/

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

sontolbonggol added a reviewer: mck182. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182 Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH ellipsis REVISION DETAIL https://phabricator.kde.org/D13150 To: nicolasfella, #vdg, apol, ngraham Cc: apol, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D13151: Fix Phabricator icon

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY use the right icon name REPOSITORY R49

D13150: Add ellipsis where appropriate

nicolasfella created this revision. nicolasfella added reviewers: VDG, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add ellipsis to actions that open up

D12291: Accept file descriptor only from root owned process

chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:89 > i wonder whether that shouldn't come with an unconditional acceptConnection = > true; then - now the compilation succeeds, but it will fail to operate. given > that the whole feature is redundant with moving the

D12895: WIP: Add KFileItemActionsPlugin

nicolasfella added inline comments. INLINE COMMENTS > sharefileitemaction.cpp:83 > +m_purposeMenu->model()->setInputData(QJsonObject{ > +{QStringLiteral("mimeType"), fileItemInfos.mimeType()}, > +{QStringLiteral("urls"), mimeType() can be empty which can cause problems (see D

D12291: Accept file descriptor only from root owned process

ossi added inline comments. INLINE COMMENTS > fdreceiver.cpp:89 > +#else > +#warning Cannot get socket credentials! > +#endif i wonder whether that shouldn't come with an unconditional acceptConnection = true; then - now the compilation succeeds, but it will fail to operate. given that the who

D12291: Accept file descriptor only from root owned process

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure, ossi Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr added a comment. @ossi would you mind reviewing this patch? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr updated this revision to Diff 34966. chinmoyr added a comment. Restricted Application added a subscriber: kde-frameworks-devel. I only realized now that after making the previous change I forgot to rebase. So uploading correct patch. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12745: Unify API for file descriptor sharing

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr updated this revision to Diff 34965. chinmoyr edited the summary of this revision. chinmoyr added a comment. Used std::string REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12745?vs=33821&id=34965 BRANCH master REVISION DETAIL https://phabricator

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr removed a dependency: D10273: Create proper SocketAddress. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: kde-frameworks-devel, dfaure, micha

D10273: Create proper SocketAddress

chinmoyr removed a dependent revision: D10409: In linux don't use abstract socket to share file descriptor. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks, dfaure, ossi Cc: ossi, thiago, dfaure, michaelh, ngraham, bruns

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr removed a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: kde-frameworks-devel, ngraham, fvogt, lbeltram

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr removed a dependency: D9966: [KIO] Fix issues with sharing of file descriptor. BRANCH master REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/23/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sun, 27 May 2018 11:03:24 + Build duration: 7 min 54 sec and counting JUnit Tests Name:

D9966: [KIO] Fix issues with sharing of file descriptor

ossi added a comment. Restricted Application added a subscriber: kde-frameworks-devel. this dependency tree is a mess. please remove deps to abandoned changes or unabandon what you actually still need, and linearize the history. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde

D13146: Drop old QString::null usage

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REPOSITORY R241 KIO BRANCH drop-old-code (br

D13120: fix i18n issues in framworks/purpose/plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R495:6ff87ba74f80: fix i18n issues in framworks/purpose/plugins (authored by lueck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13120?vs=34875&id=34964#toc REPOSITORY R495 Purpose Library CH

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sun, 27 May 2018 11:03:24 + Build duration: 2 min 6 sec and counting JUnit Tests Name

D12744: Add null pointer check when creating SocketAddress

ossi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13145: Check if destination exists also when pasting binary data

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY Currently we check whether the

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

ossi accepted this revision. ossi added a comment. This revision is now accepted and ready to land. note that the commit message needs a minor adjustment now. INLINE COMMENTS > chinmoyr wrote in fdreceiver.cpp:57 > So shall I commit this change separately right after pushing this patch? Or >

D12744: Add null pointer check when creating SocketAddress

chinmoyr updated this revision to Diff 34961. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. fixed the issues mentioned REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12744?vs=33831&id=34961 BRANCH master REVISION DETAIL https://phab

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr updated this revision to Diff 34960. chinmoyr added a comment. corrected the unlink position CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10410?vs=34959&id=34960 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10410 AFFECTED FILES src/ioslaves/file/fdre

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr added a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh, bru

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr updated this revision to Diff 34959. chinmoyr marked 2 inline comments as done. chinmoyr added a dependency: D9966: [KIO] Fix issues with sharing of file descriptor. chinmoyr added a comment. Do the first unlink in FdReceiver constructor CHANGES SINCE LAST UPDATE https://phabricato

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr added a comment. SocketAddress is used only in FdSender and FdRecevier. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:57 > that's a good addition, but it isn't logically part of this patch, because it > adds a new feature (cleanup at exit) instead of only refactoring. So shall I c

D12745: Unify API for file descriptor sharing

ossi added a comment. but so does using raw pointers. as the stl is available here anyway, it seems like the preferable abstraction layer. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr added a comment. In D12745#268946 , @ossi wrote: > why aren't you standardizing on std::string? that's cleaner than raw char pointers. > i know we discussed this before to some degree, but i don't remember the particulars. It

D12745: Unify API for file descriptor sharing

ossi added a comment. why aren't you standardizing on std::string? that's cleaner than raw char pointers. i know we discussed this before to some degree, but i don't remember the particulars. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. In D13124#268906 , @broulik wrote: > Have you seen D12895 ? I looked for similar patches with the #dolphin tag, but I didn't see

D12744: Add null pointer check when creating SocketAddress

ossi requested changes to this revision. ossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fdreceiver.cpp:34 > { > +const SocketAddress addr(m_path.toLocal8Bit().constData()); > +if (!addr.address()) { it would be more elegant to use m_path.toL

D10411: Create socket file in user's runtime directory

ossi accepted this revision. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. did you make sure that this is the only place where SocketAddress is used? INLINE COMMENTS > fdreceiver.cpp:41 > const SocketAddress addr(path.toStdString()); > if (bind(m_s

D13124: [RFC] Add Share action to Dolphin context menu

broulik added a comment. Have you seen D12895 ? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-