nicolasfella added inline comments.
INLINE COMMENTS
> sharefileitemaction.cpp:83
> + m_purposeMenu->model()->setInputData(QJsonObject{
> + {QStringLiteral("mimeType"), fileItemInfos.mimeType()},
> + {QStringLiteral("urls"),
mimeType() can be empty which can cause problems (see D12728
<https://phabricator.kde.org/D12728>). Not sure if it will here though
> sharefileitemaction.cpp:91
> +
> + QAction *menuAction = new
> QAction(QIcon::fromTheme(QStringLiteral("document-share")), i18nc("Share
> file", "Share"), this);
> + menuAction->setMenu(m_purposeMenu);
You can use m_purposeMenu->menuAction()
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D12895
To: broulik, #plasma, #vdg, apol
Cc: nicolasfella, elvisangelaccio, abetts, ngraham, kde-frameworks-devel,
michaelh, bruns
