KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/132/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 04:27:28 + Build duration: 55 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/25/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 04:27:12 + Build duration: 49 min and counting JUnit T

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/4/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 04:27:28 + Build duration: 34 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/2/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 04:27:13 + Build duration: 33 min and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 2 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/2/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 04:28:05 + Build duration: 29 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/6/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 03 Mar 2018 04:27:29 + Build duration: 28 min and counting CONSOLE OUTPUT St

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 152 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/152/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Mar 2018 04:27:29 + Build duration: 18 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/2/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 04:26:49 + Build duration: 10 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Mar 2018 04:26:49 + Build duration: 8 min 19 sec and counting JUnit Tests Name: (

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/57/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 03 Mar 2018 02:20:00 + Build duration: 10 min and counting JUnit Tests N

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/40/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 03 Mar 2018 02:20:00 + Build duration: 4 min 2 sec and counting JUnit Test

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/2/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 03 Mar 2018 02:20:00 + Build duration: 4 min 28 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/5/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 03 Mar 2018 00:29:38 + Build duration: 1 hr 23 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 AndroidQt5.9 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/68/ Project: Frameworks kcoreaddons kf5-qt5 AndroidQt5.9 Date of build: Sat, 03 Mar 2018 01:08:42 + Build duration: 4 min 42 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 AndroidQt5.9 - Build # 67 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.9/67/ Project: Frameworks kcoreaddons kf5-qt5 AndroidQt5.9 Date of build: Sat, 03 Mar 2018 00:54:48 + Build duration: 3 min 43 sec and counting CONSOLE OU

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. Ooh, I rather like the rotated window imagery. I agree with you that the left-most one looks best. I think we can live with a tiny bit of blurriness here. For small sizes, we could simply omit the window icon and just give it an arrow. REPOSITORY R266 Breeze

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. Thanks for the clarification! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas, ngraham Cc: abetts, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-moh

D10243: Improve visibility of disconnected Wi-Fi icons

andreask added a comment. the patches you linked are for breeze-icons. They are fine and will work. Here we are in plasma-framework in the breeze plasma theme that is complete separate and in plasma framework the change didn't go to master. plasma-framework/src/desktoptheme/breeze/icons/

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. In D10243#217119 , @andreask wrote: > I'm that much confuse maybe someone can make a screenshot what should be changed the opacity was already changed. I'm confused too, since this Phabricator revision is open and

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/4/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Fri, 02 Mar 2018 20:50:28 + Build duration: 1 hr 49 min and counting CONSOLE OUTPUT

D10980: updated hanle icon

ngraham added a comment. Screenshots, please! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10980 To: andreask, mart Cc: ngraham, #frameworks, michaelh

D10980: updated hanle icon

andreask added a reviewer: mart. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10980 To: andreask, mart Cc: #frameworks, michaelh

D10243: Improve visibility of disconnected Wi-Fi icons

andreask added a comment. I'm that much confuse maybe someone can make a screenshot what should be changed the opacity was already changed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas,

D10980: updated hanle icon

andreask created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. andreask requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10980 AFFECTED FIL

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. That's the black "network connected" icon, not a red version of the network disconnected icon. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas, ngraham Cc: abetts,

D10243: Improve visibility of disconnected Wi-Fi icons

abetts added a comment. In D10243#217109 , @andreask wrote: > F5736934: network.svgz > > sorry I'm not the maintainer for the breeze plasma theme and arc isn't my friend so I upload the svg file with the

D10243: Improve visibility of disconnected Wi-Fi icons

andreask added a comment. F5736934: network.svgz sorry I'm not the maintainer for the breeze plasma theme and arc isn't my friend so I upload the svg file with the red color here. If someone want to have the ? in read than push it to master. REPOSI

D10803: handle more tags in taglibextractor

ngraham added a comment. Phew, what a conversation! For the issue of the rating, perhaps we could sync the tag metadata with the baloo metadata, if the baloo rating metadata is already empty. I might even go so far as to overwrite the baloo rating metadata with the tag rating metadata;

D10803: handle more tags in taglibextractor

astippich added a comment. In D10803#216677 , @michaelh wrote: > In D10803#216419 , @astippich wrote: > > > While I think you have a point here, KFileMetaData sticked to singular names before, e.g.

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.9 - Build # 35 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.9/35/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Mar 2018 18:37:54 + Build duration: 15 min and counting JUnit Tests Na

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/3/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.9 Date of build: Fri, 02 Mar 2018 18:45:56 + Build duration: 2 min 16 sec and counting JUnit Tests Nam

KDE CI: Frameworks knewstuff kf5-qt5 SUSEQt5.9 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20SUSEQt5.9/2/ Project: Frameworks knewstuff kf5-qt5 SUSEQt5.9 Date of build: Thu, 01 Mar 2018 04:27:54 + Build duration: 1 day 14 hr and counting CONSOLE OUTPUT [

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 56 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/56/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Mar 2018 18:37:49 + Build duration: 4 min 19 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/131/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Mar 2018 17:13:24 + Build duration: 1 hr 28 min and counting JUnit Tests Name: (

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/3/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 02 Mar 2018 16:52:02 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/130/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Mar 2018 10:54:48 + Build duration: 6 hr 18 min and counting JUnit Tests Name: (

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 151 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/151/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Mar 2018 16:52:02 + Build duration: 19 min and counting JUnit Tests Name: (root) Fai

D10670: Reduce plasmashell frozen time

jtamate added a comment. In D10670#210702 , @jtamate wrote: > Updated the summary and added a comment ping? I would like to use the same comment and commit message in https://phabricator.kde.org/D10669 REPOSITORY R242 Plasma Framework

D10857: Change qSort to std::sort

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R241:7bb346ac2a4d: Change qSort to std::sort (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.or

Re: [Bug 390288] KIO/KDirModel: Kate crash while trying to save a new file to a Samba share

I can reproduce a similar crash with shares in a linux machine with long names like smb://127.0.0.1/Partage Mint-land mas largo aun pero sin caracteres raros/ smb://127.0.0.1/workgroup.Partage.Mint-land_mas_largo_aun123 4pero_sin0_caracteres_raros/ What I do: in Kate "Save copy as", click on netwo

D9844: Don't stat(/etc/localtime) between read() and write() copying files

jtamate abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9844 To: jtamate, #frameworks, dfaure Cc: fvogt, broulik, ngraham, #dolphin, michaelh

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. In D10937#216476 , @mart wrote: > one point tough: those are only going to work at a single size, as they are more vulnerable to become blurry when resized, so they would need other size versions as well (small sizes pro

D10857: Change qSort to std::sort

jtamate retitled this revision from "Change qSort to std::sort in simplifiedUrlList" to "Change qSort to std::sort". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10857 To: jtamat

D10857: Change qSort to std::sort in simplifiedUrlList

markg added a comment. In D10857#216725 , @dfaure wrote: > I cannot confirm that stable_sort is faster, on the contrary. http://www.davidfaure.fr/2018/qsort_performance.cpp updated, says (repeatedly) > "std::sort took: 5003 ms" > "std::stab

D1231: Add Remote Access interface to KWayland

jgrulich added a dependent revision: D10965: Add screen cast portal. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, schernikov,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/2/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 02 Mar 2018 10:54:48 + Build duration: 9 min 46 sec and counting JUnit Tests Name: (root) F

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/150/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 02 Mar 2018 10:54:48 + Build duration: 7 min 36 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/3/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Fri, 02 Mar 2018 10:54:48 + Build duration: 3 min 38 sec and counting CONSOLE OUTPUT

D10654: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl

This revision was automatically updated to reflect the committed changes. Closed by commit R241:27452b50d3b6: [KUrlNavigatorPlacesSelector] Use KFilePlacesModel::convertedUrl (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10654?vs=27529&id=2

Global Dependency and Release Freeze

Hi all, Due to a snowball of various dependency bumps and other tickets which have been submitted over the past few days, i'm imposing a global dependency freeze upon all KDE projects. In addition to this, due to the workload these also create, I am also imposing a total release freeze on all Ext

D10803: handle more tags in taglibextractor

michaelh added a comment. What do you think of using https://schema.org/AudioObject Vocabulary? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, spoorun, n

D10857: Change qSort to std::sort in simplifiedUrlList

jtamate added a comment. In D10857#216725 , @dfaure wrote: > I cannot confirm that stable_sort is faster, on the contrary. http://www.davidfaure.fr/2018/qsort_performance.cpp updated, says (repeatedly) > "std::sort took: 5003 ms" > "std::st

D10857: Change qSort to std::sort in simplifiedUrlList

dfaure added a comment. I cannot confirm that stable_sort is faster, on the contrary. http://www.davidfaure.fr/2018/qsort_performance.cpp updated, says (repeatedly) "std::sort took: 5003 ms" "std::stable_sort took: 7490 ms" Maybe on specific data (the actual filenames you're testing t

D10857: Change qSort to std::sort in simplifiedUrlList

dfaure added a comment. That is amazing, I could have sworn that the whole point of sort vs stable_sort was that stable_sort was potentially slower, which was the reason for sort to exist (when you don't care about the "stability" of equal items)... REPOSITORY R241 KIO REVISION DETAIL h

D10857: Change qSort to std::sort in simplifiedUrlList

jtamate added a comment. I've found the problem. The problem is qSort itself. Chaning qSort to qStableSort I've got normal times in the test case, select 50.000 files and pressing Shift+Supr. Also in the small test, the times, running under callgrind are: qSort: between 33148 and

D10803: handle more tags in taglibextractor

michaelh added inline comments. INLINE COMMENTS > taglibextractortest.cpp:82 > > QCOMPARE(resultFlac.properties().value(Property::Title), > QVariant(QStringLiteral("Title"))); > QCOMPARE(resultFlac.properties().value(Property::Artist), > QVariant(QStringLiteral("Artist"))); Just a

D10803: handle more tags in taglibextractor

michaelh added a comment. In D10803#216419 , @astippich wrote: > While I think you have a point here, KFileMetaData sticked to singular names before, e.g. author, where also multiple persons are possible. So I think we should keep that behavior