D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

kossebau added a comment. @broulik Seems to miss some include with Qt 5.7? build fails now on CI in the patched code: https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/15/ REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9312 To: brouli

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

mlaurent added a comment. Ok I understand why you don't have this problem you need to rebase patch with last kcoreaddons version. So code was added. Please rebase, make sure that it builds and upload patch. Regards. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kd

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 69 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/69/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Jan 2018 03:55:10 + Build duration: 20 min and counting JUnit Tests Name: (root) Fail

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 47 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/47/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 12 Jan 2018 03:55:10 + Build duration: 9 min 0 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 12 Jan 2018 03:55:11 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/27/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Jan 2018 03:55:11 + Build duration: 2 min 9 sec and counting JUnit Tests Na

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/25/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Fri, 12 Jan 2018 02:13:46 + Build duration: 7 min 4 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/30/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Jan 2018 02:13:46 + Build duration: 3 min 43 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 12 Jan 2018 02:13:46 + Build duration: 2 min 58 sec and counting JUnit Tes

D9823: Optimize: use QMetaObject::invokeMethod with functor

mpyne accepted this revision. mpyne added a comment. LGTM REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol, mpyne Cc: mpyne, #frameworks

D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker added a comment. In https://phabricator.kde.org/D9424#181538, @apol wrote: > @kfunk, @vonreth Will craft applications also benefit from this? yes > Or is it solved in a different way there? no REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator

D9424: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

habacker retitled this revision from "Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'" to "Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file". habacker edited the summary of this revision. habacker ed

D9424: Fix 'Exec line in kglobalaccel5 service file must not have any path prefix on Windows'

habacker updated this revision to Diff 25187. habacker added a comment. - Use cmake macro from kdbusaddons git repo - Set FIXED-IN version to 5.43.0 because it requires kdbusaddons version 5.43.0 REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9424?v

D9830: Fix KFilePreviewGenerator::LayoutBlocker

fvogt edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9830 To: fvogt, #frameworks, dfaure

D9830: Fix KFilePreviewGenerator::LayoutBlocker

fvogt created this revision. fvogt added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY QAbstractItemViews does layout in a timer event handler, to avoid unnecessary layout calculations. Changes which

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. Please test this for the QFSW backend too and post a benchmark result comparison (and include the change if beneficial). The QFSW backend is used on other Unices, Mac and on Linux when the inotify backend cannot be used (NFS, for instance). INLINE COMMENTS > kdir

D9793: Fall back to language name for translations lookup if locale name fails

wbauer added a comment. In https://phabricator.kde.org/D9793#189595, @safaalfulaij wrote: > > Why is this an issue? > > There's no difference really in loading ar/LC_MESSAGES/xxx.qm and LC_MESSAGES/xxx_ar.qm (or something like that), i.e. you would have the same problem if all transla

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb requested changes to this revision. rjvbb added a comment. This revision now requires changes to proceed. > @rjvbb this patch just shows that KDirWatch has tons of performance issues that need to be fixed here. That may be an open door but the plural of anecdote is not data. You fou

D9793: Fall back to language name for translations lookup if locale name fails

safaalfulaij added a comment. > Why is this an issue? > There's no difference really in loading ar/LC_MESSAGES/xxx.qm and LC_MESSAGES/xxx_ar.qm (or something like that), i.e. you would have the same problem if all translations would be in the same folder. Well, we were to simplify thi

D9829: Don't create 2 msgbox (one of them crashes) when can't change rights

anthonyfieroni added a comment. What is job->error() ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9829 To: jtamate, #frameworks, anthonyfieroni, dfaure

Re: Making Purpose part of KF5

El dijous, 11 de gener de 2018, a les 2:15:06 CET, Aleix Pol va escriure: > On Thu, Nov 9, 2017 at 5:10 PM, Aleix Pol wrote: > > Hi, > > I would like to include Purpose [1] into the frameworks umbrella. > > It's been around for a while now, used by few applications and > > reasonably stable. > >

D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )

velurimithun added a comment. Yeah, I have rebuilt it !! **NO ERRORS** compiling well. I'm not getting any errors like that :/ I could see few warnings but not in kaboutdatatest.cpp I'm compiling it in Qt 5.9.3 version. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabri

D9829: Don't create 2 msgbox (one of them crashes) when can't change rights

jtamate created this revision. jtamate added reviewers: Frameworks, anthonyfieroni, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY When copying files in a filesystem where the permissions can not be changed do not generat

D9793: Fall back to language name for translations lookup if locale name fails

wbauer added a comment. In https://phabricator.kde.org/D9793#189494, @safaalfulaij wrote: > I went through Qt code, as Qt applications are opened with my language correctly where KF ones (those with QM) don't. I tested with your ar_BH locale meanwhile, and it is fixed too, i.e. L

D9770: Optimization of byteSize(double size)

jtamate added a comment. In https://phabricator.kde.org/D9770#189242, @mwolff wrote: > 10 calls per second sound fine to me, that shouldn't be a big performance issue at all. Yes, that is what I tough, but as soon as I changed the code, dolphin(file.so) started to copy as fast as

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff added a comment. https://codereview.qt-project.org/#/c/216497/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

chinmoyr added a comment. In https://phabricator.kde.org/D6830#189165, @dfaure wrote: > Doesn't execWithElevatedPrivilege call ERR_USER_CANCELED on cancel? It definitely does. And here I was thinking KIO has gone nuts. *biggest facepalm* REPOSITORY R241 KIO BRANCH 6830 RE

D9793: Fall back to language name for translations lookup if locale name fails

safaalfulaij added a comment. I went through Qt code, as Qt applications are opened with my language correctly where KF ones (those with QM) don't. The whole issue is that we have each locale's translations in a separate folder (`ar/LC_MESSAGES`, `en/LC_MESSAGES`, `de/LC_MESSAGES`, etc.)

D9823: Optimize: use QMetaObject::invokeMethod with functor

apol added a comment. In https://phabricator.kde.org/D9823#189491, @mwolff wrote: > cleaner, yes. but also much slower. contrary to the other code-paths, the `QTimer::singleShot` taking a functor is not optimized (yet?) for `timeout == 0`... Oh well... `¯\_(ツ)_/¯` REPOSITORY R

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff added a comment. cleaner, yes. but also much slower. contrary to the other code-paths, the `QTimer::singleShot` taking a functor is not optimized (yet?) for `timeout == 0`...F5638638: Screenshot_20180111_170829.png REPOSITORY R244 KCoreAddons

D9823: Optimize: use QMetaObject::invokeMethod with functor

apol added a comment. Maybe it would be cleaner to do `QTimer::singleShot(0, c.instance, lambda)`. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff updated this revision to Diff 25172. mwolff added a comment. This revision is now accepted and ready to land. make compile against older Qt REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9823?vs=25170&id=25172 REVISION DETAIL https://phabricat

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff planned changes to this revision. mwolff added a comment. requires 5.10, so I can't commit this as-is... REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D9808: fix incorrect emission of signals by kLineEdit

dweatherill added a comment. In https://phabricator.kde.org/D9808#189467, @dfaure wrote: > Sorry to be a pain, but can you also update the description, which still talks about textEmitted()? > > (FYI using `arc diff` to upload the patch would also provide context, but OK, I can open

D9808: fix incorrect emission of signals by kLineEdit

dweatherill edited the summary of this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808 To: dweatherill, #frameworks, dhaumann, cullmann Cc: mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodge

D9823: Optimize: use QMetaObject::invokeMethod with functor

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9823 To: mwolff, dfaure, apol Cc: #frameworks

D9819: Verify that the path is valid and writable

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9819 To: mwolff, dfaure, apol Cc: #frameworks

D9820: Verify that the file was opened

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9820 To: mwolff, dfaure, apol Cc: #frameworks

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

mwolff added a comment. @rjvbb this patch just shows that KDirWatch has tons of performance issues that need to be fixed here. Please do run the new benchmarks on your benchmark with your backend, profile them, optimize them. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricat

D9808: fix incorrect emission of signals by kLineEdit

dfaure added a comment. Sorry to be a pain, but can you also update the description, which still talks about textEmitted()? (FYI using `arc diff` to upload the patch would also provide context, but OK, I can open the file locally to find out about the context for those unittest changes.

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

mwolff added reviewers: rjvbb, KDevelop. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9824 To: mwolff, dfaure, rjvbb, #kdevelop Cc: #frameworks

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This greatly reduces the on-CPU time of the benchNotifyWatcher. T

D9819: Verify that the path is valid and writable

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This prevents strange errors when trying to run the test when the

D9823: Optimize: use QMetaObject::invokeMethod with functor

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY When using this method with a string argument, the method would nee

D9821: Use QSignalSpy::wait instead of QTest::wait where possible

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This allows the test to finish a bit earlier in the best case. I.

D9822: Add benchmarks for KDirWatch

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY All benchmarks create a relatively large directory tree and then

D9820: Verify that the file was opened

mwolff created this revision. mwolff added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY The assertion is disabled in release mode, but the verify will show

D9808: fix incorrect emission of signals by kLineEdit

dweatherill added a comment. from the git history I believe this issue has been in place since before 5.0. Agree the breakage is worrying, but at the moment the existence of this bug is breaking stuff I think. At the very least, if the behaviour can't be changed, the documentation should

D9808: fix incorrect emission of signals by kLineEdit

dweatherill updated this revision to Diff 25163. dweatherill added a comment. this updated diff removes the rename, just has fixed and extended unit tests and the one line fix for not emitting the textChanged signal spuriously. REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https:

D9815: [KFileItem] Use "emblem-shared" for shared files

apol added a comment. +1, definitely a step forward, although it seems a bit weird that a shared emblem and action is the same icon, no? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9815 To: broulik, #frameworks, dfaure, andreask Cc: apol

D9808: fix incorrect emission of signals by kLineEdit

dfaure added inline comments. INLINE COMMENTS > dweatherill wrote in klineedit_unittest.cpp:87 > ok, it's unclear, but not a typo. > According to QLineEdit documentation, clear() should only emit textChanged > when there is actually text to clear. > > So the word "cleared" kind of implies "only

D9808: fix incorrect emission of signals by kLineEdit

dweatherill added inline comments. INLINE COMMENTS > dweatherill wrote in klineedit.cpp:184 > you are absolutely right! My mistake, I intended to rename it to textEdited, > as this is what the signal we actually want to emit from QLineEdit is, and > the name textEmitted is spurious. > > I do t

D9808: fix incorrect emission of signals by kLineEdit

dweatherill added inline comments. INLINE COMMENTS > mwolff wrote in klineedit_unittest.cpp:87 > typo: if the text box is already clear*ed* ok, it's unclear, but not a typo. According to QLineEdit documentation, clear() should only emit textChanged when there is actually text to clear. So the

D9815: [KFileItem] Use "emblem-shared" for shared files

broulik created this revision. broulik added reviewers: Frameworks, dfaure, andreask. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY "network-workgroup" might work at 16px size but it's semantically incorrect and when rendered at

D9814: [KIconLoader] Take into account devicePixelRatio for overlays

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Keeps them from being painted outside view and scales them with the image they're supposed to be pa

KDE CI: Frameworks kdeclarative kf5-qt5 SUSEQt5.7 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20SUSEQt5.7/15/ Project: Frameworks kdeclarative kf5-qt5 SUSEQt5.7 Date of build: Thu, 11 Jan 2018 10:36:05 + Build duration: 1 min 41 sec and counting CONSOLE OUTPUT

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:5c9eab26ad7b: [ConfigPropertyMap] Don't emit valueChanged on initial creation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9312?vs=238

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9312 To: broulik, #plasma, hein Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9812: [Icon Item] Treat sources starting with a slash as local file

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9812 To: broulik, #plasma, hein, mwolff Cc: mwolff, plasma-devel, #frameworks, ZrenBot, pro

Re: [kde-build-metadata] /: Introduce temporary dependency on KCoreaddons for Breeze Icons.

On jeudi 11 janvier 2018 11:18:43 CET Ben Cooksley wrote: > On Thu, Jan 11, 2018 at 12:20 PM, David Faure wrote: > > On jeudi 11 janvier 2018 00:17:24 CET Ben Cooksley wrote: > >> Git commit 08e9c4955681587c0391b21550a52525ce37739b by Ben Cooksley. > >> Committed on 10/01/2018 at 23:17. > >> Pushe

Re: [kde-build-metadata] /: Introduce temporary dependency on KCoreaddons for Breeze Icons.

On Thu, Jan 11, 2018 at 12:20 PM, David Faure wrote: > On jeudi 11 janvier 2018 00:17:24 CET Ben Cooksley wrote: >> Git commit 08e9c4955681587c0391b21550a52525ce37739b by Ben Cooksley. >> Committed on 10/01/2018 at 23:17. >> Pushed by bcooksley into branch 'master'. >> >> Introduce temporary depen

D9812: [Icon Item] Treat sources starting with a slash as local file

broulik updated this revision to Diff 25144. broulik added a comment. - Incorporate suggestions by milian REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9812?vs=25141&id=25144 REVISION DETAIL https://phabricator.kde.org/D9812 AFFECTED

D9312: [ConfigPropertyMap] Don't emit valueChanged on initial creation

broulik added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D9312 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9812: [Icon Item] Treat sources starting with a slash as local file

mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. lgtm in general, but can be cleaned up INLINE COMMENTS > iconitem.cpp:154 > +// If a file:// URL or a absolute path is passed, take the image > pointed by that from disk

D9812: [Icon Item] Treat sources starting with a slash as local file

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY We have a special case for sources star

D9770: Optimization of byteSize(double size)

mwolff added a comment. 10 calls per second sound fine to me, that shouldn't be a big performance issue at all. Are you measuring performance of a debug build or of a release build? Can you specify the exact commands you are profiling? Is the performance better when you are using KFormat her

D9808: fix incorrect emission of signals by kLineEdit

mwolff added inline comments. INLINE COMMENTS > klineedit_unittest.cpp:87 > + > +//if text box is already clear, calling clear() shouldn't emit > +// any more signals typo: if the text box is already clear*ed* > anthonyfieroni wrote in klineedit.cpp:63 > You mean this is

D9808: fix incorrect emission of signals by kLineEdit

dfaure added inline comments. INLINE COMMENTS > klineedit.cpp:184 > > -q->connect(q, SIGNAL(textChanged(QString)), q, > SLOT(_k_textChanged(QString))); > +q->connect(q, SIGNAL(textChanged(QString)), q, > SLOT(_k_textEmitted(QString))); > } Why did you rename the slot? I don't unders