This revision was automatically updated to reflect the committed changes.
Closed by commit R240:fd60f2b893d0: Add the description tag to the generated
pkgconfig files (authored by cgiboudeaux).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9056?vs
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
pkgconfig-part1
REVISION DETAIL
https://phabricator.kde.org/D9056
To: cgiboudeaux, dfaure, apol
Cc: #frameworks, #build_system
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 06:29:54 +
Build duration:
3 min 6 sec and counting
JUnit Tests
Name:
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Heh this goes back to 2000 and the make_it_cool branch for kio, with non-STL
iterator api, I think the return value was just missing from Qt back then ;)
REPOSITORY
R241 KIO
REVISION DET
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 06:29:54 +
Build duration:
2 min 40 sec and counting
JUnit Tests
Na
dfaure added a comment.
The commit log needs to have a one-line summary, like "Compile with stricter
compilation flags".
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D9049
To: mlaurent, dfaure
Cc: apol, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R309:03d24088ea68: Fix compile with QT_NO_CAST_FROM_ASCII
(authored by mlaurent).
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9044?vs=23114&id=23160
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> mlaurent wrote in kactioncollectiontest.cpp:235
> we use latin1 for kstandardaction::name no ? For me it seems that we didn"t
> add a no latin1 name for it.
Yeah, standard action names are definitely latin1.
Actions defined by applications, howev
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R309 KService
BRANCH
fix_compile_QT_NO_CAST_FROM_ASCII
REVISION DETAIL
https://phabricator.kde.org/D9044
To: mlaurent, dfaure
Cc: #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 06:00:52 +
Build duration:
1 min 54 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 06:00:52 +
Build duration:
1 min 52 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/38/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 06:00:52 +
Build duration:
1 min 24 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 05:58:02 +
Build duration:
2 min 15 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/37/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 05:58:48 +
Build duration:
1 min 23 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 05:54:06 +
Build duration:
3 min 55 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 05:55:54 +
Build duration:
1 min 17 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/36/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 05:54:06 +
Build duration:
1 min 53 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 05:54:06 +
Build duration:
1 min 37 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.7
Date of build:
Thu, 30 Nov 2017 03:46:48 +
Build duration:
17 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
Date of build:
Thu, 30 Nov 2017 03:46:48 +
Build duration:
12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/59/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 30 Nov 2017 03:46:48 +
Build duration:
9 min 4 sec and counting
JU
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/19/
Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 29 Nov 2017 20:11:37 +
Build duration:
1 hr 16 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.7/45/
Project:
Frameworks baloo kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 29 Nov 2017 20:38:32 +
Build duration:
13 min and counting
JUnit Tests
Name: (roo
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/153/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 29 Nov 2017 20:11:10 +
Build duration:
34 min and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Wed, 29 Nov 2017 20:38:32 +
Build duration:
7 min 26 sec and counting
JUnit Tests
Name: (r
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/103/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 29 Nov 2017 20:10:52 +
Build duration:
32 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Wed, 29 Nov 2017 20:38:32 +
Build duration:
4 min 14 sec and counting
JUnit Tests
Name: (roo
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/13/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Wed, 29 Nov 2017 20:10:27 +
Build duration:
26 min and counting
JUnit Tests
Name: (root) Fail
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/13/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Wed, 29 Nov 2017 20:10:27 +
Build duration:
24 min and counting
JUnit Tests
Name: (root) Failed
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Wed, 29 Nov 2017 20:10:52 +
Build duration:
23 min and counting
JUnit Tests
Na
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Wed, 29 Nov 2017 20:10:52 +
Build duration:
22 min and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/153/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 29 Nov 2017 20:10:27 +
Build duration:
20 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/10/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Wed, 29 Nov 2017 20:11:10 +
Build duration:
12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 29 Nov 2017 20:11:10 +
Build duration:
10 min and counting
JUnit Test
smithjd added a comment.
In https://phabricator.kde.org/D8098#173418, @ngraham wrote:
> Excellent! @smithjd, is this ready to go in now, or are you still making
more changes?
There are still known problems with tagged directory copies. Overall however
it's in a pretty good state
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20FreeBSDQt5.7/44/
Project:
Frameworks baloo kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 29 Nov 2017 19:04:26 +
Build duration:
9 min 3 sec and counting
CONSOLE OUTPUT
[.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Wed, 29 Nov 2017 19:04:26 +
Build duration:
3 min 29 sec and counting
JUnit Tests
Name: (r
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/2/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
Date of build:
Wed, 29 Nov 2017 19:04:27 +
Build duration:
1 min 55 sec and counting
CONSOLE OUTPUT
[...trun
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:16664fccb7b7: Strip down and re-write the baloo tags KIO
slave (authored by smithjd).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8098?vs=23146&id=23147#toc
REPOSITORY
R293 Baloo
CHANGES
smithjd updated this revision to Diff 23146.
smithjd added a comment.
- Fix generating previews copies the file to tmp.
- Fix tag navigation display labels in Dolphin.
- Stricter url validation.
- Create a full url instead of only a path.
- Check if the destination file already has the
anthonyfieroni abandoned this revision.
anthonyfieroni added a comment.
QAction dependency cannot be dropped.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9048
To: anthonyfieroni, davidedmundson, apol
Cc: graesslin, broulik, #frameworks
dhaumann added a comment.
In general this patch should be OK.
Could you try with Kate search warp behavior as well? KTextEditor relies on
correct behaviors here heavily.
INLINE COMMENTS
> kmessagewidgetautotest.cpp:32-40
> +#define CHECK_FULLY_VISIBLE \
> +QVERIFY(w.isVisible()); \
> +
renatoo added a comment.
In https://phabricator.kde.org/D8243#173442, @broulik wrote:
> Can we expose the group type enum in the model in addition to the name, so
I can do some filtering in e.g. task manager?
This will be exposed by this mr:
https://phabricator.kde.org/D8367#chan
cgiboudeaux created this revision.
cgiboudeaux added reviewers: dfaure, apol.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
pkgconfig complains when the .pc file doesn't have a description. eg
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in CMakeLists.txt:36
> A depend has widgets on a public interface, i guess
If KGlogalAccel needs Widgets, Widgets must stay.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9048
To: anthonyfi
broulik added a comment.
Can we expose the group type enum in the model in addition to the name, so I
can do some filtering in e.g. task manager?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg, ngraham
Cc: broulik, mar
broulik edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9054
To: broulik, #frameworks, dfaure
broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
TEST PLAN
(I didn't git graft the original commit which might explain this?) But
`shouldSkip()` doesn't change any state so I don't see how starting all over
could be
ngraham added a comment.
Excellent! @smithjd, is this ready to go in now, or are you still making more
changes?
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham,
mlaurent added inline comments.
INLINE COMMENTS
> apol wrote in kactioncollectiontest.cpp:235
> I'd expect these to be Utf8.
we use latin1 for kstandardaction::name no ? For me it seems that we didn"t add
a no latin1 name for it.
> apol wrote in smtp.cpp:226
> Are you sure it shouldn't be `fro
apol added a comment.
Okay, I gave it another unsuccesful go. Will have to test together if you
have some time.
I tried putting everything in a different prefix like this:
KConfig:
cmake -DCMAKE_INSTALL_PREFIX=/home/user/prefixfw
-DCMAKE_PREFIX_PATH="$QT_ANDROID;/opt/kdeandroid-
apol added inline comments.
INLINE COMMENTS
> kactioncollectiontest.cpp:235
> QVERIFY(a->parent() == &collection);
> -QVERIFY(collection.action(KStandardAction::name(KStandardAction::Undo))
> == a);
> +
> QVERIFY(collection.action(QString::fromLatin1(KStandardAction::name(KStandardA
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.9/21/
Project:
Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 29 Nov 2017 13:27:00 +
Build duration:
5 min 16 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.9/20/
Project:
Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 29 Nov 2017 12:59:05 +
Build duration:
4 min 20 sec and counting
mlaurent added a reviewer: dfaure.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D9049
To: mlaurent, dfaure
Cc: #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- DQT_NO_CAST_FROM_BYTEARRAY
- QT_NO_CAST_FROM_ASCII
- QT_NO_CAST_TO_ASCII
REPOSITORY
R263 KXmlGui
BRANCH
fix_strict_compile
REVI
anthonyfieroni added inline comments.
INLINE COMMENTS
> davidedmundson wrote in CMakeLists.txt:36
> lib still uses widgets, I doubt this will compile.
> If it does, it's because it's pulled in from something else.
>
> (in fact the runtime links against them too, but for a hidden window to
> cap
anthonyfieroni updated this revision to Diff 23132.
anthonyfieroni added a comment.
It compiles.
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9048?vs=23126&id=23132
REVISION DETAIL
https://phabricator.kde.org/D9048
AFFECTED FILES
CMakeLists.txt
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:36
> set(REQUIRED_QT_VERSION 5.7.0)
> -find_package(Qt5 ${REQUIRED_QT_VERSION} CONFIG REQUIRED DBus Widgets)
> +find_package(Qt
broulik added a comment.
`QApplication` is for widgets, so you should keep it a `QGuiApplication` and
just remove the widgets dependency.
(The naming is confusing, indeed, it's QCoreApplication → QGuiApplication →
QApplication)
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://p
anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9048
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R268:d965b98304d0: kglobalacceld: Avoid loading an icon loader
for no reason (authored by davidedmundson).
REPOSITORY
R268 KGlobalAccel
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9047?vs=23
davidedmundson added a comment.
> Won't it be loaded nevertheless with the QPT?
Hotspot says it doesn't.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9047
To: davidedmundson, apol
Cc: apol, #frameworks
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Won't it be loaded nevertheless with the QPT?
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9047
To: davidedmundson, apol
Cc: apol, #frameworks
Hello,
in https://bugs.kde.org/386933, the bug reporter mentions the pkgconfig file
name shall match the library one.
Do we have a policy about the pkgconfig stuff ?
Only a couple frameworks install such files with different scheme (Baloo
(uppercase B), libKF5Attica (library name), phonon4qt5.
Hi all,
Over the past 24 hours we have received initial warning notifications
that a disk in our bulk storage server has begun to show signs of
failure. We have now begun the process of having this disk replaced,
following which we will need to rebuild the RAID array.
As a consequence of this at
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
We know this is a QGuiApplication app, so we know it doesn't have any
widgets we also know it doesn't use QtQuick anywhere.
The
On Wed, Nov 29, 2017 at 9:43 AM, Christophe Giboudeaux
wrote:
> Hello,
>
> in https://bugs.kde.org/386933, the bug reporter mentions the pkgconfig file
> name shall match the library one.
I cannot find any such requirement. It is *suggested* to have one
config per lib with the config name matchin
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/58/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 29 Nov 2017 06:45:35 +
Build duration:
2 hr 11 min and counting
JU
anthonyfieroni added a comment.
It looks good.
INLINE COMMENTS
> kmessagewidget.cpp:348
> +d->content->move(0, 0);
> +setFixedHeight(d->content->height());
> +}
Those it should be
setFixedHeight(sizeHint().height());
REPOSITORY
R236 KWidgetsAddons
REVIS
aacid added a comment.
Ping
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8964
To: aacid, #frameworks
Cc: #frameworks
71 matches
Mail list logo
