dhaumann added a comment.
In general this patch should be OK.
Could you try with Kate search warp behavior as well? KTextEditor relies on
correct behaviors here heavily.
INLINE COMMENTS
> kmessagewidgetautotest.cpp:32-40
> +#define CHECK_FULLY_VISIBLE \
> + QVERIFY(w.isVisible()); \
> + QCOMPARE(w.height(), w.sizeHint().height()); \
> + QCOMPARE(w.findChild<QWidget*>(QStringLiteral("contentWidget")) ->pos(),
> QPoint(0, 0));
> +
> +#define CHECK_FULLY_NOT_VISIBLE \
> + QCOMPARE(w.height(), 0); \
Hm, possibly an inline function instead of macros?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8964
To: aacid, #frameworks
Cc: dhaumann, anthonyfieroni, #frameworks
