turbov updated this revision to Diff 18322.
turbov added a comment.
Remove spaces around ``
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7175?vs=17801&id=18322
REVISION DETAIL
https://phabricator.kde.org/D7175
AFFECTED FILES
data/generators/cmake-gen.sh
data/generators/cmak
turbov updated this revision to Diff 18321.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7245?vs=17993&id=18321
REVISION DETAIL
https://phabricator.kde.org/D7245
AFFECTED FILES
data/syntax/rest.xml
To: turbov, #kate, #framework_syntax_hightlighting, dhaumann
Cc: dhaumann, #frame
chinmoyr added a comment.
Returning a small class instead of enum doesn't really reduce the number of
nested if's (which was why I didn't used an enum in first place). But it offers
bit more clarity and readability in if..else statements. The rest depends on me.
I want to confirm if thes
chinmoyr updated this revision to Diff 18320.
chinmoyr added a comment.
- Added class PrivilegeOperationReturnValue
- Fixed doc
- Removed hard-coded switch..case
- privilegeOperationStatus() -> requestPrivilegeOperation()
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6829?vs=1
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e1c6b588ec07: Support fractional scaling in generating the
sidebar preview (authored by davidedmundson).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6126?vs=15
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7361
To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliez
davidedmundson added a comment.
> Is it intentional that in AppletInterface removeAction does not remove them
from the KActionCollection but only m_actions QStringList? This is only done in
the WallpaperInterface.
It does implicitly. KactionCollection watches for actions being destroyed.
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7378
To: cfeck, mlaurent, davidedmundson
Cc: #frameworks
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
A compositor should send left events before deleting an output; however
if it doesn't, we don't want
cfeck created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
KPasswordDialog no longer starts with focus, because KPasswordLineEdit is not
a QLineEdit. Adding a focus proxy resolves the issue.
Regression reported on reddit.
REPOSITORY
R236 KWidgetsAd
martonmiklos updated this revision to Diff 18310.
martonmiklos added a comment.
Okay so:
- License updated to MIT
- Added detection for invalid RecordType (05<)
- Changed formatting to use builtin formats
- Added autotest case with a sample file with two malformed lines and a HTML
o
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:683893d1c17c: Add Pony highlighting (authored by
jpoelen2, committed by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7297?vs=18196&id=18308
dhaumann accepted this revision.
dhaumann added a comment.
Looks good to me, I think we should include this change.
@gszymaszek Shall I commit this, or do you have commit rights? If you don't
have commit rights, you should consider getting a KDE commit account.
REPOSITORY
R216 Syntax H
martonmiklos added a comment.
In https://phabricator.kde.org/D7367#136687, @cullmann wrote:
> Could you add a minimal example as unit test?
Sure, I have just seen that these xmls could be autotested.
> And could we have as license something like "MIT"?
Sure, I have no obj
dhaumann added a comment.
Please change the kateversion, and as Christoph mentioned please remove
hard-coded colors. You can find a list of all valid default styles here:
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
INLINE COMMENTS
> hex.xml:
dhaumann updated this revision to Diff 18307.
dhaumann added a comment.
Remove KTextEditor::Cursor and KTextEditor::Range based API. make test still
succeeds.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7337?vs=18210&id=18307
REVISION DETAIL
https
chinmoyr updated this revision to Diff 18301.
chinmoyr added a comment.
-Removed the hard-coded socket path. Now it will take socket path from
ioslave.
-Removed sendFileDescriptor(-1) calls.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=18300&id=18301
BRANCH
master
RE
chinmoyr updated this revision to Diff 18300.
chinmoyr added a comment.
- Removed the hard-coded socket path. Now it will take socket path from
ioslave.
- Removed sendFileDescriptor(-1) calls.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6197?vs=18235&id=18300
BRANCH
master
chinmoyr added a comment.
> Is it even needed to send -1, if we're going to return an error reply
anyway?
The current logic is "after a successful sendFileDescriptor close the
socket". So sending -1 was to ensure socket is closed.
REVISION DETAIL
https://phabricator.kde.org/D6197
To:
chinmoyr updated this revision to Diff 18298.
chinmoyr added a comment.
- add stopListening method to FdReceiver
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6709?vs=17012&id=18298
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6709
AFFECTED FILES
src/ioslaves/
gszymaszek updated this revision to Diff 18296.
gszymaszek added a comment.
Removed leading and trailing spaces inside XML tags (in `less.xml`), to make
it possible to build the framework.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5799?vs=
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> xdgforeign_v1.cpp:189
> +return p;
> +//Dave: there's no point creating a wrapper and then returning the low
> level struct.
> +//
graesslin added inline comments.
INLINE COMMENTS
> registry.h:938-939
> +
> +XdgExporterUnstableV1 *createXdgExporterUnstableV1(quint32 name, quint32
> version, QObject *parent = nullptr);
> +XdgImporterUnstableV1 *createXdgImporterUnstableV1(quint32 name, quint32
> version, QObject *pa
mart added inline comments.
INLINE COMMENTS
> xdgforeign_v1_interface.cpp:212
> +QHash parents;
> +QHash children;
> +
the children hash may have to become a multihash to permit more children for a
single parent
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/
mart edited the summary of this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7369
To: mart, #plasma, #kwin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
mart created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Implement the "foreign" wayland protocol.
A client can export a surface with an unique string as handle,
then
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1b2794985361: Avoid sending data offers from an invalid
source. (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7316?vs=18213&id=18293
cullmann added a comment.
Cool, I use them at work ;=)
Could you add a minimal example as unit test?
And could we have as license something like "MIT"?
For the coloring: it is preferred to use some of our default styles and no
hard coded colors to make color schemes possible.
R
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This is less cumbersome than having to select an item and then clicking "Edit
Entry"
TEST PLAN
- Verified that double-clicking one of the
martonmiklos created this revision.
martonmiklos added a project: Framework: Syntax Hightlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I have created an syntax highlight file for the Kate.
The coloring s
wbauer closed this revision.
wbauer added a comment.
Committed with
https://phabricator.kde.org/R241:a0fc624d50bbd7942834913ece52d26849ba7243
(forgot to mention this review in the commit message, sorry)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7341
To: wbaue
wbauer added a commit: R241:a0fc624d50bb: [KDesktopPropsPlugin] Create
destination directory if it doesn't exist.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7341
To: wbauer, dfaure
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:cf8ae465e430: [Theme] Use KConfig SimpleConfig (authored
by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7362?vs=18281&id=18284
REVI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7362
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We're passing it an absolute path to a file in our install directory anyway,
so we probably don't want inheritance.
TES
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Use lambdas instead.
TEST PLAN
This is slightly faster.
Verified that applet actions are still added and can be t
On Thursday August 17 2017 10:11:35 David Faure wrote:
>Maybe a missing devel package (optional dependency of solid) ?
>Check the cmake output when configuring solid...
The first thing I did of course ;) Everything appears to be there:
-- The following features have been enabled:
* Solid::Job,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R265 KConfigWidgets
BRANCH
deprecate-help
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks, dfaure
Cc: dhaumann
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130228/#review103611
---
Ship it!
Looks OK. Nice code duplication, but ok, this is
On mercredi 16 août 2017 11:12:43 CEST René J.V. Bertin wrote:
> Hi,
>
> As you know I've been building my own KF5 (and Qt5) packages for
> installation into /opt/local on an up-to-date Ubuntu 14.04LTS system. I
> register the required directories under /opt/local with DBus so (almost)
> everythin
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7341
To: wbauer, dfaure
Cc: #frameworks
41 matches
Mail list logo
